overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.546/13112 is trying to acquire lock:
ffff888062326c50 (&oi->ip_alloc_sem#2){++++}-{4:4}, at: ocfs2_xattr_set+0x4a4/0x13f0 fs/ocfs2/xattr.c:4032

but task is already holding lock:
ffff888062326cd8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13f0 fs/ocfs2/xattr.c:4024

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x92/0x200 kernel/locking/rwsem.c:1574
       ocfs2_xattr_get+0xf4/0x260 fs/ocfs2/xattr.c:1716
       __vfs_getxattr+0x412/0x440 fs/xattr.c:446
       smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:298
       smack_d_instantiate+0x5bb/0x810 security/smack/smack_lsm.c:3682
       security_d_instantiate+0x106/0x1d0 security/security.c:3783
       d_instantiate+0x54/0xb0 fs/dcache.c:2267
       ocfs2_mknod+0x199e/0x2190 fs/ocfs2/namei.c:453
       ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:661
       vfs_mkdir+0x417/0x670 fs/namei.c:5428
       filename_mkdirat+0x288/0x560 fs/namei.c:5461
       __do_sys_mkdirat fs/namei.c:5482 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5479
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x16a/0x530 arch/x86/entry/syscall_64.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x92/0x200 kernel/locking/rwsem.c:1574
       ocfs2_start_trans+0x3aa/0x700 fs/ocfs2/journal.c:379
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:801 [inline]
       ocfs2_reserve_suballoc_bits+0x7b7/0x4850 fs/ocfs2/suballoc.c:950
       ocfs2_reserve_new_metadata_blocks+0x415/0x9a0 fs/ocfs2/suballoc.c:1100
       ocfs2_mknod+0xe79/0x2190 fs/ocfs2/namei.c:350
       ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:661
       vfs_mkdir+0x417/0x670 fs/namei.c:5428
       filename_mkdirat+0x288/0x560 fs/namei.c:5461
       __do_sys_mkdirat fs/namei.c:5482 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5479
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x16a/0x530 arch/x86/entry/syscall_64.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#3){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2a7/0x700 fs/ocfs2/journal.c:377
       ocfs2_setattr+0x819/0x1d60 fs/ocfs2/file.c:1300
       notify_change+0xbb8/0xec0 fs/attr.c:556
       ovl_do_notify_change fs/overlayfs/overlayfs.h:211 [inline]
       ovl_workdir_create+0x6dd/0x970 fs/overlayfs/super.c:400
       ovl_make_workdir fs/overlayfs/super.c:718 [inline]
       ovl_get_workdir+0x339/0x1980 fs/overlayfs/super.c:876
       ovl_fill_super_creds fs/overlayfs/super.c:1488 [inline]
       ovl_fill_super+0x1771/0x46a0 fs/overlayfs/super.c:1611
       get_tree_super fs/super.c:1360 [inline]
       get_tree_nodev+0xbe/0x150 fs/super.c:1380
       vfs_get_tree+0x92/0x2a0 fs/super.c:1881
       fc_mount fs/namespace.c:1282 [inline]
       do_new_mount_fc fs/namespace.c:3910 [inline]
       do_new_mount+0x325/0xb00 fs/namespace.c:3986
       do_mount fs/namespace.c:4350 [inline]
       __do_sys_mount fs/namespace.c:4565 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4542
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x16a/0x530 arch/x86/entry/syscall_64.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_alloc_sem#2){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3209 [inline]
       check_prevs_add kernel/locking/lockdep.c:3328 [inline]
       validate_chain kernel/locking/lockdep.c:3952 [inline]
       __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
       lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
       down_write+0x35/0x50 kernel/locking/rwsem.c:1631
       ocfs2_xattr_set+0x4a4/0x13f0 fs/ocfs2/xattr.c:4032
       __vfs_setxattr+0x442/0x480 fs/xattr.c:223
       __vfs_setxattr_noperm+0x12a/0x660 fs/xattr.c:257
       vfs_setxattr+0x151/0x370 fs/xattr.c:344
       ovl_do_setxattr fs/overlayfs/overlayfs.h:328 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:340 [inline]
       ovl_make_workdir fs/overlayfs/super.c:764 [inline]
       ovl_get_workdir+0xd13/0x1980 fs/overlayfs/super.c:876
       ovl_fill_super_creds fs/overlayfs/super.c:1488 [inline]
       ovl_fill_super+0x1771/0x46a0 fs/overlayfs/super.c:1611
       get_tree_super fs/super.c:1360 [inline]
       get_tree_nodev+0xbe/0x150 fs/super.c:1380
       vfs_get_tree+0x92/0x2a0 fs/super.c:1881
       fc_mount fs/namespace.c:1282 [inline]
       do_new_mount_fc fs/namespace.c:3910 [inline]
       do_new_mount+0x325/0xb00 fs/namespace.c:3986
       do_mount fs/namespace.c:4350 [inline]
       __do_sys_mount fs/namespace.c:4565 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4542
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x16a/0x530 arch/x86/entry/syscall_64.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_alloc_sem#2 --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&oi->ip_alloc_sem#2);

 *** DEADLOCK ***

locks held by syz.6.546/13112: 4, on CPU#0:
 #0: ffff888064c0c0f8 (&type->s_umount_key#61/1){+.+.}-{4:4}, at: alloc_super fs/super.c:347 [inline]
 #0: ffff888064c0c0f8 (&type->s_umount_key#61/1){+.+.}-{4:4}, at: sget_fc+0x9d5/0x1d00 fs/super.c:846
 #1: ffff888053e8c528 (sb_writers#16){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:531
 #2: ffff888062327000 (&sb->s_type->i_mutex_key#27){++++}-{4:4}, at: inode_lock include/linux/fs.h:1026 [inline]
 #2: ffff888062327000 (&sb->s_type->i_mutex_key#27){++++}-{4:4}, at: vfs_setxattr+0x12b/0x370 fs/xattr.c:343
 #3: ffff888062326cd8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13f0 fs/ocfs2/xattr.c:4024

stack backtrace:
CPU: 0 UID: 0 PID: 13112 Comm: syz.6.546 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2087
 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2219
 check_prev_add kernel/locking/lockdep.c:3209 [inline]
 check_prevs_add kernel/locking/lockdep.c:3328 [inline]
 validate_chain kernel/locking/lockdep.c:3952 [inline]
 __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
 down_write+0x35/0x50 kernel/locking/rwsem.c:1631
 ocfs2_xattr_set+0x4a4/0x13f0 fs/ocfs2/xattr.c:4032
 __vfs_setxattr+0x442/0x480 fs/xattr.c:223
 __vfs_setxattr_noperm+0x12a/0x660 fs/xattr.c:257
 vfs_setxattr+0x151/0x370 fs/xattr.c:344
 ovl_do_setxattr fs/overlayfs/overlayfs.h:328 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:340 [inline]
 ovl_make_workdir fs/overlayfs/super.c:764 [inline]
 ovl_get_workdir+0xd13/0x1980 fs/overlayfs/super.c:876
 ovl_fill_super_creds fs/overlayfs/super.c:1488 [inline]
 ovl_fill_super+0x1771/0x46a0 fs/overlayfs/super.c:1611
 get_tree_super fs/super.c:1360 [inline]
 get_tree_nodev+0xbe/0x150 fs/super.c:1380
 vfs_get_tree+0x92/0x2a0 fs/super.c:1881
 fc_mount fs/namespace.c:1282 [inline]
 do_new_mount_fc fs/namespace.c:3910 [inline]
 do_new_mount+0x325/0xb00 fs/namespace.c:3986
 do_mount fs/namespace.c:4350 [inline]
 __do_sys_mount fs/namespace.c:4565 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4542
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x16a/0x530 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f2e64938f19
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2e62b86028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f2e64bb5fa0 RCX: 00007f2e64938f19
RDX: 00002000000004c0 RSI: 0000200000000480 RDI: 0000000000000000
RBP: 00007f2e649c7f6d R08: 0000200000000500 R09: 0000000000000000
R10: 0000000010000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f2e64bb6038 R14: 00007f2e64bb5fa0 R15: 00007ffdc59589b8
 </TASK>
overlayfs: upper fs missing required features.