possible deadlock in ocfs2_xattr_set

Status: upstream: reported on 2024/09/14 01:11
Reported-by: syzbot+1cd2ae4e4eb3cb4218a3@syzkaller.appspotmail.com
First crash: 695d, last: 2d07h
Similar bugs (3)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in ocfs2_xattr_set prio:high ocfs2 4 9331 11h13m 699d 0/29 upstream: reported on 2024/09/10 05:07
linux-6.6 possible deadlock in ocfs2_xattr_set 4 447 4d18h 416d 0/2 upstream: reported on 2025/06/19 18:15
linux-6.1 possible deadlock in ocfs2_xattr_set 4 914 3h38m 684d 0/3 upstream: reported on 2024/09/25 09:02

Sample crash report:
loop1: detected capacity change from 0 to 32768
ocfs2: Mounting device (7,1) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.1.2294/15559 is trying to acquire lock:
ffff88805ea41808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff88805ea41808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_xattr_set+0xbd0/0x1390 fs/ocfs2/xattr.c:3626

but task is already holding lock:
ffff88805ea44e38 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x47d/0x1390 fs/ocfs2/xattr.c:3587

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x15de/0x2510 fs/ocfs2/namei.c:410
       ocfs2_mkdir+0x192/0x420 fs/ocfs2/namei.c:657
       vfs_mkdir+0x386/0x570 fs/namei.c:4073
       do_mkdirat+0x1dd/0x5c0 fs/namei.c:4098
       __do_sys_mkdirat fs/namei.c:4113 [inline]
       __se_sys_mkdirat fs/namei.c:4111 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (jbd2_handle){++++}-{0:0}:
       jbd2_journal_lock_updates+0xa4/0x390 fs/jbd2/transaction.c:881
       __ocfs2_flush_truncate_log+0x2b4/0x1110 fs/ocfs2/alloc.c:6027
       ocfs2_flush_truncate_log fs/ocfs2/alloc.c:6074 [inline]
       ocfs2_truncate_log_shutdown+0x140/0x2f0 fs/ocfs2/alloc.c:6318
       ocfs2_dismount_volume+0x1e9/0x890 fs/ocfs2/super.c:1887
       generic_shutdown_super+0x130/0x300 fs/super.c:475
       kill_block_super+0x7c/0xe0 fs/super.c:1427
       deactivate_locked_super+0x93/0xf0 fs/super.c:335
       cleanup_mnt+0x426/0x4d0 fs/namespace.c:1148
       task_work_run+0x125/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307
       do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_xattr_set+0xbd0/0x1390 fs/ocfs2/xattr.c:3626
       __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
       __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x2cb/0x360 fs/xattr.c:611
       path_setxattr+0x147/0x290 fs/xattr.c:630
       __do_sys_setxattr fs/xattr.c:646 [inline]
       __se_sys_setxattr fs/xattr.c:642 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6);

 *** DEADLOCK ***

3 locks held by syz.1.2294/15559:
 #0: ffff888057148460 (sb_writers#14){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386
 #1: ffff88805ea45108 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff88805ea45108 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: vfs_setxattr+0x140/0x2e0 fs/xattr.c:302
 #2: ffff88805ea44e38 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x47d/0x1390 fs/ocfs2/xattr.c:3587

stack backtrace:
CPU: 0 PID: 15559 Comm: syz.1.2294 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:787 [inline]
 ocfs2_xattr_set+0xbd0/0x1390 fs/ocfs2/xattr.c:3626
 __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
 __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x167/0x2e0 fs/xattr.c:303
 do_setxattr fs/xattr.c:588 [inline]
 setxattr+0x2cb/0x360 fs/xattr.c:611
 path_setxattr+0x147/0x290 fs/xattr.c:630
 __do_sys_setxattr fs/xattr.c:646 [inline]
 __se_sys_setxattr fs/xattr.c:642 [inline]
 __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f41b55260d9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f41b377e028 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 00007f41b57adfa0 RCX: 00007f41b55260d9
RDX: 0000200000000880 RSI: 0000200000000080 RDI: 0000200000000040
RBP: 00007f41b55bd024 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000bfe R11: 0000000000000246 R12: 0000000000000000
R13: 00007f41b57ae038 R14: 00007f41b57adfa0 R15: 00007fff13637128
 </TASK>

Crashes (485):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/08/08 08:22 linux-5.15.y aabd761612db 5d63f80b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/07/21 01:59 linux-5.15.y c86c4726e7f0 de6a700d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/07/20 10:57 linux-5.15.y c86c4726e7f0 de6a700d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/07/09 08:18 linux-5.15.y c86c4726e7f0 b9f1ceaa .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/07/07 20:00 linux-5.15.y c86c4726e7f0 76cdc0c0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/07/01 03:23 linux-5.15.y eceeec79dbc6 00a5cf1c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/06/30 15:08 linux-5.15.y eceeec79dbc6 00e8b0fd .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/06/30 07:02 linux-5.15.y eceeec79dbc6 fff8d0a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/06/29 12:30 linux-5.15.y eceeec79dbc6 6a0c72dc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/06/23 19:57 linux-5.15.y eceeec79dbc6 4b1d8f01 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/06/23 10:41 linux-5.15.y eceeec79dbc6 5a630be6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/06/19 21:23 linux-5.15.y eceeec79dbc6 43bfcdb0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/06/19 08:59 linux-5.15.y dc027a595035 570c59ee .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/05/31 15:56 linux-5.15.y 241d66fa280c 6b4a8443 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/05/12 09:57 linux-5.15.y de8dfb3f0278 07aeade5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/05/09 09:22 linux-5.15.y de8dfb3f0278 29233ece .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/04/29 16:19 linux-5.15.y b9d57c40a767 7ca9e4d8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/04/28 01:02 linux-5.15.y b9d57c40a767 ce741359 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/04/27 17:48 linux-5.15.y b9d57c40a767 0f700595 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/04/20 01:02 linux-5.15.y b9d57c40a767 303e2802 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/04/11 17:01 linux-5.15.y 91d48252ad4b 38c8e246 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/04/06 16:20 linux-5.15.y 91d48252ad4b 4440e7c2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/04/06 08:42 linux-5.15.y 91d48252ad4b 4440e7c2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/04/02 11:19 linux-5.15.y 91d48252ad4b 91bc79b0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/04/02 01:36 linux-5.15.y 91d48252ad4b 0cb124d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/03/20 08:15 linux-5.15.y 91d48252ad4b 2f245add .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/03/09 21:10 linux-5.15.y 91d48252ad4b 176bead5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/03/02 17:03 linux-5.15.y 3330a8d33e08 b9dd6534 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/02/23 22:55 linux-5.15.y 3330a8d33e08 41d2fa6a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/02/17 20:39 linux-5.15.y e45d5d41c134 06ec4f7b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/20 19:23 linux-5.15.y 9eec9a14ee10 06648d9c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/20 14:22 linux-5.15.y 9eec9a14ee10 06648d9c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/20 14:22 linux-5.15.y 9eec9a14ee10 06648d9c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/16 12:21 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/15 10:10 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/12 01:03 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/09 14:47 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/08 18:55 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/08 02:24 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/06 13:58 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/06 00:48 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/05 16:14 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/03 21:14 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/03 13:27 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2026/01/03 12:23 linux-5.15.y 68efe5a6c16a d6526ea3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2024/09/14 01:10 linux-5.15.y 3a5928702e71 b58f933c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_xattr_set
2025/08/21 20:23 linux-5.15.y c79648372d02 3e79b825 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ocfs2_xattr_set
* Struck through repros no longer work on HEAD.