syzbot

JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,8) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.8.3141/15178 is trying to acquire lock:
ffff88805aebc2d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff88805aebc2d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_xattr_set+0xba4/0x13e0 fs/ocfs2/xattr.c:3622

but task is already holding lock:
ffff88805aeb9538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x476/0x13e0 fs/ocfs2/xattr.c:3583

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x30a/0x770 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x140f/0x2300 fs/ocfs2/namei.c:410
       ocfs2_mkdir+0x196/0x430 fs/ocfs2/namei.c:657
       vfs_mkdir+0x296/0x440 fs/namei.c:4121
       do_mkdirat+0x1dc/0x450 fs/namei.c:4144
       __do_sys_mkdirat fs/namei.c:4159 [inline]
       __se_sys_mkdirat fs/namei.c:4157 [inline]
       __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4157
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3a8/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_modify_bh+0xe4/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1445/0x1800 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x757/0xb80 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x2dc/0x5d0 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x1c9/0x490 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x417d/0x5010 fs/ocfs2/super.c:1141
       mount_bdev+0x221/0x2d0 fs/super.c:1643
       legacy_get_tree+0xea/0x180 fs/fs_context.c:662
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24b/0xa40 fs/namespace.c:3386
       do_mount fs/namespace.c:3726 [inline]
       __do_sys_mount fs/namespace.c:3935 [inline]
       __se_sys_mount+0x2e7/0x3d0 fs/namespace.c:3912
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x2a9/0x6f0 fs/ocfs2/journal.c:370
       ocfs2_shutdown_local_alloc+0x1fc/0xaa0 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1e5/0x8a0 fs/ocfs2/super.c:1881
       generic_shutdown_super+0x134/0x2b0 fs/super.c:693
       kill_block_super+0x44/0x90 fs/super.c:1660
       deactivate_locked_super+0x97/0x100 fs/super.c:481
       cleanup_mnt+0x43b/0x4d0 fs/namespace.c:1259
       task_work_run+0x1d4/0x260 kernel/task_work.c:245
       resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
       exit_to_user_mode_loop+0xe6/0x110 kernel/entry/common.c:177
       exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:210
       __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline]
       syscall_exit_to_user_mode+0x1a/0x50 kernel/entry/common.c:302
       do_syscall_64+0x61/0xa0 arch/x86/entry/common.c:82
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}:
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       __ocfs2_flush_truncate_log+0x352/0x1130 fs/ocfs2/alloc.c:6046
       ocfs2_flush_truncate_log+0x4f/0x60 fs/ocfs2/alloc.c:6076
       ocfs2_sync_fs+0x11d/0x330 fs/ocfs2/super.c:402
       sync_filesystem+0x1c2/0x220 fs/sync.c:66
       generic_shutdown_super+0x6f/0x2b0 fs/super.c:666
       kill_block_super+0x44/0x90 fs/super.c:1660
       deactivate_locked_super+0x97/0x100 fs/super.c:481
       cleanup_mnt+0x43b/0x4d0 fs/namespace.c:1259
       task_work_run+0x1d4/0x260 kernel/task_work.c:245
       resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
       exit_to_user_mode_loop+0xe6/0x110 kernel/entry/common.c:177
       exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:210
       __syscall_exit_to_user_mode_work kernel/entry/common.c:291 [inline]
       syscall_exit_to_user_mode+0x1a/0x50 kernel/entry/common.c:302
       do_syscall_64+0x61/0xa0 arch/x86/entry/common.c:82
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_xattr_set+0xba4/0x13e0 fs/ocfs2/xattr.c:3622
       __vfs_setxattr+0x431/0x470 fs/xattr.c:201
       __vfs_setxattr_noperm+0x12d/0x5e0 fs/xattr.c:235
       vfs_setxattr+0x16b/0x2f0 fs/xattr.c:322
       do_setxattr fs/xattr.c:630 [inline]
       path_setxattr+0x3f3/0x5d0 fs/xattr.c:659
       __do_sys_setxattr fs/xattr.c:677 [inline]
       __se_sys_setxattr fs/xattr.c:673 [inline]
       __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:673
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);

 *** DEADLOCK ***

3 locks held by syz.8.3141/15178:
 #0: ffff8880594ca418 (sb_writers#15){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:412
 #1: ffff88805aeb9818 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805aeb9818 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: vfs_setxattr+0x144/0x2f0 fs/xattr.c:321
 #2: ffff88805aeb9538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x476/0x13e0 fs/ocfs2/xattr.c:3583

stack backtrace:
CPU: 0 PID: 15178 Comm: syz.8.3141 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/18/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 down_write+0x97/0x200 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_xattr_set+0xba4/0x13e0 fs/ocfs2/xattr.c:3622
 __vfs_setxattr+0x431/0x470 fs/xattr.c:201
 __vfs_setxattr_noperm+0x12d/0x5e0 fs/xattr.c:235
 vfs_setxattr+0x16b/0x2f0 fs/xattr.c:322
 do_setxattr fs/xattr.c:630 [inline]
 path_setxattr+0x3f3/0x5d0 fs/xattr.c:659
 __do_sys_setxattr fs/xattr.c:677 [inline]
 __se_sys_setxattr fs/xattr.c:673 [inline]
 __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:673
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7ff3bb39cdd9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff3b95f6028 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 00007ff3bb615fa0 RCX: 00007ff3bb39cdd9
RDX: 0000200000000200 RSI: 00002000000001c0 RDI: 0000200000000100
RBP: 00007ff3bb432d69 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000014 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ff3bb616038 R14: 00007ff3bb615fa0 R15: 00007ffe27acd3c8
 </TASK>