syzbot

loop6: detected capacity change from 0 to 32768
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,6) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.1378/10890 is trying to acquire lock:
ffff88805dc63498 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff88805dc63498 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_xattr_set+0xbe8/0x13a0 fs/ocfs2/xattr.c:3622

but task is already holding lock:
ffff88805dc606f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x495/0x13a0 fs/ocfs2/xattr.c:3583

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x30a/0x770 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x1427/0x2310 fs/ocfs2/namei.c:410
       ocfs2_mkdir+0x196/0x430 fs/ocfs2/namei.c:657
       vfs_mkdir+0x2a5/0x470 fs/namei.c:4121
       do_mkdirat+0x1dc/0x450 fs/namei.c:4144
       __do_sys_mkdirat fs/namei.c:4159 [inline]
       __se_sys_mkdirat fs/namei.c:4157 [inline]
       __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4157
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3a8/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_modify_bh+0xe4/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1433/0x17d0 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x734/0xb30 fs/quota/dquot.c:2492
       dquot_load_quota_inode+0x2d7/0x5c0 fs/quota/dquot.c:2529
       ocfs2_enable_quotas+0x1c4/0x4a0 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x4187/0x5030 fs/ocfs2/super.c:1141
       mount_bdev+0x21c/0x2c0 fs/super.c:1643
       legacy_get_tree+0xea/0x180 fs/fs_context.c:662
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24a/0xa40 fs/namespace.c:3386
       do_mount fs/namespace.c:3726 [inline]
       __do_sys_mount fs/namespace.c:3935 [inline]
       __se_sys_mount+0x2e7/0x3d0 fs/namespace.c:3912
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (sb_internal#3){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x2a9/0x6f0 fs/ocfs2/journal.c:370
       ocfs2_remove_btree_range+0x816/0x15e0 fs/ocfs2/alloc.c:5752
       ocfs2_commit_truncate+0xc27/0x24b0 fs/ocfs2/alloc.c:7353
       ocfs2_truncate_for_delete fs/ocfs2/inode.c:623 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1a0b/0x41a0 fs/ocfs2/inode.c:1219
       evict+0x4b7/0x8a0 fs/inode.c:705
       d_delete_notify include/linux/fsnotify.h:269 [inline]
       vfs_rmdir+0x378/0x4b0 fs/namei.c:4217
       do_rmdir+0x29f/0x590 fs/namei.c:4263
       __do_sys_unlinkat fs/namei.c:4441 [inline]
       __se_sys_unlinkat fs/namei.c:4435 [inline]
       __x64_sys_unlinkat+0xc4/0xe0 fs/namei.c:4435
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_xattr_set+0xbe8/0x13a0 fs/ocfs2/xattr.c:3622
       __vfs_setxattr+0x437/0x470 fs/xattr.c:201
       __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:235
       vfs_setxattr+0x16b/0x2f0 fs/xattr.c:322
       do_setxattr fs/xattr.c:630 [inline]
       path_setxattr+0x33a/0x590 fs/xattr.c:659
       __do_sys_setxattr fs/xattr.c:677 [inline]
       __se_sys_setxattr fs/xattr.c:673 [inline]
       __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:673
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);

 *** DEADLOCK ***

3 locks held by syz.6.1378/10890:
 #0: ffff888075b10418 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:412
 #1: ffff88805dc609d8 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805dc609d8 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: vfs_setxattr+0x144/0x2f0 fs/xattr.c:321
 #2: ffff88805dc606f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x495/0x13a0 fs/ocfs2/xattr.c:3583

stack backtrace:
CPU: 1 PID: 10890 Comm: syz.6.1378 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 down_write+0x97/0x200 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_xattr_set+0xbe8/0x13a0 fs/ocfs2/xattr.c:3622
 __vfs_setxattr+0x437/0x470 fs/xattr.c:201
 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:235
 vfs_setxattr+0x16b/0x2f0 fs/xattr.c:322
 do_setxattr fs/xattr.c:630 [inline]
 path_setxattr+0x33a/0x590 fs/xattr.c:659
 __do_sys_setxattr fs/xattr.c:677 [inline]
 __se_sys_setxattr fs/xattr.c:673 [inline]
 __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:673
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fef6cd9ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fef6dbcc028 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 00007fef6d015fa0 RCX: 00007fef6cd9ce59
RDX: 0000200000000200 RSI: 00002000000001c0 RDI: 0000200000000000
RBP: 00007fef6ce32e6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000841 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fef6d016038 R14: 00007fef6d015fa0 R15: 00007ffc6ccc87b8
 </TASK>