syzbot

ocfs2: Mounting device (7,6) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.2428/11428 is trying to acquire lock:
ffff88804e84a648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff88804e84a648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_xattr_set+0xba0/0x13e0 fs/ocfs2/xattr.c:3626

but task is already holding lock:
ffff888071969538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x472/0x13e0 fs/ocfs2/xattr.c:3587

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x15e8/0x25b0 fs/ocfs2/namei.c:410
       ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x1181/0x2ee0 fs/namei.c:3788
       do_filp_open+0x1f1/0x430 fs/namei.c:3818
       do_sys_openat2+0x150/0x4b0 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_openat fs/open.c:1352 [inline]
       __se_sys_openat fs/open.c:1347 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1347
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374
       ocfs2_symlink+0x11ad/0x2870 fs/ocfs2/namei.c:1915
       vfs_symlink+0x247/0x3d0 fs/namei.c:4479
       do_symlinkat+0x1b6/0x400 fs/namei.c:4508
       __do_sys_symlinkat fs/namei.c:4525 [inline]
       __se_sys_symlinkat fs/namei.c:4522 [inline]
       __x64_sys_symlinkat+0x95/0xa0 fs/namei.c:4522
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (sb_internal#4){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2a5/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_remove_btree_range+0x845/0x15e0 fs/ocfs2/alloc.c:5752
       ocfs2_commit_truncate+0xb8f/0x1de0 fs/ocfs2/alloc.c:7353
       ocfs2_truncate_for_delete fs/ocfs2/inode.c:623 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x10eb/0x4630 fs/ocfs2/inode.c:1219
       evict+0x4c9/0x8d0 fs/inode.c:705
       do_unlinkat+0x388/0x580 fs/namei.c:4405
       __do_sys_unlinkat fs/namei.c:4441 [inline]
       __se_sys_unlinkat fs/namei.c:4434 [inline]
       __x64_sys_unlinkat+0xd1/0xe0 fs/namei.c:4434
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
       lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_xattr_set+0xba0/0x13e0 fs/ocfs2/xattr.c:3626
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x190/0x2b0 fs/ocfs2/acl.c:285
       set_posix_acl fs/posix_acl.c:1160 [inline]
       posix_acl_xattr_set+0x387/0x3f0 fs/posix_acl.c:1189
       __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:309
       do_setxattr fs/xattr.c:594 [inline]
       setxattr+0x346/0x360 fs/xattr.c:617
       path_setxattr+0x147/0x290 fs/xattr.c:636
       __do_sys_setxattr fs/xattr.c:652 [inline]
       __se_sys_setxattr fs/xattr.c:648 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:648
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);

 *** DEADLOCK ***

3 locks held by syz.6.2428/11428:
 #0: ffff8880782b4460 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:402
 #1: ffff888071969808 (&type->i_mutex_dir_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff888071969808 (&type->i_mutex_dir_key#21){+.+.}-{3:3}, at: vfs_setxattr+0x140/0x2e0 fs/xattr.c:308
 #2: ffff888071969538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x472/0x13e0 fs/ocfs2/xattr.c:3587

stack backtrace:
CPU: 0 PID: 11428 Comm: syz.6.2428 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x24e lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
 lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 ocfs2_xattr_set+0xba0/0x13e0 fs/ocfs2/xattr.c:3626
 ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
 ocfs2_iop_set_acl+0x190/0x2b0 fs/ocfs2/acl.c:285
 set_posix_acl fs/posix_acl.c:1160 [inline]
 posix_acl_xattr_set+0x387/0x3f0 fs/posix_acl.c:1189
 __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
 __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x167/0x2e0 fs/xattr.c:309
 do_setxattr fs/xattr.c:594 [inline]
 setxattr+0x346/0x360 fs/xattr.c:617
 path_setxattr+0x147/0x290 fs/xattr.c:636
 __do_sys_setxattr fs/xattr.c:652 [inline]
 __se_sys_setxattr fs/xattr.c:648 [inline]
 __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:648
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7feecff9acb9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007feed0dd8028 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 00007feed0215fa0 RCX: 00007feecff9acb9
RDX: 0000200000002b40 RSI: 0000200000002a40 RDI: 0000200000002a00
RBP: 00007feed0008bf7 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000024 R11: 0000000000000246 R12: 0000000000000000
R13: 00007feed0216038 R14: 00007feed0215fa0 R15: 00007ffd351c09f8
 </TASK>
OCFS2: ERROR (device loop6): int ocfs2_validate_gd_self(struct super_block *, struct buffer_head *, int): Group descriptor #1792 has bad signature 
On-disk corruption discovered. Please run fsck.ocfs2 once the filesystem is unmounted.
OCFS2: File system is now read-only.
(syz.6.2428,11428,0):ocfs2_search_chain:1785 ERROR: status = -30
(syz.6.2428,11428,0):ocfs2_search_chain:1871 ERROR: status = -30
(syz.6.2428,11428,0):ocfs2_claim_suballoc_bits:1950 ERROR: status = -30
(syz.6.2428,11428,0):ocfs2_claim_suballoc_bits:1993 ERROR: status = -30
(syz.6.2428,11428,0):ocfs2_claim_new_inode:2226 ERROR: status = -30
(syz.6.2428,11428,0):ocfs2_claim_new_inode:2241 ERROR: status = -30
(syz.6.2428,11428,0):ocfs2_mknod_locked:639 ERROR: status = -30
(syz.6.2428,11428,0):ocfs2_mknod:385 ERROR: status = -30
(syz.6.2428,11428,0):ocfs2_mknod:502 ERROR: status = -30
(syz.6.2428,11428,0):ocfs2_mkdir:659 ERROR: status = -30