syzbot

overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.8.1200/17298 is trying to acquire lock:
ffff88805edd1c40 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
ffff88805edd1c40 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_xattr_set+0xbeb/0x13a0 fs/ocfs2/xattr.c:3653

but task is already holding lock:
ffff8880682ecb58 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13a0 fs/ocfs2/xattr.c:3614

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1625
       ocfs2_xattr_set_handle+0x3f7/0x820 fs/ocfs2/xattr.c:3532
       ocfs2_init_security_set+0xbd/0xe0 fs/ocfs2/xattr.c:7342
       ocfs2_mknod+0x16c8/0x2240 fs/ocfs2/namei.c:423
       ocfs2_mkdir+0x181/0x460 fs/ocfs2/namei.c:660
       vfs_mkdir+0x402/0x620 fs/namei.c:5271
       filename_mkdirat+0x289/0x520 fs/namei.c:5304
       __do_sys_mkdirat fs/namei.c:5325 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5322
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1568
       ocfs2_start_trans+0x3ac/0x700 fs/ocfs2/journal.c:369
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:779 [inline]
       ocfs2_reserve_suballoc_bits+0x7b7/0x4850 fs/ocfs2/suballoc.c:928
       ocfs2_reserve_new_metadata_blocks+0x415/0x9a0 fs/ocfs2/suballoc.c:1078
       ocfs2_mknod+0x10e1/0x2240 fs/ocfs2/namei.c:351
       ocfs2_mkdir+0x181/0x460 fs/ocfs2/namei.c:660
       vfs_mkdir+0x402/0x620 fs/namei.c:5271
       filename_mkdirat+0x289/0x520 fs/namei.c:5304
       __do_sys_mkdirat fs/namei.c:5325 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5322
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (sb_internal#3){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:779 [inline]
       ocfs2_reserve_suballoc_bits+0x7b7/0x4850 fs/ocfs2/suballoc.c:928
       ocfs2_reserve_new_metadata_blocks+0x415/0x9a0 fs/ocfs2/suballoc.c:1078
       ocfs2_mknod+0x10e1/0x2240 fs/ocfs2/namei.c:351
       ocfs2_mkdir+0x181/0x460 fs/ocfs2/namei.c:660
       vfs_mkdir+0x402/0x620 fs/namei.c:5271
       filename_mkdirat+0x289/0x520 fs/namei.c:5304
       __do_sys_mkdirat fs/namei.c:5325 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5322
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[GLOBAL_BITMAP_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1625
       inode_lock include/linux/fs.h:1029 [inline]
       __ocfs2_flush_truncate_log+0x339/0x1230 fs/ocfs2/alloc.c:6063
       ocfs2_flush_truncate_log fs/ocfs2/alloc.c:6093 [inline]
       ocfs2_truncate_log_shutdown+0x143/0x310 fs/ocfs2/alloc.c:6354
       ocfs2_dismount_volume+0x1f4/0x8d0 fs/ocfs2/super.c:1827
       generic_shutdown_super+0x13d/0x2d0 fs/super.c:646
       kill_block_super+0x44/0x90 fs/super.c:1725
       deactivate_locked_super+0xbc/0x130 fs/super.c:476
       cleanup_mnt+0x3d3/0x460 fs/namespace.c:1312
       task_work_run+0x1d9/0x270 kernel/task_work.c:233
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       __exit_to_user_mode_loop kernel/entry/common.c:67 [inline]
       exit_to_user_mode_loop+0x193/0x6b0 kernel/entry/common.c:98
       __exit_to_user_mode_prepare include/linux/irq-entry-common.h:207 [inline]
       syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:230 [inline]
       syscall_exit_to_user_mode include/linux/entry-common.h:318 [inline]
       do_syscall_64+0x353/0x580 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x1520/0x2cc0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1625
       inode_lock include/linux/fs.h:1029 [inline]
       ocfs2_xattr_set+0xbeb/0x13a0 fs/ocfs2/xattr.c:3653
       __vfs_setxattr+0x442/0x480 fs/xattr.c:218
       __vfs_setxattr_noperm+0x12a/0x660 fs/xattr.c:252
       vfs_setxattr+0x163/0x360 fs/xattr.c:339
       ovl_do_setxattr fs/overlayfs/overlayfs.h:323 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:335 [inline]
       ovl_make_workdir fs/overlayfs/super.c:724 [inline]
       ovl_get_workdir fs/overlayfs/super.c:836 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
       ovl_fill_super+0x4a39/0x5d80 fs/overlayfs/super.c:1560
       vfs_get_super fs/super.c:1327 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1346
       vfs_get_tree+0x92/0x2a0 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3761 [inline]
       do_new_mount+0x319/0xdc0 fs/namespace.c:3837
       do_mount fs/namespace.c:4170 [inline]
       __do_sys_mount fs/namespace.c:4386 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4363
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]);

 *** DEADLOCK ***

4 locks held by syz.8.1200/17298:
 #0: ffff8880382f20d0 (&type->s_umount_key#89/1){+.+.}-{4:4}, at: alloc_super+0x283/0xa70 fs/super.c:345
 #1: ffff88802bb38480 (sb_writers#16){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:493
 #2: ffff8880682ece80 (&sb->s_type->i_mutex_key#28){++++}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
 #2: ffff8880682ece80 (&sb->s_type->i_mutex_key#28){++++}-{4:4}, at: vfs_setxattr+0x13e/0x360 fs/xattr.c:338
 #3: ffff8880682ecb58 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13a0 fs/ocfs2/xattr.c:3614

stack backtrace:
CPU: 1 UID: 0 PID: 17298 Comm: syz.8.1200 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x1520/0x2cc0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1625
 inode_lock include/linux/fs.h:1029 [inline]
 ocfs2_xattr_set+0xbeb/0x13a0 fs/ocfs2/xattr.c:3653
 __vfs_setxattr+0x442/0x480 fs/xattr.c:218
 __vfs_setxattr_noperm+0x12a/0x660 fs/xattr.c:252
 vfs_setxattr+0x163/0x360 fs/xattr.c:339
 ovl_do_setxattr fs/overlayfs/overlayfs.h:323 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:335 [inline]
 ovl_make_workdir fs/overlayfs/super.c:724 [inline]
 ovl_get_workdir fs/overlayfs/super.c:836 [inline]
 ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
 ovl_fill_super+0x4a39/0x5d80 fs/overlayfs/super.c:1560
 vfs_get_super fs/super.c:1327 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1346
 vfs_get_tree+0x92/0x2a0 fs/super.c:1754
 fc_mount fs/namespace.c:1193 [inline]
 do_new_mount_fc fs/namespace.c:3761 [inline]
 do_new_mount+0x319/0xdc0 fs/namespace.c:3837
 do_mount fs/namespace.c:4170 [inline]
 __do_sys_mount fs/namespace.c:4386 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4363
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f84173ace59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8414538028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f8417626540 RCX: 00007f84173ace59
RDX: 0000200000000000 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007f8417442d6f R08: 00002000000003c0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f84176265d8 R14: 00007f8417626540 R15: 00007ffc5ae94578
 </TASK>
overlayfs: upper fs missing required features.
ocfs2: Unmounting device (7,8) on (node local)