KCSAN: data-race in generic_fillattr / shmem_mknod (3)

Status: moderation: reported on 2026/11/20 00:07
Subsystems: fs
Labels: prio:low race:benign
[Documentation on labels]
Reported-by: syzbot+0f9a4f4e9a4c666fe30a@syzkaller.appspotmail.com
First crash: 2d07h, last: 4h26m
✨ AI-generated root cause summary:

A data race occurs between directory modification in tmpfs (e.g., shmem_mknod()) and lockless attribute inspection (generic_fillattr()). While stat/statx calls vfs_getattr_nosec() -> generic_fillattr() -> i_size_read() without holding inode->i_rwsem, shmem_mknod() directly performs a plain read-modify-write on the parent directory inode's size (dir->i_size += BOGO_DIRENT_SIZE) instead of using the concurrency-safe i_size_write() helper. As a result, the unmarked store races with the marked smp_load_acquire() in i_size_read(), triggering a KCSAN data race report.

▶ ▼ ✨ Full AI root cause analysis
Based on kernel commit 20eef29b7c84:

Technical Mechanism and Root Cause Analysis

1. Context and Involved Components

  • Source Files:
    • mm/shmem.c: shmem_mknod(), shmem_create(), shmem_link(), shmem_unlink(), shmem_rename2(), shmem_symlink()
    • fs/stat.c: generic_fillattr(), shmem_getattr()
    • include/linux/fs.h: i_size_read(), i_size_write()
  • Structures and Fields:
    • struct inode: dir->i_size (offset 0x50, 8 bytes)

2. Root Cause Mechanism

In the Linux VFS layer, querying file or directory attributes via stat() / newfstatat() / statx() invokes vfs_getattr_nosec() and subsequent filesystem-specific getattr operations (in tmpfs, shmem_getattr()). To preserve high concurrency and avoid deadlocks, attribute inspection does not acquire inode->i_rwsem. Instead, generic_fillattr() relies on i_size_read(inode) to inspect inode->i_size concurrently with writers:

/* include/linux/fs.h */
static inline loff_t i_size_read(const struct inode *inode)
{
#if BITS_PER_LONG==32 && defined(CONFIG_SMP)
    ...
#else
    /* Pairs with smp_store_release() in i_size_write() */
    return smp_load_acquire(&inode->i_size);
#endif
}

To support lockless i_size_read() calls safely across architectures and prevent data races and tearing, any filesystem code updating inode->i_size must use i_size_write(inode, new_size). On 64-bit architectures, i_size_write() emits an smp_store_release(&inode->i_size, i_size) to pair with smp_load_acquire(), while on 32-bit SMP architectures it manages inode->i_size_seqcount to prevent readers from observing torn 64-bit values.

In mm/shmem.c, tmpfs maintains a fake directory size heuristic using BOGO_DIRENT_SIZE (20 bytes per directory entry) so that directory sizes reported by stat() reflect entry counts. However, shmem_mknod() and other tmpfs directory modification routines modify the parent directory's size via direct arithmetic operations without calling i_size_write():

/* mm/shmem.c:4092 in shmem_mknod() */
dir->i_size += BOGO_DIRENT_SIZE;

(Similar unsynchronized modifications exist in shmem_link(), shmem_unlink(), shmem_rename2(), and shmem_symlink().)

3. Bug Trigger and Failure Condition

When task 8131 (udevd) creates a file or node in a tmpfs directory via openat(..., O_CREAT) -> lookup_open() -> shmem_create() -> shmem_mknod(), it performs a plain read-modify-write on dir->i_size without release semantics or seqcount tracking. Simultaneously, task 4073 issues newfstatat() on the same directory, calling generic_fillattr() -> i_size_read(inode) which executes a marked smp_load_acquire(&inode->i_size).

Under the Linux Kernel Concurrency Sanitizer (KCSAN), concurrent access between a plain/unmarked write and an atomic/marked read constitutes an unsynchronized data race and triggers this KCSAN report. The appropriate fix is updating dir->i_size using i_size_write(dir, dir->i_size + BOGO_DIRENT_SIZE) (or - BOGO_DIRENT_SIZE).

▶ ▼ ✨ AI Jobs (2)
ID Workflow Result Correct Bug Created Started Finished Revision
8e069d6c assessment-security DenialOfService: ❌ Exploitable: ❌ FilesystemTrigger: ❌ FuzzingArtifact: ❌ MemoryCorruption: ❌ NetworkNeedsSetup: ❌ NetworkTrigger: ❌ PeripheralTrigger: ❌ RemoteTrigger: ❌ Unprivileged: ✅ UserNamespace: ✅ VMGuestTrigger: ❌ VMHostTrigger: ❌ ❓ KCSAN: data-race in generic_fillattr / shmem_mknod (3) 2026/11/19 11:49 2026/11/19 11:49 2026/11/19 11:54 2006bdcc
17a50501 assessment-kcsan Benign: ✅ ❓ KCSAN: data-race in generic_fillattr / shmem_mknod (3) 2026/11/19 11:47 2026/11/19 11:47 2026/11/19 12:03 2006bdcc
▶ ▼ Similar bugs (2)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KCSAN: data-race in generic_fillattr / shmem_mknod mm 6 86 2347d 2459d 0/29 auto-closed as invalid on 2020/07/21 10:58
upstream KCSAN: data-race in generic_fillattr / shmem_mknod (2) mm 6 syz 760 731d 1305d 0/29 auto-obsoleted due to no activity on 2025/08/31 02:09

Sample crash report:
==================================================================
BUG: KCSAN: data-race in generic_fillattr / shmem_mknod

read (marked) to 0xffff888103e4b9e8 of 8 bytes by task 4356 on cpu 0:
 i_size_read include/linux/fs.h:1146 [inline]
 generic_fillattr+0x14a/0x340 fs/stat.c:95
 shmem_getattr+0x18b/0x210 mm/shmem.c:1539
 vfs_getattr_nosec+0x194/0x230 fs/stat.c:217
 vfs_getattr+0x48/0x60 fs/stat.c:266
 vfs_statx_path+0x28/0x140 fs/stat.c:303
 vfs_statx+0xc4/0x170 fs/stat.c:360
 vfs_fstatat+0x118/0x170 fs/stat.c:377
 __do_sys_newfstatat fs/stat.c:542 [inline]
 __se_sys_newfstatat+0x55/0x3e0 fs/stat.c:536
 __x64_sys_newfstatat+0x55/0x70 fs/stat.c:536
 x64_sys_call+0xee6/0x2550 arch/x86/include/generated/asm/syscalls_64.h:263
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

read-write to 0xffff888103e4b9e8 of 8 bytes by task 4361 on cpu 1:
 shmem_mknod+0x11b/0x170 mm/shmem.c:4104
 shmem_create+0x34/0x50 mm/shmem.c:4160
 lookup_open+0x84e/0x10a0 fs/namei.c:4575
 open_last_lookups fs/namei.c:4774 [inline]
 path_openat+0x492/0x11e0 fs/namei.c:5013
 do_file_open+0x16c/0x290 fs/namei.c:5045
 do_sys_openat2+0xa1/0x140 fs/open.c:1443
 do_sys_open fs/open.c:1449 [inline]
 __do_sys_openat fs/open.c:1465 [inline]
 __se_sys_openat fs/open.c:1460 [inline]
 __x64_sys_openat+0xf2/0x120 fs/open.c:1460
 x64_sys_call+0x1f72/0x2550 arch/x86/include/generated/asm/syscalls_64.h:258
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 UID: 0 PID: 4361 Comm: udevd Not tainted syzkaller #0 PREEMPT(lazy) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
==================================================================

Crashes (4):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/11/19 20:25 upstream 8dac6df92a2e 229865fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_fillattr / shmem_mknod
2026/11/18 06:59 upstream 20eef29b7c84 eb4895d7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_fillattr / shmem_mknod
2026/11/17 21:27 upstream 63fdb511c27a 122f94d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_fillattr / shmem_mknod
2026/11/17 17:05 upstream 666539eecdf4 122f94d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in generic_fillattr / shmem_mknod
* Struck through repros no longer work on HEAD.