syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Tainted: G             L     
------------------------------------------------------
syz.1.1646/12163 is trying to acquire lock:
ffff8880491889a0 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
ffff8880491889a0 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2728

but task is already holding lock:
ffff8880490917a0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
ffff8880490917a0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4b50 fs/ocfs2/suballoc.c:882

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1625
       inode_lock include/linux/fs.h:1029 [inline]
       ocfs2_reserve_suballoc_bits+0x11c/0x4b50 fs/ocfs2/suballoc.c:882
       ocfs2_reserve_new_metadata_blocks+0x506/0xbe0 fs/ocfs2/suballoc.c:1078
       ocfs2_mknod+0xead/0x27b0 fs/ocfs2/namei.c:351
       ocfs2_mkdir+0xf2/0x450 fs/ocfs2/namei.c:660
       vfs_mkdir+0x361/0x850 fs/namei.c:5271
       filename_mkdirat+0x48b/0x5e0 fs/namei.c:5304
       __do_sys_mkdirat fs/namei.c:5325 [inline]
       __se_sys_mkdirat fs/namei.c:5322 [inline]
       __x64_sys_mkdirat+0x89/0xc0 fs/namei.c:5322
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x115/0x870 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1625
       inode_lock include/linux/fs.h:1029 [inline]
       ocfs2_remove_inode+0x15b/0x860 fs/ocfs2/inode.c:733
       ocfs2_wipe_inode+0x6dd/0x1250 fs/ocfs2/inode.c:896
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x7f9/0x1550 fs/ocfs2/inode.c:1299
       evict+0x3c2/0xad0 fs/inode.c:841
       iput_final fs/inode.c:1960 [inline]
       iput.part.0+0x605/0xf50 fs/inode.c:2009
       iput+0x35/0x40 fs/inode.c:1975
       d_delete_notify include/linux/fsnotify.h:377 [inline]
       vfs_rmdir fs/namei.c:5389 [inline]
       vfs_rmdir+0x5c8/0x8a0 fs/namei.c:5349
       filename_rmdir+0x31a/0x5c0 fs/namei.c:5431
       __do_sys_rmdir fs/namei.c:5454 [inline]
       __se_sys_rmdir fs/namei.c:5451 [inline]
       __x64_sys_rmdir+0x46/0x70 fs/namei.c:5451
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x115/0x870 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237
       lock_acquire kernel/locking/lockdep.c:5868 [inline]
       lock_acquire+0x1b1/0x370 kernel/locking/lockdep.c:5825
       down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1625
       inode_lock include/linux/fs.h:1029 [inline]
       ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2728
       ocfs2_dio_end_io_write+0x711/0x1130 fs/ocfs2/aops.c:2379
       ocfs2_dio_end_io+0x136/0x2c0 fs/ocfs2/aops.c:2418
       dio_complete+0x224/0x950 fs/direct-io.c:281
       __blockdev_direct_IO+0x2a2d/0x33d0 fs/direct-io.c:1303
       ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2455
       generic_file_direct_write+0x198/0x410 mm/filemap.c:4259
       __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4428
       ocfs2_file_write_iter+0xdbb/0x2240 fs/ocfs2/file.c:2476
       iter_file_splice_write+0x830/0x10a0 fs/splice.c:736
       do_splice_from fs/splice.c:936 [inline]
       direct_splice_actor+0x192/0x6c0 fs/splice.c:1159
       splice_direct_to_actor+0x345/0xa30 fs/splice.c:1103
       do_splice_direct_actor fs/splice.c:1202 [inline]
       do_splice_direct+0x174/0x240 fs/splice.c:1228
       do_sendfile+0xadc/0xe20 fs/read_write.c:1372
       __do_sys_sendfile64 fs/read_write.c:1433 [inline]
       __se_sys_sendfile64 fs/read_write.c:1419 [inline]
       __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1419
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x115/0x870 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE] --> &ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE] --> &ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]);
  lock(&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]);

 *** DEADLOCK ***

3 locks held by syz.1.1646/12163:
 #0: ffff8880295b4410 (sb_writers#26){.+.+}-{0:0}, at: splice_direct_to_actor+0x345/0xa30 fs/splice.c:1103
 #1: ffff8880491acfa0 (&sb->s_type->i_mutex_key#36){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
 #1: ffff8880491acfa0 (&sb->s_type->i_mutex_key#36){+.+.}-{4:4}, at: ocfs2_file_write_iter+0x1f5e/0x2240 fs/ocfs2/file.c:2406
 #2: ffff8880490917a0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
 #2: ffff8880490917a0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4b50 fs/ocfs2/suballoc.c:882

stack backtrace:
CPU: 0 UID: 0 PID: 12163 Comm: syz.1.1646 Tainted: G             L      syzkaller #0 PREEMPT(full) 
Tainted: [L]=SOFTLOCKUP
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x100/0x190 lib/dump_stack.c:120
 print_circular_bug.cold+0x178/0x1c7 kernel/locking/lockdep.c:2043
 check_noncircular+0x146/0x160 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237
 lock_acquire kernel/locking/lockdep.c:5868 [inline]
 lock_acquire+0x1b1/0x370 kernel/locking/lockdep.c:5825
 down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1625
 inode_lock include/linux/fs.h:1029 [inline]
 ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2728
 ocfs2_dio_end_io_write+0x711/0x1130 fs/ocfs2/aops.c:2379
 ocfs2_dio_end_io+0x136/0x2c0 fs/ocfs2/aops.c:2418
 dio_complete+0x224/0x950 fs/direct-io.c:281
 __blockdev_direct_IO+0x2a2d/0x33d0 fs/direct-io.c:1303
 ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2455
 generic_file_direct_write+0x198/0x410 mm/filemap.c:4259
 __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4428
 ocfs2_file_write_iter+0xdbb/0x2240 fs/ocfs2/file.c:2476
 iter_file_splice_write+0x830/0x10a0 fs/splice.c:736
 do_splice_from fs/splice.c:936 [inline]
 direct_splice_actor+0x192/0x6c0 fs/splice.c:1159
 splice_direct_to_actor+0x345/0xa30 fs/splice.c:1103
 do_splice_direct_actor fs/splice.c:1202 [inline]
 do_splice_direct+0x174/0x240 fs/splice.c:1228
 do_sendfile+0xadc/0xe20 fs/read_write.c:1372
 __do_sys_sendfile64 fs/read_write.c:1433 [inline]
 __se_sys_sendfile64 fs/read_write.c:1419 [inline]
 __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1419
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x115/0x870 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f5ac179ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f5abf9f6028 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f5ac1a16090 RCX: 00007f5ac179ce59
RDX: 0000000000000000 RSI: 0000000000000008 RDI: 0000000000000004
RBP: 00007f5ac1832d6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000fffe82 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f5ac1a16128 R14: 00007f5ac1a16090 R15: 00007ffc38b52788
 </TASK>