syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.5.499/5806 is trying to acquire lock:
ffff88807071c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff88807071c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x12b/0x7a0 fs/ocfs2/namei.c:2713

but task is already holding lock:
ffff8880706f0660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2325 [inline]
ffff8880706f0660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x434/0x1200 fs/ocfs2/aops.c:2431

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_create_local_dquot+0x1a5/0x18e0 fs/ocfs2/quota_local.c:1224
       ocfs2_acquire_dquot+0x7c6/0xb20 fs/ocfs2/quota_global.c:871
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8c8/0x25b0 fs/ocfs2/namei.c:310
       ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x1181/0x2ee0 fs/namei.c:3788
       do_filp_open+0x1f1/0x430 fs/namei.c:3818
       do_sys_openat2+0x150/0x4b0 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_openat fs/open.c:1352 [inline]
       __se_sys_openat fs/open.c:1347 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1347
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12d/0xaf0 kernel/locking/mutex.c:747
       wait_on_dquot fs/quota/dquot.c:356 [inline]
       dqget+0x6f8/0xeb0 fs/quota/dquot.c:983
       __dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8c8/0x25b0 fs/ocfs2/namei.c:310
       ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x1181/0x2ee0 fs/namei.c:3788
       do_filp_open+0x1f1/0x430 fs/namei.c:3818
       do_sys_openat2+0x150/0x4b0 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_openat fs/open.c:1352 [inline]
       __se_sys_openat fs/open.c:1347 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1347
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x163f/0x4630 fs/ocfs2/inode.c:1219
       evict+0x4c9/0x8d0 fs/inode.c:705
       ocfs2_dentry_iput+0x24a/0x390 fs/ocfs2/dcache.c:418
       __dentry_kill+0x431/0x650 fs/dcache.c:611
       dentry_kill+0xb8/0x290 fs/dcache.c:-1
       dput+0xfa/0x1d0 fs/dcache.c:918
       ovl_check_rename_whiteout fs/overlayfs/super.c:1325 [inline]
       ovl_make_workdir fs/overlayfs/super.c:1424 [inline]
       ovl_get_workdir+0xb5f/0x1610 fs/overlayfs/super.c:1539
       ovl_fill_super+0x1824/0x2a30 fs/overlayfs/super.c:2095
       mount_nodev+0x52/0xe0 fs/super.c:1489
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
       lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_del_inode_from_orphan+0x12b/0x7a0 fs/ocfs2/namei.c:2713
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
       ocfs2_dio_end_io+0x540/0x1200 fs/ocfs2/aops.c:2431
       dio_complete+0x251/0x710 fs/direct-io.c:271
       __blockdev_direct_IO+0x2f25/0x3570 fs/direct-io.c:1320
       ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x10f/0x330 mm/filemap.c:3787
       __generic_file_write_iter+0x15f/0x2a0 mm/filemap.c:3945
       ocfs2_file_write_iter+0x1660/0x1f00 fs/ocfs2/file.c:2469
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x642/0xb10 fs/read_write.c:861
       iter_file_splice_write+0x699/0xcc0 fs/splice.c:685
       do_splice_from fs/splice.c:763 [inline]
       direct_splice_actor+0xe1/0x130 fs/splice.c:950
       splice_direct_to_actor+0x48b/0xb90 fs/splice.c:896
       do_splice_direct+0x1ce/0x2f0 fs/splice.c:1002
       do_sendfile+0x5f3/0xea0 fs/read_write.c:1255
       __do_sys_sendfile64 fs/read_write.c:1323 [inline]
       __se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1309
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &dquot->dq_lock --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);

 *** DEADLOCK ***

3 locks held by syz.5.499/5806:
 #0: ffff888055906460 (sb_writers#20){.+.+}-{0:0}, at: do_sendfile+0x5d0/0xea0 fs/read_write.c:1254
 #1: ffff8880706f09c8 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff8880706f09c8 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x448/0x1f00 fs/ocfs2/file.c:2399
 #2: ffff8880706f0660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2325 [inline]
 #2: ffff8880706f0660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io+0x434/0x1200 fs/ocfs2/aops.c:2431

stack backtrace:
CPU: 0 PID: 5806 Comm: syz.5.499 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x24e lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
 lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 ocfs2_del_inode_from_orphan+0x12b/0x7a0 fs/ocfs2/namei.c:2713
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
 ocfs2_dio_end_io+0x540/0x1200 fs/ocfs2/aops.c:2431
 dio_complete+0x251/0x710 fs/direct-io.c:271
 __blockdev_direct_IO+0x2f25/0x3570 fs/direct-io.c:1320
 ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2468
 generic_file_direct_write+0x10f/0x330 mm/filemap.c:3787
 __generic_file_write_iter+0x15f/0x2a0 mm/filemap.c:3945
 ocfs2_file_write_iter+0x1660/0x1f00 fs/ocfs2/file.c:2469
 do_iter_readv_writev fs/read_write.c:-1 [inline]
 do_iter_write+0x642/0xb10 fs/read_write.c:861
 iter_file_splice_write+0x699/0xcc0 fs/splice.c:685
 do_splice_from fs/splice.c:763 [inline]
 direct_splice_actor+0xe1/0x130 fs/splice.c:950
 splice_direct_to_actor+0x48b/0xb90 fs/splice.c:896
 do_splice_direct+0x1ce/0x2f0 fs/splice.c:1002
 do_sendfile+0x5f3/0xea0 fs/read_write.c:1255
 __do_sys_sendfile64 fs/read_write.c:1323 [inline]
 __se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1309
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f3a6b79c799
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3a6c65d028 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f3a6ba15fa0 RCX: 00007f3a6b79c799
RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000004
RBP: 00007f3a6b832bd9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000020fffe82 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f3a6ba16038 R14: 00007f3a6ba15fa0 R15: 00007ffe6bfc5958
 </TASK>
ocfs2: Unmounting device (7,5) on (node local)