syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.3.163/4978 is trying to acquire lock:
ffff888058f28990 (jbd2_handle){++++}-{0:0}, at: wait_transaction_locked+0x1a6/0x270 fs/jbd2/transaction.c:177

but task is already holding lock:
ffff888026fd40e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe0/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13c8/0x1750 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x1c5/0x490 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x43b5/0x5090 fs/ocfs2/super.c:1139
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (sb_internal#3){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2a5/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_acquire_dquot+0x681/0xb20 fs/ocfs2/quota_global.c:848
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8c8/0x25b0 fs/ocfs2/namei.c:310
       ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x1181/0x2ee0 fs/namei.c:3788
       do_filp_open+0x1f1/0x430 fs/namei.c:3818
       do_sys_openat2+0x150/0x4b0 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_openat fs/open.c:1352 [inline]
       __se_sys_openat fs/open.c:1347 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1347
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_create_local_dquot+0x1a5/0x18e0 fs/ocfs2/quota_local.c:1224
       ocfs2_acquire_dquot+0x7c6/0xb20 fs/ocfs2/quota_global.c:871
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8c8/0x25b0 fs/ocfs2/namei.c:310
       ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x1181/0x2ee0 fs/namei.c:3788
       do_filp_open+0x1f1/0x430 fs/namei.c:3818
       do_sys_openat2+0x150/0x4b0 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_openat fs/open.c:1352 [inline]
       __se_sys_openat fs/open.c:1347 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1347
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12d/0xaf0 kernel/locking/mutex.c:747
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6811
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_alloc_space+0x5fc/0xe60 fs/quota/dquot.c:1752
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0xf8d/0x4760 fs/ext4/mballoc.c:5738
       ext4_ext_map_blocks+0x195b/0x6810 fs/ext4/extents.c:4340
       ext4_map_blocks+0x9de/0x1b70 fs/ext4/inode.c:679
       _ext4_get_block+0x1e7/0x540 fs/ext4/inode.c:822
       ext4_block_write_begin+0x644/0x1300 fs/ext4/inode.c:1124
       ext4_write_begin+0x629/0xf80 fs/ext4/ext4_jbd2.h:-1
       ext4_da_write_begin+0x30a/0x960 fs/ext4/inode.c:3000
       generic_perform_write+0x2fa/0x5c0 mm/filemap.c:3862
       ext4_buffered_write_iter+0x11a/0x390 fs/ext4/file.c:285
       ext4_file_write_iter+0x1cf/0x1710 fs/ext4/file.c:-1
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x4b1/0xa30 fs/read_write.c:584
       ksys_write+0x14c/0x250 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_truncate+0x999/0x1240 fs/ext4/inode.c:4290
       ext4_setattr+0x10cb/0x19f0 fs/ext4/inode.c:5649
       notify_change+0xc74/0xf40 fs/attr.c:499
       do_truncate+0x1ac/0x240 fs/open.c:65
       do_sys_ftruncate+0x312/0x3c0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (jbd2_handle){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
       lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
       wait_transaction_locked+0x1bf/0x270 fs/jbd2/transaction.c:177
       add_transaction_credits fs/jbd2/transaction.c:241 [inline]
       start_this_handle+0x7ec/0x2230 fs/jbd2/transaction.c:422
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3b0/0x6f0 fs/ocfs2/journal.c:376
       ocfs2_write_begin_nolock+0x2977/0x44f0 fs/ocfs2/aops.c:1770
       ocfs2_write_begin+0x1c2/0x320 fs/ocfs2/aops.c:1904
       generic_perform_write+0x2fa/0x5c0 mm/filemap.c:3862
       __generic_file_write_iter+0x148/0x2a0 mm/filemap.c:3960
       ocfs2_file_write_iter+0x1660/0x1f00 fs/ocfs2/file.c:2469
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x4b1/0xa30 fs/read_write.c:584
       ksys_write+0x14c/0x250 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  jbd2_handle --> sb_internal#3 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&journal->j_trans_barrier);
                               lock(sb_internal#3);
                               lock(&journal->j_trans_barrier);
  lock(jbd2_handle);

 *** DEADLOCK ***

7 locks held by syz.3.163/4978:
 #0: ffff888023dd45e8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2ae/0x360 fs/file.c:1038
 #1: ffff888078462460 (sb_writers#22){.+.+}-{0:0}, at: vfs_write+0x26b/0xa30 fs/read_write.c:580
 #2: ffff888057201808 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff888057201808 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x448/0x1f00 fs/ocfs2/file.c:2399
 #3: ffff8880572014a0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x19f/0x320 fs/ocfs2/aops.c:1902
 #4: ffff8880573d42c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #4: ffff8880573d42c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x11e/0x2700 fs/ocfs2/localalloc.c:635
 #5: ffff888078462650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x2977/0x44f0 fs/ocfs2/aops.c:1770
 #6: ffff888026fd40e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374

stack backtrace:
CPU: 1 PID: 4978 Comm: syz.3.163 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x24e lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
 lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
 wait_transaction_locked+0x1bf/0x270 fs/jbd2/transaction.c:177
 add_transaction_credits fs/jbd2/transaction.c:241 [inline]
 start_this_handle+0x7ec/0x2230 fs/jbd2/transaction.c:422
 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
 ocfs2_start_trans+0x3b0/0x6f0 fs/ocfs2/journal.c:376
 ocfs2_write_begin_nolock+0x2977/0x44f0 fs/ocfs2/aops.c:1770
 ocfs2_write_begin+0x1c2/0x320 fs/ocfs2/aops.c:1904
 generic_perform_write+0x2fa/0x5c0 mm/filemap.c:3862
 __generic_file_write_iter+0x148/0x2a0 mm/filemap.c:3960
 ocfs2_file_write_iter+0x1660/0x1f00 fs/ocfs2/file.c:2469
 call_write_iter include/linux/fs.h:2265 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x4b1/0xa30 fs/read_write.c:584
 ksys_write+0x14c/0x250 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f1f9c99aeb9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1f9d8a2028 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f1f9cc15fa0 RCX: 00007f1f9c99aeb9
RDX: 000000000208e24b RSI: 0000200000000040 RDI: 0000000000000005
RBP: 00007f1f9ca08c1f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f1f9cc16038 R14: 00007f1f9cc15fa0 R15: 00007ffebc786ee8
 </TASK>