syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.3.2582/10912 is trying to acquire lock:
ffff888076824990 (jbd2_handle){++++}-{0:0}, at: wait_transaction_locked+0x19f/0x270 fs/jbd2/transaction.c:178

but task is already holding lock:
ffff88805f7158e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374
       ocfs2_shutdown_local_alloc+0x1f8/0xaa0 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1e1/0x8a0 fs/ocfs2/super.c:1885
       generic_shutdown_super+0x130/0x300 fs/super.c:475
       kill_block_super+0x7c/0xe0 fs/super.c:1427
       deactivate_locked_super+0x93/0xf0 fs/super.c:335
       cleanup_mnt+0x42d/0x4e0 fs/namespace.c:1148
       task_work_run+0x125/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307
       do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #4 (sb_internal#5){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2a7/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_acquire_dquot+0x688/0xb10 fs/ocfs2/quota_global.c:848
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2826
       quota_setquota+0x4d6/0x590 fs/quota/quota.c:309
       __do_sys_quotactl fs/quota/quota.c:959 [inline]
       __se_sys_quotactl+0x28b/0x6f0 fs/quota/quota.c:915
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ocfs2_create_local_dquot+0x199/0x1850 fs/ocfs2/quota_local.c:1224
       ocfs2_acquire_dquot+0x7ed/0xb10 fs/ocfs2/quota_global.c:871
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2826
       quota_setquota+0x4d6/0x590 fs/quota/quota.c:309
       __do_sys_quotactl fs/quota/quota.c:959 [inline]
       __se_sys_quotactl+0x28b/0x6f0 fs/quota/quota.c:915
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x1e3/0x2400 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6210
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_alloc_space+0x5d0/0xe20 fs/quota/dquot.c:1752
       dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline]
       dquot_alloc_space include/linux/quotaops.h:310 [inline]
       dquot_alloc_block include/linux/quotaops.h:334 [inline]
       ext4_mb_new_blocks+0xf81/0x4980 fs/ext4/mballoc.c:5748
       ext4_ext_map_blocks+0x191c/0x6580 fs/ext4/extents.c:4347
       ext4_map_blocks+0x98e/0x1b30 fs/ext4/inode.c:673
       _ext4_get_block+0x1e7/0x540 fs/ext4/inode.c:816
       ext4_block_write_begin+0x61b/0x1220 fs/ext4/inode.c:1101
       ext4_write_begin+0x6c8/0x15d0 fs/ext4/ext4_jbd2.h:-1
       ext4_da_write_begin+0x43b/0xb40 fs/ext4/inode.c:2975
       __page_symlink+0x102/0x200 fs/namei.c:5199
       ext4_symlink+0x8bd/0xca0 fs/ext4/namei.c:3467
       vfs_symlink+0x247/0x3d0 fs/namei.c:4437
       do_symlinkat+0x1ab/0x6b0 fs/namei.c:4466
       __do_sys_symlink fs/namei.c:4488 [inline]
       __se_sys_symlink fs/namei.c:4486 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4486
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ext4_truncate+0x97f/0x10f0 fs/ext4/inode.c:4251
       ext4_setattr+0xffe/0x19e0 fs/ext4/inode.c:5601
       notify_change+0xbcd/0xee0 fs/attr.c:505
       do_truncate+0x1ac/0x240 fs/open.c:65
       do_sys_ftruncate+0x31b/0x3d0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (jbd2_handle){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       wait_transaction_locked+0x1bb/0x270 fs/jbd2/transaction.c:178
       add_transaction_credits+0x103/0xc80 fs/jbd2/transaction.c:242
       start_this_handle+0x74d/0x15c0 fs/jbd2/transaction.c:423
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x3b2/0x6f0 fs/ocfs2/journal.c:376
       ocfs2_remove_inode fs/ocfs2/inode.c:664 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1e53/0x41d0 fs/ocfs2/inode.c:1216
       evict+0x4c9/0x8d0 fs/inode.c:647
       do_unlinkat+0x3e7/0x710 fs/namei.c:4363
       __do_sys_unlinkat fs/namei.c:4399 [inline]
       __se_sys_unlinkat fs/namei.c:4392 [inline]
       __x64_sys_unlinkat+0xd1/0xe0 fs/namei.c:4392
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  jbd2_handle --> sb_internal#5 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&journal->j_trans_barrier);
                               lock(sb_internal#5);
                               lock(&journal->j_trans_barrier);
  lock(jbd2_handle);

 *** DEADLOCK ***

6 locks held by syz.3.2582/10912:
 #0: ffff888148e06460 (sb_writers#30){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386
 #1: ffff888053840ab0 (&osb->nfs_sync_rwlock){.+.+}-{3:3}, at: ocfs2_nfs_sync_lock+0x103/0x270 fs/ocfs2/dlmglue.c:2874
 #2: ffff88805d42df48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88805d42df48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:776 [inline]
 #2: ffff88805d42df48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
 #2: ffff88805d42df48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_evict_inode+0x2d12/0x41d0 fs/ocfs2/inode.c:1216
 #3: ffff88805fca6d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #3: ffff88805fca6d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
 #3: ffff88805fca6d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
 #3: ffff88805fca6d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
 #3: ffff88805fca6d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_evict_inode+0x1d72/0x41d0 fs/ocfs2/inode.c:1216
 #4: ffff888148e06650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_remove_inode fs/ocfs2/inode.c:664 [inline]
 #4: ffff888148e06650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
 #4: ffff888148e06650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
 #4: ffff888148e06650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_evict_inode+0x1e53/0x41d0 fs/ocfs2/inode.c:1216
 #5: ffff88805f7158e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374

stack backtrace:
CPU: 0 PID: 10912 Comm: syz.3.2582 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 wait_transaction_locked+0x1bb/0x270 fs/jbd2/transaction.c:178
 add_transaction_credits+0x103/0xc80 fs/jbd2/transaction.c:242
 start_this_handle+0x74d/0x15c0 fs/jbd2/transaction.c:423
 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
 ocfs2_start_trans+0x3b2/0x6f0 fs/ocfs2/journal.c:376
 ocfs2_remove_inode fs/ocfs2/inode.c:664 [inline]
 ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
 ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
 ocfs2_evict_inode+0x1e53/0x41d0 fs/ocfs2/inode.c:1216
 evict+0x4c9/0x8d0 fs/inode.c:647
 do_unlinkat+0x3e7/0x710 fs/namei.c:4363
 __do_sys_unlinkat fs/namei.c:4399 [inline]
 __se_sys_unlinkat fs/namei.c:4392 [inline]
 __x64_sys_unlinkat+0xd1/0xe0 fs/namei.c:4392
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f17886bf799
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1786919028 EFLAGS: 00000246 ORIG_RAX: 0000000000000107
RAX: ffffffffffffffda RBX: 00007f1788938fa0 RCX: 00007f17886bf799
RDX: 0000000000000000 RSI: 0000200000000000 RDI: ffffffffffffff9c
RBP: 00007f1788755c99 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f1788939038 R14: 00007f1788938fa0 R15: 00007ffe024ecd48
 </TASK>