syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.158/5155 is trying to acquire lock:
ffff88807a86a990 (jbd2_handle){++++}-{0:0}, at: wait_transaction_locked+0x19f/0x270 fs/jbd2/transaction.c:178

but task is already holding lock:
ffff888060bc80e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe0/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1499/0x1820 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x72f/0xa80 fs/quota/dquot.c:2485
       dquot_load_quota_inode+0x2d3/0x5c0 fs/quota/dquot.c:2522
       ocfs2_enable_quotas+0x1c0/0x4a0 fs/ocfs2/super.c:927
       ocfs2_fill_super+0x3c9f/0x50c0 fs/ocfs2/super.c:1140
       mount_bdev+0x28a/0x3c0 fs/super.c:1400
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x247/0xa40 fs/namespace.c:3034
       do_mount fs/namespace.c:3377 [inline]
       __do_sys_mount fs/namespace.c:3585 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #4 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2a7/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_acquire_dquot+0x6c0/0xb30 fs/ocfs2/quota_global.c:848
       dqget+0x713/0xbb0 fs/quota/dquot.c:1010
       dquot_set_dqblk+0x27/0xfb0 fs/quota/dquot.c:2848
       quota_setquota+0x4d6/0x590 fs/quota/quota.c:309
       __do_sys_quotactl fs/quota/quota.c:959 [inline]
       __se_sys_quotactl+0x28b/0x6f0 fs/quota/quota.c:915
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ocfs2_create_local_dquot+0x199/0x18d0 fs/ocfs2/quota_local.c:1224
       ocfs2_acquire_dquot+0x822/0xb30 fs/ocfs2/quota_global.c:871
       dqget+0x713/0xbb0 fs/quota/dquot.c:1010
       dquot_set_dqblk+0x27/0xfb0 fs/quota/dquot.c:2848
       quota_setquota+0x4d6/0x590 fs/quota/quota.c:309
       __do_sys_quotactl fs/quota/quota.c:959 [inline]
       __se_sys_quotactl+0x28b/0x6f0 fs/quota/quota.c:915
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x1e5/0x2400 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:532
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6212
       mark_dquot_dirty fs/quota/dquot.c:397 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:437
       __dquot_free_space+0x7c3/0xb80 fs/quota/dquot.c:1964
       dquot_free_space_nodirty include/linux/quotaops.h:369 [inline]
       dquot_free_space include/linux/quotaops.h:374 [inline]
       dquot_free_block include/linux/quotaops.h:385 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6164 [inline]
       ext4_free_blocks+0x1b1b/0x24c0 fs/ext4/mballoc.c:6294
       ext4_remove_blocks fs/ext4/extents.c:2522 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2706 [inline]
       ext4_ext_remove_space+0x22bd/0x41a0 fs/ext4/extents.c:2954
       ext4_ext_truncate+0x182/0x230 fs/ext4/extents.c:4504
       ext4_truncate+0xa41/0x1190 fs/ext4/inode.c:4263
       ext4_evict_inode+0xb0f/0x1050 fs/ext4/inode.c:291
       evict+0x4b6/0x8b0 fs/inode.c:647
       d_delete_notify include/linux/fsnotify.h:267 [inline]
       vfs_rmdir+0x392/0x410 fs/namei.c:4170
       do_rmdir+0x27f/0x710 fs/namei.c:4218
       __do_sys_unlinkat fs/namei.c:4398 [inline]
       __se_sys_unlinkat fs/namei.c:4392 [inline]
       __x64_sys_unlinkat+0xc0/0xe0 fs/namei.c:4392
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&ei->i_data_sem){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ext4_map_blocks+0x350/0x1a50 fs/ext4/inode.c:600
       ext4_append+0x22d/0x560 fs/ext4/namei.c:75
       ext4_init_new_dir+0x2a7/0x910 fs/ext4/namei.c:3030
       ext4_mkdir+0x4c3/0xc90 fs/ext4/namei.c:3076
       vfs_mkdir+0x386/0x570 fs/namei.c:4073
       do_mkdirat+0x1dd/0x5c0 fs/namei.c:4098
       __do_sys_mkdir fs/namei.c:4118 [inline]
       __se_sys_mkdir fs/namei.c:4116 [inline]
       __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4116
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (jbd2_handle){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       wait_transaction_locked+0x1bb/0x270 fs/jbd2/transaction.c:178
       add_transaction_credits+0x104/0xcb0 fs/jbd2/transaction.c:242
       start_this_handle+0x723/0x1560 fs/jbd2/transaction.c:423
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x3b2/0x6f0 fs/ocfs2/journal.c:376
       ocfs2_del_inode_from_orphan+0x169/0x7b0 fs/ocfs2/namei.c:2722
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
       ocfs2_dio_end_io+0x1074/0x13f0 fs/ocfs2/aops.c:2446
       dio_complete+0x255/0x700 fs/direct-io.c:272
       do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
       __blockdev_direct_IO+0x2eb0/0x3b20 fs/direct-io.c:1368
       ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2483
       generic_file_direct_write+0x222/0x470 mm/filemap.c:3687
       __generic_file_write_iter+0x2b2/0x4e0 mm/filemap.c:3869
       ocfs2_file_write_iter+0x171a/0x1ee0 fs/ocfs2/file.c:2472
       do_iter_readv_writev+0x47d/0x5f0 fs/read_write.c:-1
       do_iter_write+0x1f8/0x7a0 fs/read_write.c:855
       iter_file_splice_write+0x6be/0xcf0 fs/splice.c:689
       do_splice_from fs/splice.c:767 [inline]
       direct_splice_actor+0xe1/0x130 fs/splice.c:956
       splice_direct_to_actor+0x4e8/0xc00 fs/splice.c:902
       do_splice_direct+0x1d4/0x2f0 fs/splice.c:1008
       do_sendfile+0x524/0xe30 fs/read_write.c:1249
       __do_sys_sendfile64 fs/read_write.c:1317 [inline]
       __se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1303
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  jbd2_handle --> sb_internal#2 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&journal->j_trans_barrier);
                               lock(sb_internal#2);
                               lock(&journal->j_trans_barrier);
  lock(jbd2_handle);

 *** DEADLOCK ***

5 locks held by syz.6.158/5155:
 #0: ffff88805764c460 (sb_writers#17){.+.+}-{0:0}, at: do_sendfile+0x4ff/0xe30 fs/read_write.c:1248
 #1: ffff8880628e09c8 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff8880628e09c8 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x437/0x1ee0 fs/ocfs2/file.c:2402
 #2: ffff888062b4a648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff888062b4a648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x12b/0x7b0 fs/ocfs2/namei.c:2713
 #3: ffff88805764c650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_del_inode_from_orphan+0x169/0x7b0 fs/ocfs2/namei.c:2722
 #4: ffff888060bc80e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374

stack backtrace:
CPU: 0 PID: 5155 Comm: syz.6.158 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 wait_transaction_locked+0x1bb/0x270 fs/jbd2/transaction.c:178
 add_transaction_credits+0x104/0xcb0 fs/jbd2/transaction.c:242
 start_this_handle+0x723/0x1560 fs/jbd2/transaction.c:423
 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
 ocfs2_start_trans+0x3b2/0x6f0 fs/ocfs2/journal.c:376
 ocfs2_del_inode_from_orphan+0x169/0x7b0 fs/ocfs2/namei.c:2722
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
 ocfs2_dio_end_io+0x1074/0x13f0 fs/ocfs2/aops.c:2446
 dio_complete+0x255/0x700 fs/direct-io.c:272
 do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
 __blockdev_direct_IO+0x2eb0/0x3b20 fs/direct-io.c:1368
 ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2483
 generic_file_direct_write+0x222/0x470 mm/filemap.c:3687
 __generic_file_write_iter+0x2b2/0x4e0 mm/filemap.c:3869
 ocfs2_file_write_iter+0x171a/0x1ee0 fs/ocfs2/file.c:2472
 do_iter_readv_writev+0x47d/0x5f0 fs/read_write.c:-1
 do_iter_write+0x1f8/0x7a0 fs/read_write.c:855
 iter_file_splice_write+0x6be/0xcf0 fs/splice.c:689
 do_splice_from fs/splice.c:767 [inline]
 direct_splice_actor+0xe1/0x130 fs/splice.c:956
 splice_direct_to_actor+0x4e8/0xc00 fs/splice.c:902
 do_splice_direct+0x1d4/0x2f0 fs/splice.c:1008
 do_sendfile+0x524/0xe30 fs/read_write.c:1249
 __do_sys_sendfile64 fs/read_write.c:1317 [inline]
 __se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1303
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f1d9c875e59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1d9aaae028 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f1d9caef090 RCX: 00007f1d9c875e59
RDX: 0000000000000000 RSI: 0000000000000009 RDI: 0000000000000007
RBP: 00007f1d9c90be6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000fffe82 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f1d9caef128 R14: 00007f1d9caef090 R15: 00007ffed8343368
 </TASK>