====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Tainted: G L ------------------------------------------------------ syz.2.3997/20391 is trying to acquire lock: ffff88803d726868 (&pipe->mutex){+.+.}-{4:4}, at: pipe_lock fs/pipe.c:91 [inline] ffff88803d726868 (&pipe->mutex){+.+.}-{4:4}, at: pipe_lock+0x69/0x80 fs/pipe.c:88 but task is already holding lock: ffff88802f72e420 (sb_writers#6){.+.+}-{0:0}, at: __do_splice+0x33b/0x370 fs/splice.c:1433 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (sb_writers#6){.+.+}-{0:0}: percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs/super.h:19 [inline] sb_start_write include/linux/fs/super.h:125 [inline] mnt_want_write+0x6f/0x450 fs/namespace.c:499 ovl_set_or_remove_acl fs/overlayfs/inode.c:505 [inline] ovl_set_acl+0x43c/0xa70 fs/overlayfs/inode.c:554 set_posix_acl+0x263/0x320 fs/posix_acl.c:954 vfs_set_acl+0x468/0x900 fs/posix_acl.c:1133 do_set_acl+0x14c/0x1a0 fs/posix_acl.c:1278 do_setxattr+0xeb/0x180 fs/xattr.c:633 filename_setxattr+0x16e/0x1d0 fs/xattr.c:665 path_setxattrat+0x1ff/0x3a0 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __x64_sys_setxattr+0xc6/0x140 fs/xattr.c:743 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&ovl_i_mutex_dir_key[depth]){++++}-{4:4}: down_read+0x99/0x460 kernel/locking/rwsem.c:1537 inode_lock_shared include/linux/fs.h:1042 [inline] lookup_slow+0x42/0x70 fs/namei.c:1882 walk_component fs/namei.c:2229 [inline] lookup_last fs/namei.c:2730 [inline] path_lookupat+0x5e8/0xc40 fs/namei.c:2754 filename_lookup+0x202/0x590 fs/namei.c:2783 kern_path+0x35/0x50 fs/namei.c:2996 lookup_bdev+0xd8/0x280 block/bdev.c:1222 resume_store+0x1d6/0x460 kernel/power/hibernate.c:1306 kobj_attr_store+0x58/0x80 lib/kobject.c:840 sysfs_kf_write+0xf2/0x150 fs/sysfs/file.c:142 kernfs_fop_write_iter+0x3e0/0x5f0 fs/kernfs/file.c:352 new_sync_write fs/read_write.c:593 [inline] vfs_write+0x6ac/0x1070 fs/read_write.c:686 ksys_write+0x12a/0x250 fs/read_write.c:738 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&of->mutex){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x1a2/0x1b90 kernel/locking/mutex.c:776 kernfs_seq_start+0x4f/0x2a0 fs/kernfs/file.c:172 seq_read_iter+0x2c1/0x1270 fs/seq_file.c:225 kernfs_fop_read_iter+0x46c/0x610 fs/kernfs/file.c:297 new_sync_read fs/read_write.c:491 [inline] vfs_read+0x825/0xb30 fs/read_write.c:572 ksys_read+0x12a/0x250 fs/read_write.c:715 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&p->lock){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x1a2/0x1b90 kernel/locking/mutex.c:776 seq_read_iter+0xe1/0x1270 fs/seq_file.c:182 proc_reg_read_iter+0x220/0x310 fs/proc/inode.c:299 copy_splice_read+0x4ba/0xb90 fs/splice.c:363 do_splice_read fs/splice.c:982 [inline] do_splice_read+0x285/0x370 fs/splice.c:956 splice_file_to_pipe+0x82/0x120 fs/splice.c:1292 do_sendfile+0x366/0xe20 fs/read_write.c:1376 __do_sys_sendfile64 fs/read_write.c:1431 [inline] __se_sys_sendfile64 fs/read_write.c:1417 [inline] __x64_sys_sendfile64+0x1d8/0x220 fs/read_write.c:1417 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&pipe->mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x17c/0x330 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x1a2/0x1b90 kernel/locking/mutex.c:776 pipe_lock fs/pipe.c:91 [inline] pipe_lock+0x69/0x80 fs/pipe.c:88 iter_file_splice_write+0x1f8/0x10a0 fs/splice.c:683 do_splice_from fs/splice.c:938 [inline] do_splice+0x109c/0x1fd0 fs/splice.c:1351 __do_splice+0x33b/0x370 fs/splice.c:1433 __do_sys_splice fs/splice.c:1636 [inline] __se_sys_splice fs/splice.c:1618 [inline] __x64_sys_splice+0x187/0x250 fs/splice.c:1618 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &pipe->mutex --> &ovl_i_mutex_dir_key[depth] --> sb_writers#6 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(sb_writers#6); lock(&ovl_i_mutex_dir_key[depth]); lock(sb_writers#6); lock(&pipe->mutex); *** DEADLOCK *** 1 lock held by syz.2.3997/20391: #0: ffff88802f72e420 (sb_writers#6){.+.+}-{0:0}, at: __do_splice+0x33b/0x370 fs/splice.c:1433 stack backtrace: CPU: 3 UID: 0 PID: 20391 Comm: syz.2.3997 Tainted: G L syzkaller #0 PREEMPT(full) Tainted: [L]=SOFTLOCKUP Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x100/0x190 lib/dump_stack.c:120 print_circular_bug.cold+0x178/0x1c7 kernel/locking/lockdep.c:2043 check_noncircular+0x146/0x160 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x17c/0x330 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x1a2/0x1b90 kernel/locking/mutex.c:776 pipe_lock fs/pipe.c:91 [inline] pipe_lock+0x69/0x80 fs/pipe.c:88 iter_file_splice_write+0x1f8/0x10a0 fs/splice.c:683 do_splice_from fs/splice.c:938 [inline] do_splice+0x109c/0x1fd0 fs/splice.c:1351 __do_splice+0x33b/0x370 fs/splice.c:1433 __do_sys_splice fs/splice.c:1636 [inline] __se_sys_splice fs/splice.c:1618 [inline] __x64_sys_splice+0x187/0x250 fs/splice.c:1618 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xc9/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fdf4159aeb9 Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fdf3f7f6028 EFLAGS: 00000246 ORIG_RAX: 0000000000000113 RAX: ffffffffffffffda RBX: 00007fdf41815fa0 RCX: 00007fdf4159aeb9 RDX: 0000000000000008 RSI: 0000000000000000 RDI: 0000000000000006 RBP: 00007fdf41608c1f R08: 00000000088000cc R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fdf41816038 R14: 00007fdf41815fa0 R15: 00007ffdd3803208