====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.2.829/17662 is trying to acquire lock: ffff88804dd607d0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_xattr_set+0x4a4/0x13f0 fs/ocfs2/xattr.c:4031 but task is already holding lock: ffff88804dd60858 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13f0 fs/ocfs2/xattr.c:4023 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&oi->ip_xattr_sem){++++}-{4:4}: down_read+0x92/0x200 kernel/locking/rwsem.c:1574 ocfs2_xattr_get+0xf4/0x260 fs/ocfs2/xattr.c:1715 __vfs_getxattr+0x412/0x440 fs/xattr.c:446 smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:298 smack_d_instantiate+0x5bb/0x810 security/smack/smack_lsm.c:3682 security_d_instantiate+0x106/0x1d0 security/security.c:3782 d_instantiate+0x54/0xb0 fs/dcache.c:2266 ocfs2_mknod+0x199e/0x2190 fs/ocfs2/namei.c:453 ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:661 vfs_mkdir+0x417/0x670 fs/namei.c:5428 filename_mkdirat+0x288/0x560 fs/namei.c:5461 __do_sys_mkdirat fs/namei.c:5482 [inline] __se_sys_mkdirat+0x35/0x150 fs/namei.c:5479 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline] do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x92/0x200 kernel/locking/rwsem.c:1574 ocfs2_start_trans+0x3aa/0x700 fs/ocfs2/journal.c:370 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:801 [inline] ocfs2_reserve_suballoc_bits+0x7b7/0x4850 fs/ocfs2/suballoc.c:950 ocfs2_reserve_new_metadata_blocks+0x415/0x9a0 fs/ocfs2/suballoc.c:1100 ocfs2_mknod+0xe79/0x2190 fs/ocfs2/namei.c:350 ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:661 vfs_mkdir+0x417/0x670 fs/namei.c:5428 filename_mkdirat+0x288/0x560 fs/namei.c:5461 __do_sys_mkdirat fs/namei.c:5482 [inline] __se_sys_mkdirat+0x35/0x150 fs/namei.c:5479 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline] do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (sb_internal#4){.+.+}-{0:0}: percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs/super.h:19 [inline] sb_start_intwrite include/linux/fs/super.h:177 [inline] ocfs2_start_trans+0x2a7/0x700 fs/ocfs2/journal.c:368 ocfs2_extend_dir+0x1186/0x4b60 fs/ocfs2/dir.c:3486 ocfs2_prepare_dx_dir_for_insert fs/ocfs2/dir.c:4437 [inline] ocfs2_prepare_dir_for_insert+0x3f03/0x51a0 fs/ocfs2/dir.c:4493 ocfs2_mknod+0x864/0x2190 fs/ocfs2/namei.c:298 ocfs2_create+0x195/0x460 fs/ocfs2/namei.c:677 lookup_open+0x103d/0x1b00 fs/namei.c:4575 open_last_lookups fs/namei.c:4774 [inline] path_openat+0x711/0x2100 fs/namei.c:5013 do_file_open+0x23e/0x4a0 fs/namei.c:5045 do_sys_openat2+0x115/0x200 fs/open.c:1442 do_sys_open fs/open.c:1448 [inline] __do_sys_creat fs/open.c:1526 [inline] __se_sys_creat fs/open.c:1520 [inline] __x64_sys_creat+0x8f/0xc0 fs/open.c:1520 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline] do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}: check_prev_add kernel/locking/lockdep.c:3209 [inline] check_prevs_add kernel/locking/lockdep.c:3328 [inline] validate_chain kernel/locking/lockdep.c:3952 [inline] __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942 down_write+0x35/0x50 kernel/locking/rwsem.c:1631 ocfs2_xattr_set+0x4a4/0x13f0 fs/ocfs2/xattr.c:4031 ocfs2_set_acl+0x6fd/0x7b0 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x1b1/0x2b0 fs/ocfs2/acl.c:286 set_posix_acl fs/posix_acl.c:960 [inline] vfs_remove_acl+0x5d8/0x8d0 fs/posix_acl.c:1247 ovl_do_remove_acl fs/overlayfs/overlayfs.h:366 [inline] ovl_workdir_create+0x58e/0x970 fs/overlayfs/super.c:390 ovl_make_workdir fs/overlayfs/super.c:718 [inline] ovl_get_workdir+0x339/0x1980 fs/overlayfs/super.c:876 ovl_fill_super_creds fs/overlayfs/super.c:1489 [inline] ovl_fill_super+0x1767/0x4570 fs/overlayfs/super.c:1601 get_tree_super fs/super.c:1360 [inline] get_tree_nodev+0xbe/0x150 fs/super.c:1380 vfs_get_tree+0x92/0x2a0 fs/super.c:1881 fc_mount fs/namespace.c:1282 [inline] do_new_mount_fc fs/namespace.c:3910 [inline] do_new_mount+0x325/0xb00 fs/namespace.c:3986 do_mount fs/namespace.c:4350 [inline] __do_sys_mount fs/namespace.c:4565 [inline] __se_sys_mount+0x31d/0x420 fs/namespace.c:4542 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline] do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_file_ip_alloc_sem_key --> &journal->j_trans_barrier --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(&journal->j_trans_barrier); lock(&oi->ip_xattr_sem); lock(&ocfs2_file_ip_alloc_sem_key); *** DEADLOCK *** locks held by syz.2.829/17662: 4, last CPU#0: #0: ffff888061f760f8 (&type->s_umount_key#56/1){+.+.}-{4:4}, at: alloc_super fs/super.c:347 [inline] #0: ffff888061f760f8 (&type->s_umount_key#56/1){+.+.}-{4:4}, at: sget_fc+0x9d5/0x1d00 fs/super.c:846 #1: ffff888067fe4528 (sb_writers#27){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:531 #2: ffff88804dd60b80 (&sb->s_type->i_mutex_key#38){++++}-{4:4}, at: inode_lock include/linux/fs.h:1026 [inline] #2: ffff88804dd60b80 (&sb->s_type->i_mutex_key#38){++++}-{4:4}, at: vfs_remove_acl+0x102/0x8d0 fs/posix_acl.c:1228 #3: ffff88804dd60858 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13f0 fs/ocfs2/xattr.c:4023 stack backtrace: CPU: 0 UID: 0 PID: 17662 Comm: syz.2.829 Not tainted syzkaller #0 PREEMPT_{RT,(full)} Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/07/2026 Call Trace: dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2087 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2219 check_prev_add kernel/locking/lockdep.c:3209 [inline] check_prevs_add kernel/locking/lockdep.c:3328 [inline] validate_chain kernel/locking/lockdep.c:3952 [inline] __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942 down_write+0x35/0x50 kernel/locking/rwsem.c:1631 ocfs2_xattr_set+0x4a4/0x13f0 fs/ocfs2/xattr.c:4031 ocfs2_set_acl+0x6fd/0x7b0 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x1b1/0x2b0 fs/ocfs2/acl.c:286 set_posix_acl fs/posix_acl.c:960 [inline] vfs_remove_acl+0x5d8/0x8d0 fs/posix_acl.c:1247 ovl_do_remove_acl fs/overlayfs/overlayfs.h:366 [inline] ovl_workdir_create+0x58e/0x970 fs/overlayfs/super.c:390 ovl_make_workdir fs/overlayfs/super.c:718 [inline] ovl_get_workdir+0x339/0x1980 fs/overlayfs/super.c:876 ovl_fill_super_creds fs/overlayfs/super.c:1489 [inline] ovl_fill_super+0x1767/0x4570 fs/overlayfs/super.c:1601 get_tree_super fs/super.c:1360 [inline] get_tree_nodev+0xbe/0x150 fs/super.c:1380 vfs_get_tree+0x92/0x2a0 fs/super.c:1881 fc_mount fs/namespace.c:1282 [inline] do_new_mount_fc fs/namespace.c:3910 [inline] do_new_mount+0x325/0xb00 fs/namespace.c:3986 do_mount fs/namespace.c:4350 [inline] __do_sys_mount fs/namespace.c:4565 [inline] __se_sys_mount+0x31d/0x420 fs/namespace.c:4542 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline] do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f825f4efb19 Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f825d746028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f825f775fa0 RCX: 00007f825f4efb19 RDX: 0000200000005580 RSI: 0000200000005540 RDI: 0000000000000000 RBP: 00007f825f587b70 R08: 00002000000055c0 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007f825f776038 R14: 00007f825f775fa0 R15: 00007ffffcd3da38 overlayfs: upper fs does not support tmpfile. (syz.2.829,17662,0):ocfs2_check_dir_entry:357 ERROR: bad entry in directory #72: rec_len is smaller than minimal - offset=0, inode=72, rec_len=1, name_len=1 (syz.2.829,17662,0):ocfs2_prepare_dir_for_insert:4507 ERROR: status = -2 (syz.2.829,17662,0):__ocfs2_prepare_orphan_dir:2185 ERROR: status = -2 (syz.2.829,17662,0):ocfs2_prepare_orphan_dir:2229 ERROR: status = -2 (syz.2.829,17662,0):ocfs2_prepare_orphan_dir:2245 ERROR: status = -2 (syz.2.829,17662,0):ocfs2_unlink:971 ERROR: status = -2 overlayfs: cleanup of 'work/#b' failed (-2) overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: upper fs missing required features.