====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Tainted: G L ------------------------------------------------------ syz.7.5665/26477 is trying to acquire lock: ffff888024a88888 (&of->mutex){+.+.}-{4:4}, at: kernfs_fop_write_iter+0x2c2/0x5f0 fs/kernfs/file.c:343 but task is already holding lock: ffff888054442c68 (&pipe->mutex){+.+.}-{4:4}, at: pipe_lock fs/pipe.c:91 [inline] ffff888054442c68 (&pipe->mutex){+.+.}-{4:4}, at: pipe_lock+0x69/0x80 fs/pipe.c:88 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&pipe->mutex){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x1a2/0x1b90 kernel/locking/mutex.c:776 pipe_lock fs/pipe.c:91 [inline] pipe_lock+0x69/0x80 fs/pipe.c:88 iter_file_splice_write+0x1fd/0x10a0 fs/splice.c:682 do_splice_from fs/splice.c:936 [inline] do_splice+0x109c/0x1fd0 fs/splice.c:1349 __do_splice+0x237/0x370 fs/splice.c:1431 __do_sys_splice fs/splice.c:1634 [inline] __se_sys_splice fs/splice.c:1616 [inline] __ia32_sys_splice+0x189/0x250 fs/splice.c:1616 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:83 [inline] __do_fast_syscall_32+0xe3/0x8c0 arch/x86/entry/syscall_32.c:307 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:332 entry_SYSENTER_compat_after_hwframe+0x84/0x8e -> #2 (sb_writers#5){.+.+}-{0:0}: percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs/super.h:19 [inline] sb_start_write include/linux/fs/super.h:125 [inline] mnt_want_write+0x6f/0x450 fs/namespace.c:493 ovl_create_object+0x12b/0x3b0 fs/overlayfs/dir.c:691 lookup_open.isra.0+0xc47/0x11b0 fs/namei.c:4483 open_last_lookups fs/namei.c:4583 [inline] path_openat+0x2291/0x31a0 fs/namei.c:4827 do_file_open+0x20e/0x430 fs/namei.c:4859 do_sys_openat2+0x10d/0x1e0 fs/open.c:1366 do_sys_open fs/open.c:1372 [inline] __do_compat_sys_openat fs/open.c:1434 [inline] __se_compat_sys_openat fs/open.c:1432 [inline] __ia32_compat_sys_openat+0x12d/0x210 fs/open.c:1432 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:83 [inline] __do_fast_syscall_32+0xe3/0x8c0 arch/x86/entry/syscall_32.c:307 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:332 entry_SYSENTER_compat_after_hwframe+0x84/0x8e -> #1 (&ovl_i_mutex_dir_key[depth]){++++}-{4:4}: down_read+0x99/0x460 kernel/locking/rwsem.c:1537 inode_lock_shared include/linux/fs.h:1043 [inline] lookup_slow+0x42/0x70 fs/namei.c:1932 walk_component fs/namei.c:2279 [inline] lookup_last fs/namei.c:2780 [inline] path_lookupat+0x5e8/0xc40 fs/namei.c:2804 filename_lookup+0x202/0x590 fs/namei.c:2833 kern_path+0x37/0x50 fs/namei.c:3040 lookup_bdev+0xd8/0x280 block/bdev.c:1221 resume_store+0x1d6/0x460 kernel/power/hibernate.c:1306 kobj_attr_store+0x58/0x80 lib/kobject.c:840 sysfs_kf_write+0xf2/0x150 fs/sysfs/file.c:142 kernfs_fop_write_iter+0x3e0/0x5f0 fs/kernfs/file.c:352 new_sync_write fs/read_write.c:595 [inline] vfs_write+0x6ac/0x1070 fs/read_write.c:688 ksys_write+0x12a/0x250 fs/read_write.c:740 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:83 [inline] __do_fast_syscall_32+0xe3/0x8c0 arch/x86/entry/syscall_32.c:307 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:332 entry_SYSENTER_compat_after_hwframe+0x84/0x8e -> #0 (&of->mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x1cf/0x380 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x1a2/0x1b90 kernel/locking/mutex.c:776 kernfs_fop_write_iter+0x2c2/0x5f0 fs/kernfs/file.c:343 iter_file_splice_write+0x830/0x10a0 fs/splice.c:736 do_splice_from fs/splice.c:936 [inline] do_splice+0x109c/0x1fd0 fs/splice.c:1349 __do_splice+0x33b/0x370 fs/splice.c:1431 __do_sys_splice fs/splice.c:1634 [inline] __se_sys_splice fs/splice.c:1616 [inline] __ia32_sys_splice+0x189/0x250 fs/splice.c:1616 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:83 [inline] __do_fast_syscall_32+0xe3/0x8c0 arch/x86/entry/syscall_32.c:307 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:332 entry_SYSENTER_compat_after_hwframe+0x84/0x8e other info that might help us debug this: Chain exists of: &of->mutex --> sb_writers#5 --> &pipe->mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&pipe->mutex); lock(sb_writers#5); lock(&pipe->mutex); lock(&of->mutex); *** DEADLOCK *** 2 locks held by syz.7.5665/26477: #0: ffff88804c692420 (sb_writers#10){.+.+}-{0:0}, at: __do_splice+0x33b/0x370 fs/splice.c:1431 #1: ffff888054442c68 (&pipe->mutex){+.+.}-{4:4}, at: pipe_lock fs/pipe.c:91 [inline] #1: ffff888054442c68 (&pipe->mutex){+.+.}-{4:4}, at: pipe_lock+0x69/0x80 fs/pipe.c:88 stack backtrace: CPU: 0 UID: 0 PID: 26477 Comm: syz.7.5665 Tainted: G L syzkaller #0 PREEMPT(full) Tainted: [L]=SOFTLOCKUP Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x100/0x190 lib/dump_stack.c:120 print_circular_bug.cold+0x178/0x1c7 kernel/locking/lockdep.c:2043 check_noncircular+0x146/0x160 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237 lock_acquire kernel/locking/lockdep.c:5868 [inline] lock_acquire+0x1cf/0x380 kernel/locking/lockdep.c:5825 __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x1a2/0x1b90 kernel/locking/mutex.c:776 kernfs_fop_write_iter+0x2c2/0x5f0 fs/kernfs/file.c:343 iter_file_splice_write+0x830/0x10a0 fs/splice.c:736 do_splice_from fs/splice.c:936 [inline] do_splice+0x109c/0x1fd0 fs/splice.c:1349 __do_splice+0x33b/0x370 fs/splice.c:1431 __do_sys_splice fs/splice.c:1634 [inline] __se_sys_splice fs/splice.c:1616 [inline] __ia32_sys_splice+0x189/0x250 fs/splice.c:1616 do_syscall_32_irqs_on arch/x86/entry/syscall_32.c:83 [inline] __do_fast_syscall_32+0xe3/0x8c0 arch/x86/entry/syscall_32.c:307 do_fast_syscall_32+0x32/0x70 arch/x86/entry/syscall_32.c:332 entry_SYSENTER_compat_after_hwframe+0x84/0x8e RIP: 0023:0xf709ef6c Code: d2 74 05 c1 e8 0c 89 02 8b 5d fc 31 c0 c9 c3 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 0f 1f 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 2e 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00 58 b8 RSP: 002b:00000000f548d50c EFLAGS: 00000292 ORIG_RAX: 0000000000000139 RAX: ffffffffffffffda RBX: 0000000000000004 RCX: 0000000000000000 RDX: 0000000000000007 RSI: 0000000000000000 RDI: 0000000000100009 RBP: 0000000000000002 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000292 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 ---------------- Code disassembly (best guess): 0: d2 74 05 c1 shlb %cl,-0x3f(%rbp,%rax,1) 4: e8 0c 89 02 8b call 0x8b028915 9: 5d pop %rbp a: fc cld b: 31 c0 xor %eax,%eax d: c9 leave e: c3 ret f: 90 nop 10: 90 nop 11: 90 nop 12: 90 nop 13: 90 nop 14: 90 nop 15: 90 nop 16: 90 nop 17: 90 nop 18: 90 nop 19: 90 nop 1a: 90 nop 1b: 90 nop 1c: 90 nop 1d: 90 nop 1e: 0f 1f 00 nopl (%rax) 21: 51 push %rcx 22: 52 push %rdx 23: 55 push %rbp 24: 89 e5 mov %esp,%ebp 26: 0f 34 sysenter 28: cd 80 int $0x80 * 2a: 5d pop %rbp <-- trapping instruction 2b: 5a pop %rdx 2c: 59 pop %rcx 2d: c3 ret 2e: 90 nop 2f: 2e 8d b4 26 00 00 00 cs lea 0x0(%rsi,%riz,1),%esi 36: 00 37: 8d b4 26 00 00 00 00 lea 0x0(%rsi,%riz,1),%esi 3e: 58 pop %rax 3f: b8 .byte 0xb8