======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.3.1163/21452 is trying to acquire lock:
ffff88802afe10e8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_free+0xc7/0x630 fs/hfsplus/bitmap.c:182

but task is already holding lock:
ffff888063a5f3b8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x2d0/0xd20 fs/hfsplus/extents.c:579

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/rtmutex_api.c:561 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:580
       hfsplus_get_block+0x391/0x1610 fs/hfsplus/extents.c:264
       block_read_full_folio+0x29f/0x810 fs/buffer.c:2308
       filemap_read_folio+0x12c/0x3a0 mm/filemap.c:2520
       do_read_cache_folio+0x2bf/0x560 mm/filemap.c:4156
       do_read_cache_page mm/filemap.c:4222 [inline]
       read_cache_page+0x5d/0x170 mm/filemap.c:4231
       read_mapping_page include/linux/pagemap.h:1009 [inline]
       hfsplus_block_allocate+0xf7/0xd30 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0xb77/0x1df0 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x41f/0x1610 fs/hfsplus/extents.c:249
       get_more_blocks fs/direct-io.c:644 [inline]
       do_direct_IO fs/direct-io.c:932 [inline]
       __blockdev_direct_IO+0x1965/0x33d0 fs/direct-io.c:1236
       blockdev_direct_IO include/linux/fs.h:3155 [inline]
       hfsplus_direct_IO+0x220/0x370 fs/hfsplus/inode.c:174
       generic_file_direct_write+0x1d1/0x3f0 mm/filemap.c:4308
       __generic_file_write_iter+0x120/0x240 mm/filemap.c:4477
       generic_file_write_iter+0xaf/0x330 mm/filemap.c:4517
       iter_file_splice_write+0xa36/0x1240 fs/splice.c:736
       do_splice_from fs/splice.c:936 [inline]
       direct_splice_actor+0x104/0x160 fs/splice.c:1159
       splice_direct_to_actor+0x586/0xcc0 fs/splice.c:1103
       do_splice_direct_actor fs/splice.c:1202 [inline]
       do_splice_direct+0x19b/0x2a0 fs/splice.c:1228
       do_sendfile+0x540/0x7e0 fs/read_write.c:1371
       __do_sys_sendfile64 fs/read_write.c:1432 [inline]
       __se_sys_sendfile64+0x144/0x1a0 fs/read_write.c:1418
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&sbi->alloc_mutex){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3209 [inline]
       check_prevs_add kernel/locking/lockdep.c:3328 [inline]
       validate_chain kernel/locking/lockdep.c:3952 [inline]
       __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
       lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
       __mutex_lock_common kernel/locking/rtmutex_api.c:561 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:580
       hfsplus_block_free+0xc7/0x630 fs/hfsplus/bitmap.c:182
       hfsplus_free_extents+0x121/0xa50 fs/hfsplus/extents.c:364
       hfsplus_file_truncate+0x7ef/0xd20 fs/hfsplus/extents.c:595
       hfsplus_delete_inode+0x180/0x230 fs/hfsplus/inode.c:-1
       hfsplus_unlink+0x4e4/0x8e0 fs/hfsplus/dir.c:420
       hfsplus_rename+0xd5/0x280 fs/hfsplus/dir.c:591
       vfs_rename+0xbd9/0xef0 fs/namei.c:6208
       filename_renameat2+0x533/0x9b0 fs/namei.c:6326
       __do_sys_rename fs/namei.c:6370 [inline]
       __se_sys_rename+0x55/0x2c0 fs/namei.c:6366
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

locks held by syz.3.1163/21452: 6, last CPU#0:
 #0: ffff88803a246510 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:494
 #1: ffff88802c22b8c8 (&type->i_mutex_dir_key#12/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1069 [inline]
 #1: ffff88802c22b8c8 (&type->i_mutex_dir_key#12/1){+.+.}-{4:4}, at: lock_rename fs/namei.c:3785 [inline]
 #1: ffff88802c22b8c8 (&type->i_mutex_dir_key#12/1){+.+.}-{4:4}, at: __start_renaming+0x148/0x410 fs/namei.c:3878
 #2: ffff888063a5eec8 (&sb->s_type->i_mutex_key#29){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline]
 #2: ffff888063a5eec8 (&sb->s_type->i_mutex_key#29){+.+.}-{4:4}, at: lock_two_nondirectories+0xe7/0x180 fs/inode.c:1254
 #3: ffff888063a5f588 (&sb->s_type->i_mutex_key#29/4){+.+.}-{4:4}, at: vfs_rename+0x696/0xef0 fs/namei.c:6168
 #4: ffff88802afe1178 (&sbi->vh_mutex){+.+.}-{4:4}, at: hfsplus_unlink+0x18b/0x8e0 fs/hfsplus/dir.c:385
 #5: ffff888063a5f3b8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x2d0/0xd20 fs/hfsplus/extents.c:579

stack backtrace:
CPU: 0 UID: 0 PID: 21452 Comm: syz.3.1163 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2087
 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2219
 check_prev_add kernel/locking/lockdep.c:3209 [inline]
 check_prevs_add kernel/locking/lockdep.c:3328 [inline]
 validate_chain kernel/locking/lockdep.c:3952 [inline]
 __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
 __mutex_lock_common kernel/locking/rtmutex_api.c:561 [inline]
 mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:580
 hfsplus_block_free+0xc7/0x630 fs/hfsplus/bitmap.c:182
 hfsplus_free_extents+0x121/0xa50 fs/hfsplus/extents.c:364
 hfsplus_file_truncate+0x7ef/0xd20 fs/hfsplus/extents.c:595
 hfsplus_delete_inode+0x180/0x230 fs/hfsplus/inode.c:-1
 hfsplus_unlink+0x4e4/0x8e0 fs/hfsplus/dir.c:420
 hfsplus_rename+0xd5/0x280 fs/hfsplus/dir.c:591
 vfs_rename+0xbd9/0xef0 fs/namei.c:6208
 filename_renameat2+0x533/0x9b0 fs/namei.c:6326
 __do_sys_rename fs/namei.c:6370 [inline]
 __se_sys_rename+0x55/0x2c0 fs/namei.c:6366
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f9ec4aee159
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9ec2d46028 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007f9ec4d75fa0 RCX: 00007f9ec4aee159
RDX: 0000000000000000 RSI: 0000200000000140 RDI: 0000200000000100
RBP: 00007f9ec4b8506b R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f9ec4d76038 R14: 00007f9ec4d75fa0 R15: 00007ffd0d663978
 </TASK>
hfsplus: invalid length 1280 has been corrected to 255
hfsplus: invalid length 1280 has been corrected to 255