hfsplus: invalid extended attribute record ====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.0.0/5322 is trying to acquire lock: ffff8880122e80f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_free+0xc7/0x630 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff8880122edc08 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x2b3/0xc30 fs/hfsplus/extents.c:573 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x19f/0x1300 kernel/locking/mutex.c:776 hfsplus_get_block+0x39e/0x1670 fs/hfsplus/extents.c:260 block_read_full_folio+0x29f/0x830 fs/buffer.c:2417 filemap_read_folio+0x137/0x3b0 mm/filemap.c:2501 do_read_cache_folio+0x358/0x590 mm/filemap.c:4101 do_read_cache_page mm/filemap.c:4167 [inline] read_cache_page+0x5d/0x170 mm/filemap.c:4176 read_mapping_page include/linux/pagemap.h:1022 [inline] hfsplus_block_allocate+0xf3/0xce0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xb2d/0x1d70 fs/hfsplus/extents.c:464 hfsplus_get_block+0x42c/0x1670 fs/hfsplus/extents.c:245 __block_write_begin_int+0x6c6/0x1910 fs/buffer.c:2142 block_write_begin fs/buffer.c:2253 [inline] cont_write_begin+0x737/0xae0 fs/buffer.c:2591 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48 cont_expand_zero fs/buffer.c:2552 [inline] cont_write_begin+0x7cc/0xae0 fs/buffer.c:2581 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48 generic_perform_write+0x2e2/0x8f0 mm/filemap.c:4319 generic_file_write_iter+0x14a/0x680 mm/filemap.c:4462 do_iter_readv_writev+0x619/0x8c0 fs/read_write.c:-1 vfs_writev+0x33c/0x990 fs/read_write.c:1059 do_pwritev fs/read_write.c:1155 [inline] __do_sys_pwritev2 fs/read_write.c:1213 [inline] __se_sys_pwritev2+0x184/0x2a0 fs/read_write.c:1204 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237 lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x19f/0x1300 kernel/locking/mutex.c:776 hfsplus_block_free+0xc7/0x630 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x121/0xa50 fs/hfsplus/extents.c:360 hfsplus_file_truncate+0x762/0xc30 fs/hfsplus/extents.c:588 hfsplus_delete_inode fs/hfsplus/inode.c:-1 [inline] hfsplus_file_release+0x303/0x3e0 fs/hfsplus/inode.c:259 __fput+0x44f/0xa70 fs/file_table.c:469 task_work_run+0x1d9/0x270 kernel/task_work.c:233 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] __exit_to_user_mode_loop kernel/entry/common.c:67 [inline] exit_to_user_mode_loop+0xed/0x480 kernel/entry/common.c:98 __exit_to_user_mode_prepare include/linux/irq-entry-common.h:226 [inline] syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:256 [inline] syscall_exit_to_user_mode include/linux/entry-common.h:325 [inline] do_syscall_64+0x32d/0xf80 arch/x86/entry/syscall_64.c:100 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 2 locks held by syz.0.0/5322: #0: ffff8880122eddf8 (&sb->s_type->i_mutex_key#25){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline] #0: ffff8880122eddf8 (&sb->s_type->i_mutex_key#25){+.+.}-{4:4}, at: hfsplus_file_release+0xe2/0x3e0 fs/hfsplus/inode.c:254 #1: ffff8880122edc08 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x2b3/0xc30 fs/hfsplus/extents.c:573 stack backtrace: CPU: 0 UID: 0 PID: 5322 Comm: syz.0.0 Not tainted syzkaller #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 Call Trace: dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237 lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x19f/0x1300 kernel/locking/mutex.c:776 hfsplus_block_free+0xc7/0x630 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x121/0xa50 fs/hfsplus/extents.c:360 hfsplus_file_truncate+0x762/0xc30 fs/hfsplus/extents.c:588 hfsplus_delete_inode fs/hfsplus/inode.c:-1 [inline] hfsplus_file_release+0x303/0x3e0 fs/hfsplus/inode.c:259 __fput+0x44f/0xa70 fs/file_table.c:469 task_work_run+0x1d9/0x270 kernel/task_work.c:233 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] __exit_to_user_mode_loop kernel/entry/common.c:67 [inline] exit_to_user_mode_loop+0xed/0x480 kernel/entry/common.c:98 __exit_to_user_mode_prepare include/linux/irq-entry-common.h:226 [inline] syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:256 [inline] syscall_exit_to_user_mode include/linux/entry-common.h:325 [inline] do_syscall_64+0x32d/0xf80 arch/x86/entry/syscall_64.c:100 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f5dc999c799 Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffc91dc2358 EFLAGS: 00000246 ORIG_RAX: 00000000000001b4 RAX: 0000000000000000 RBX: 00007ffc91dc2440 RCX: 00007f5dc999c799 RDX: 0000000000000000 RSI: 000000000000001e RDI: 0000000000000003 RBP: 00000000000145b5 R08: 0000000000000001 R09: 0000000000000000 R10: 00007f5dc97ff030 R11: 0000000000000246 R12: 00007ffc91dc2480 R13: 00007f5dc9c15fac R14: 0000000000014dbd R15: 00007f5dc9c15fa0 hfsplus: unable to mark blocks free: error -5 hfsplus: can't free extent: start 134, count 1