KMSAN: use-after-free in adu_disconnect

Status: fixed on 2019/11/27 06:10
Subsystems: usb
[Documentation on labels]
Fix commit: 44efc269db79 USB: adutux: fix use-after-free on disconnect
First crash: 2482d, last: 2476d

Sample crash report:
usb 1-1: USB disconnect, device number 16
=====================================================
BUG: KMSAN: use-after-free in usb_unbind_interface+0x3a2/0xdd0 drivers/usb/core/driver.c:423
CPU: 0 PID: 3337 Comm: kworker/0:2 Not tainted 5.3.0-rc7+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x191/0x1f0 lib/dump_stack.c:113
 kmsan_report+0x17d/0x2f0 mm/kmsan/kmsan_report.c:114
 __msan_warning+0x73/0xe0 mm/kmsan/kmsan_instr.c:250
 adu_disconnect+0x302/0x360 drivers/usb/misc/adutux.c:774
 usb_unbind_interface+0x3a2/0xdd0 drivers/usb/core/driver.c:423
 __device_release_driver drivers/base/dd.c:1120 [inline]
 device_release_driver_internal+0x911/0xd20 drivers/base/dd.c:1151
 device_release_driver+0x4b/0x60 drivers/base/dd.c:1174
 bus_remove_device+0x4bf/0x670 drivers/base/bus.c:556
 device_del+0xcd5/0x1d10 drivers/base/core.c:2339
 usb_disable_device+0x567/0x1150 drivers/usb/core/message.c:1241
 usb_disconnect+0x51e/0xd60 drivers/usb/core/hub.c:2199
 hub_port_connect drivers/usb/core/hub.c:4949 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x3fd0/0x72f0 drivers/usb/core/hub.c:5441
 process_one_work+0x1572/0x1ef0 kernel/workqueue.c:2269
 worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Uninit was created at:
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:154 [inline]
 kmsan_internal_poison_shadow+0x60/0x120 mm/kmsan/kmsan.c:137
 kmsan_slab_free+0x8d/0x100 mm/kmsan/kmsan_hooks.c:123
 slab_free_freelist_hook mm/slub.c:1472 [inline]
 slab_free mm/slub.c:3038 [inline]
 kfree+0x4c1/0x2db0 mm/slub.c:3980
 adu_delete drivers/usb/misc/adutux.c:151 [inline]
 adu_release+0x95f/0xa50 drivers/usb/misc/adutux.c:332
 __fput+0x4c9/0xba0 fs/file_table.c:280
 ____fput+0x37/0x40 fs/file_table.c:313
 task_work_run+0x22e/0x2a0 kernel/task_work.c:113
 tracehook_notify_resume include/linux/tracehook.h:188 [inline]
 exit_to_usermode_loop arch/x86/entry/common.c:163 [inline]
 prepare_exit_to_usermode+0x39d/0x4d0 arch/x86/entry/common.c:194
 syscall_return_slowpath+0x90/0x610 arch/x86/entry/common.c:274
 do_syscall_64+0xe2/0xf0 arch/x86/entry/common.c:300
 entry_SYSCALL_64_after_hwframe+0x63/0xe7
=====================================================

Crashes (16):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/10/08 19:01 https://github.com/google/kmsan.git master cebb918b7474 b1ebbfef .config console log report syz C ci-upstream-kmsan-gce
2019/10/14 16:08 https://github.com/google/kmsan.git master a1a7d049fdec 05ad7292 .config console log report ci-upstream-kmsan-gce
2019/10/14 00:50 https://github.com/google/kmsan.git master fa1690255288 2f661ec4 .config console log report ci-upstream-kmsan-gce
2019/10/13 17:08 https://github.com/google/kmsan.git master fa1690255288 2f661ec4 .config console log report ci-upstream-kmsan-gce
2019/10/11 17:13 https://github.com/google/kmsan.git master dde8031634c3 1a3bad90 .config console log report ci-upstream-kmsan-gce
2019/10/11 16:55 https://github.com/google/kmsan.git master dde8031634c3 1a3bad90 .config console log report ci-upstream-kmsan-gce
2019/10/10 16:25 https://github.com/google/kmsan.git master c38191cb7026 a4efa8c0 .config console log report ci-upstream-kmsan-gce
2019/10/10 15:18 https://github.com/google/kmsan.git master c38191cb7026 a4efa8c0 .config console log report ci-upstream-kmsan-gce
2019/10/10 01:13 https://github.com/google/kmsan.git master dc327ecad3b0 c4b9981b .config console log report ci-upstream-kmsan-gce
2019/10/09 23:34 https://github.com/google/kmsan.git master dc327ecad3b0 c4b9981b .config console log report ci-upstream-kmsan-gce
2019/10/09 21:51 https://github.com/google/kmsan.git master eff1487c45ce 312c6a5a .config console log report ci-upstream-kmsan-gce
2019/10/08 18:48 https://github.com/google/kmsan.git master cebb918b7474 b1ebbfef .config console log report ci-upstream-kmsan-gce
2019/10/08 18:09 https://github.com/google/kmsan.git master cebb918b7474 b1ebbfef .config console log report ci-upstream-kmsan-gce
2019/10/08 15:05 https://github.com/google/kmsan.git master cebb918b7474 137e37ca .config console log report ci-upstream-kmsan-gce
2019/10/08 14:02 https://github.com/google/kmsan.git master cebb918b7474 137e37ca .config console log report ci-upstream-kmsan-gce
2019/10/08 12:21 https://github.com/google/kmsan.git master cebb918b7474 28ac6e64 .config console log report ci-upstream-kmsan-gce
2019/10/08 11:38 https://github.com/google/kmsan.git master cebb918b7474 28ac6e64 .config console log report ci-upstream-kmsan-gce
* Struck through repros no longer work on HEAD.