(syz.0.17,4317,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/4317 is trying to acquire lock:
ffff88805ad71808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff88805ad71808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16d/0x44b0 fs/ocfs2/suballoc.c:804

but task is already holding lock:
ffff88805ad786f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x47d/0x1390 fs/ocfs2/xattr.c:3587

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x15de/0x2510 fs/ocfs2/namei.c:410
       ocfs2_create+0x192/0x420 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3470 [inline]
       open_last_lookups fs/namei.c:3540 [inline]
       path_openat+0x120a/0x2fb0 fs/namei.c:3747
       do_filp_open+0x1df/0x400 fs/namei.c:3777
       do_sys_openat2+0x14b/0x500 fs/open.c:1255
       do_sys_open fs/open.c:1271 [inline]
       __do_sys_openat fs/open.c:1287 [inline]
       __se_sys_openat fs/open.c:1282 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1282
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe0/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1499/0x1820 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x72f/0xa80 fs/quota/dquot.c:2485
       dquot_load_quota_inode+0x2d3/0x5c0 fs/quota/dquot.c:2522
       ocfs2_enable_quotas+0x1c0/0x4a0 fs/ocfs2/super.c:927
       ocfs2_fill_super+0x3c84/0x50a0 fs/ocfs2/super.c:1140
       mount_bdev+0x28a/0x3c0 fs/super.c:1400
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x247/0xa40 fs/namespace.c:3034
       do_mount fs/namespace.c:3377 [inline]
       __do_sys_mount fs/namespace.c:3585 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2a7/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_mknod+0xf70/0x2510 fs/ocfs2/namei.c:361
       ocfs2_create+0x192/0x420 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3470 [inline]
       open_last_lookups fs/namei.c:3540 [inline]
       path_openat+0x120a/0x2fb0 fs/namei.c:3747
       do_filp_open+0x1df/0x400 fs/namei.c:3777
       do_sys_openat2+0x14b/0x500 fs/open.c:1255
       do_sys_open fs/open.c:1271 [inline]
       __do_sys_openat fs/open.c:1287 [inline]
       __se_sys_openat fs/open.c:1282 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1282
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_reserve_local_alloc_bits+0x11c/0x2630 fs/ocfs2/localalloc.c:635
       ocfs2_reserve_clusters_with_limit+0x1b6/0xc10 fs/ocfs2/suballoc.c:1184
       ocfs2_mknod+0xf0e/0x2510 fs/ocfs2/namei.c:354
       ocfs2_create+0x192/0x420 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3470 [inline]
       open_last_lookups fs/namei.c:3540 [inline]
       path_openat+0x120a/0x2fb0 fs/namei.c:3747
       do_filp_open+0x1df/0x400 fs/namei.c:3777
       do_sys_openat2+0x14b/0x500 fs/open.c:1255
       do_sys_open fs/open.c:1271 [inline]
       __do_sys_openat fs/open.c:1287 [inline]
       __se_sys_openat fs/open.c:1282 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1282
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_reserve_suballoc_bits+0x16d/0x44b0 fs/ocfs2/suballoc.c:804
       ocfs2_reserve_new_metadata_blocks+0x412/0x9a0 fs/ocfs2/suballoc.c:1000
       ocfs2_init_xattr_set_ctxt+0x2f4/0x6f0 fs/ocfs2/xattr.c:3281
       ocfs2_xattr_set+0xc68/0x1390 fs/ocfs2/xattr.c:3638
       __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
       __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x2cb/0x360 fs/xattr.c:611
       path_setxattr+0x147/0x290 fs/xattr.c:630
       __do_sys_setxattr fs/xattr.c:646 [inline]
       __se_sys_setxattr fs/xattr.c:642 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);

 *** DEADLOCK ***

3 locks held by syz.0.17/4317:
 #0: ffff888021d50460 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386
 #1: ffff88805ad789c8 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff88805ad789c8 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: vfs_setxattr+0x140/0x2e0 fs/xattr.c:302
 #2: ffff88805ad786f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x47d/0x1390 fs/ocfs2/xattr.c:3587

stack backtrace:
CPU: 1 PID: 4317 Comm: syz.0.17 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:787 [inline]
 ocfs2_reserve_suballoc_bits+0x16d/0x44b0 fs/ocfs2/suballoc.c:804
 ocfs2_reserve_new_metadata_blocks+0x412/0x9a0 fs/ocfs2/suballoc.c:1000
 ocfs2_init_xattr_set_ctxt+0x2f4/0x6f0 fs/ocfs2/xattr.c:3281
 ocfs2_xattr_set+0xc68/0x1390 fs/ocfs2/xattr.c:3638
 __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
 __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x167/0x2e0 fs/xattr.c:303
 do_setxattr fs/xattr.c:588 [inline]
 setxattr+0x2cb/0x360 fs/xattr.c:611
 path_setxattr+0x147/0x290 fs/xattr.c:630
 __do_sys_setxattr fs/xattr.c:646 [inline]
 __se_sys_setxattr fs/xattr.c:642 [inline]
 __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f135f68c0d9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffefc329188 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 00007f135f913fa0 RCX: 00007f135f68c0d9
RDX: 0000200000001b00 RSI: 0000200000000080 RDI: 0000200000000040
RBP: 00007f135f723024 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000fc9 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f135f913fac R14: 00007f135f913fa0 R15: 00007f135f913fa0
 </TASK>