UBSAN: shift-out-of-bounds in __red_change

Status: fixed on 2021/03/10 01:48
Subsystems: net
[Documentation on labels]
Fix commit: bd1248f1ddbc net: sched: prevent invalid Scell_log shift count
First crash: 2055d, last: 1966d
Cause bisection: introduced by (bisect log) [no-op commit]:
commit 9eb4b5180d33c827f16829644ae0cd7382ecdb82
Author: Len Brown <len.brown@intel.com>
Date: Sat Aug 31 18:40:39 2019 +0000

  tools/power turbostat: update version number

Crash: general protection fault in batadv_iv_ogm_queue_add (log)
Repro: C syz .config
  

Sample crash report:
IPVS: ftp: loaded support on port[0] = 21
================================================================================
UBSAN: shift-out-of-bounds in ./include/net/red.h:252:22
shift exponent 52 is too large for 32-bit type 'int'
CPU: 0 PID: 8482 Comm: syz-executor135 Not tainted 5.10.0-rc6-next-20201207-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:79 [inline]
 dump_stack+0x107/0x163 lib/dump_stack.c:120
 ubsan_epilogue+0xb/0x5a lib/ubsan.c:148
 __ubsan_handle_shift_out_of_bounds.cold+0xb1/0x181 lib/ubsan.c:395
 red_set_parms include/net/red.h:252 [inline]
 __red_change.cold+0x57/0xf5 net/sched/sch_red.c:288
 red_init+0x16b/0x260 net/sched/sch_red.c:348
 qdisc_create+0x4ba/0x13a0 net/sched/sch_api.c:1246
 tc_modify_qdisc+0x4c8/0x1a30 net/sched/sch_api.c:1662
 rtnetlink_rcv_msg+0x498/0xb80 net/core/rtnetlink.c:5562
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2494
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x907/0xe40 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2345
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2399
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2432
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x440c19
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 0b 10 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffc8ed30548 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004a24f0 RCX: 0000000000440c19
RDX: 0000000000000000 RSI: 00000000200007c0 RDI: 0000000000000003
RBP: 00007ffc8ed30550 R08: 0000000120080522 R09: 0000000120080522
R10: 0000000120080522 R11: 0000000000000246 R12: 00000000004a24f0
R13: 0000000000402140 R14: 0000000000000000 R15: 0000000000000000
================================================================================

Crashes (24):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/12/08 12:32 linux-next 15ac8fdb7440 51a9082e .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2021/02/05 16:07 upstream dd86e7fa07a3 23a562df .config console log report info ci-upstream-kasan-gce UBSAN: shift-out-of-bounds in __red_change
2021/02/25 10:38 net-old 6fbd15c09691 fcc6d71b .config console log report info ci-upstream-net-this-kasan-gce UBSAN: shift-out-of-bounds in __red_change
2021/02/08 05:17 net-old 225353c070fd 2ce644fc .config console log report info ci-upstream-net-this-kasan-gce UBSAN: shift-out-of-bounds in __red_change
2021/03/07 00:48 net-next-old d310ec03a34e e4b4d570 .config console log report info ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in __red_change
2021/02/22 07:46 net-next-old d310ec03a34e a659b3f1 .config console log report info ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in __red_change
2021/01/22 12:26 net-next-old fdb6b338d2e5 d4f4eca5 .config console log report info ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in __red_change
2020/12/20 03:02 upstream 467f8165a2b0 04201c06 .config console log report info ci-upstream-kasan-gce
2020/12/20 02:55 upstream 467f8165a2b0 04201c06 .config console log report info ci-upstream-kasan-gce-selinux-root
2020/12/16 19:51 upstream 5e60366d56c6 04201c06 .config console log report info ci-upstream-kasan-gce
2020/12/16 18:01 upstream 5e60366d56c6 04201c06 .config console log report info ci-upstream-kasan-gce
2020/12/20 03:01 upstream 467f8165a2b0 04201c06 .config console log report info ci-upstream-kasan-gce-386
2020/12/27 00:36 net-old 1f45dc220667 821e0b09 .config console log report info ci-upstream-net-this-kasan-gce
2020/12/26 21:11 net-old 1f45dc220667 821e0b09 .config console log report info ci-upstream-net-this-kasan-gce
2020/12/26 13:14 net-old 1f45dc220667 821e0b09 .config console log report info ci-upstream-net-this-kasan-gce
2020/12/21 22:23 net-old fec6079b2eea 04201c06 .config console log report info ci-upstream-net-this-kasan-gce
2020/12/21 05:26 net-old fec6079b2eea 04201c06 .config console log report info ci-upstream-net-this-kasan-gce
2021/01/05 19:06 net-next-old 3db1a3fa9880 a0234d98 .config console log report info ci-upstream-net-kasan-gce
2021/01/05 16:31 net-next-old 3db1a3fa9880 a0234d98 .config console log report info ci-upstream-net-kasan-gce
2021/01/04 14:05 net-next-old 3db1a3fa9880 79264ae3 .config console log report info ci-upstream-net-kasan-gce
2021/01/02 19:42 net-next-old 3db1a3fa9880 79264ae3 .config console log report info ci-upstream-net-kasan-gce
2021/01/02 11:20 net-next-old 3db1a3fa9880 79264ae3 .config console log report info ci-upstream-net-kasan-gce
2020/12/30 11:35 net-next-old 3db1a3fa9880 0fa352f2 .config console log report info ci-upstream-net-kasan-gce
2020/12/08 12:04 linux-next 15ac8fdb7440 51a9082e .config console log report info ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.