KMSAN: kernel-usb-infoleak in pcan_usb_pro_init

Status: fixed on 2019/08/27 17:15
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+d6a5a1a3657b596ef132@syzkaller.appspotmail.com
Fix commit: ead16e53c2f0 can: peak_usb: pcan_usb_pro: Fix info-leaks to USB devices
First crash: 2589d, last: 2529d
▶ ▼ Discussions (9)
Title Replies (including bot) Last reply
[PATCH 3.16 00/83] 3.16.78-rc1 review 88 (88) 2019/11/21 21:42
[PATCH 4.4 00/78] 4.4.190-stable review 91 (91) 2019/08/24 18:14
[PATCH 4.9 000/103] 4.9.190-stable review 109 (109) 2019/08/24 17:59
[PATCH 5.2 000/144] 5.2.9-stable review 153 (153) 2019/08/16 07:15
[PATCH 4.14 00/69] 4.14.139-stable review 76 (76) 2019/08/16 07:15
[PATCH 4.19 00/91] 4.19.67-stable review 106 (106) 2019/08/16 06:53
[PATCH 4/4] can: peak_usb: pcan_usb_pro: Fix info-leaks to USB devices 1 (1) 2019/08/02 12:00
[PATCH] peak_usb: Fix info-leaks to USB devices 2 (2) 2019/08/02 11:45
KMSAN: kernel-usb-infoleak in pcan_usb_pro_init 0 (1) 2019/07/30 09:38

Sample crash report:
usb 1-1: config 0 has no interface number 0
usb 1-1: New USB device found, idVendor=0c72, idProduct=000d, bcdDevice=da.d3
usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1: config 0 descriptor??
==================================================================
BUG: KMSAN: kernel-usb-infoleak in usb_submit_urb+0x7ef/0x1f50 drivers/usb/core/urb.c:405
CPU: 1 PID: 49 Comm: kworker/1:1 Not tainted 5.3.0-rc3+ #17
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x191/0x1f0 lib/dump_stack.c:113
 kmsan_report+0x162/0x2d0 mm/kmsan/kmsan_report.c:109
 kmsan_internal_check_memory+0x7be/0x8d0 mm/kmsan/kmsan.c:551
 kmsan_handle_urb+0x28/0x40 mm/kmsan/kmsan_hooks.c:621
 usb_submit_urb+0x7ef/0x1f50 drivers/usb/core/urb.c:405
 usb_start_wait_urb+0x143/0x410 drivers/usb/core/message.c:58
 usb_internal_control_msg drivers/usb/core/message.c:102 [inline]
 usb_control_msg+0x49f/0x7f0 drivers/usb/core/message.c:156
 pcan_usb_pro_send_req drivers/net/can/usb/peak_usb/pcan_usb_pro.c:336 [inline]
 pcan_usb_pro_drv_loaded drivers/net/can/usb/peak_usb/pcan_usb_pro.c:504 [inline]
 pcan_usb_pro_init+0x1319/0x1720 drivers/net/can/usb/peak_usb/pcan_usb_pro.c:894
 peak_usb_create_dev drivers/net/can/usb/peak_usb/pcan_usb_core.c:809 [inline]
 peak_usb_probe+0x1416/0x1b20 drivers/net/can/usb/peak_usb/pcan_usb_core.c:907
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
 really_probe+0x1373/0x1dc0 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:709
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:816
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:882
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:929
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2114
 usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
 generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
 usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
 really_probe+0x1373/0x1dc0 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:709
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:816
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:882
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:929
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2114
 usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x581d/0x72f0 drivers/usb/core/hub.c:5441
 process_one_work+0x1572/0x1ef0 kernel/workqueue.c:2269
 worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Uninit was created at:
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:187 [inline]
 kmsan_internal_poison_shadow+0x53/0xa0 mm/kmsan/kmsan.c:146
 kmsan_slab_alloc+0xaa/0x120 mm/kmsan/kmsan_hooks.c:175
 slab_alloc_node mm/slub.c:2790 [inline]
 slab_alloc mm/slub.c:2799 [inline]
 kmem_cache_alloc_trace+0x8c5/0xd20 mm/slub.c:2816
 kmalloc include/linux/slab.h:552 [inline]
 pcan_usb_pro_drv_loaded drivers/net/can/usb/peak_usb/pcan_usb_pro.c:497 [inline]
 pcan_usb_pro_init+0xe96/0x1720 drivers/net/can/usb/peak_usb/pcan_usb_pro.c:894
 peak_usb_create_dev drivers/net/can/usb/peak_usb/pcan_usb_core.c:809 [inline]
 peak_usb_probe+0x1416/0x1b20 drivers/net/can/usb/peak_usb/pcan_usb_core.c:907
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
 really_probe+0x1373/0x1dc0 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:709
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:816
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:882
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:929
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2114
 usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
 generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
 usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
 really_probe+0x1373/0x1dc0 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:709
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:816
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:882
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:929
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2114
 usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x581d/0x72f0 drivers/usb/core/hub.c:5441
 process_one_work+0x1572/0x1ef0 kernel/workqueue.c:2269
 worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Bytes 2-15 of 16 are uninitialized
Memory access of size 16 starts at ffff888109688e70
==================================================================

Crashes (13):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/08/23 15:31 https://github.com/google/kmsan.git master 61ccdad1fcdf ca6f3cfa .config console log report syz C ci-upstream-kmsan-gce
2019/07/22 19:14 https://github.com/google/kmsan.git master beaab8a31e0d b3c615f5 .config console log report syz C ci-upstream-kmsan-gce
2019/08/21 09:38 https://github.com/google/kmsan.git master 61ccdad1fcdf 4ea67ff8 .config console log report ci-upstream-kmsan-gce
2019/08/21 09:35 https://github.com/google/kmsan.git master 61ccdad1fcdf 4ea67ff8 .config console log report ci-upstream-kmsan-gce
2019/08/20 08:40 https://github.com/google/kmsan.git master 61ccdad1fcdf ee12860b .config console log report ci-upstream-kmsan-gce
2019/08/20 08:14 https://github.com/google/kmsan.git master 61ccdad1fcdf ee12860b .config console log report ci-upstream-kmsan-gce
2019/08/17 18:59 https://github.com/google/kmsan.git master 61ccdad1fcdf 55bf8926 .config console log report ci-upstream-kmsan-gce
2019/08/15 19:28 https://github.com/google/kmsan.git master 61ccdad1fcdf 0d298d6b .config console log report ci-upstream-kmsan-gce
2019/08/14 19:55 https://github.com/google/kmsan.git master 61ccdad1fcdf 5576551b .config console log report ci-upstream-kmsan-gce
2019/07/25 14:40 https://github.com/google/kmsan.git master beaab8a31e0d 32329ceb .config console log report ci-upstream-kmsan-gce
2019/07/22 18:37 https://github.com/google/kmsan.git master beaab8a31e0d b3c615f5 .config console log report ci-upstream-kmsan-gce
2019/06/25 03:19 https://github.com/google/kmsan.git master 6e0b7ebbe9bc 82c13b6b .config console log report ci-upstream-kmsan-gce
2019/06/25 01:33 https://github.com/google/kmsan.git master 6e0b7ebbe9bc 82c13b6b .config console log report ci-upstream-kmsan-gce
* Struck through repros no longer work on HEAD.