WARNING: suspicious RCU usage in ovs_flow_tbl_destroy

Status: fixed on 2020/09/16 22:51
Subsystems: openvswitch
[Documentation on labels]
Reported-by: syzbot+c0eb9e7cdde04e4eb4be@syzkaller.appspotmail.com
Fix commit: fea07a487c6d net: openvswitch: silence suspicious RCU usage warning
First crash: 2195d, last: 2192d
Cause bisection: introduced by (bisect log) :
commit 9bf24f594c6acf676fb8c229f152c21bfb915ddb
Author: Eelco Chaudron <echaudro@redhat.com>
Date: Fri Jul 31 12:21:34 2020 +0000

  net: openvswitch: make masks cache size configurable

Crash: WARNING: suspicious RCU usage in ovs_flow_tbl_destroy (log)
Repro: C syz .config
  
▶ ▼ Discussions (2)
Title Replies (including bot) Last reply
[PATCH] net: openvswitch: silence suspicious RCU usage warning 4 (4) 2020/08/05 19:21
WARNING: suspicious RCU usage in ovs_flow_tbl_destroy 0 (2) 2020/08/04 19:10
▶ ▼ Last patch testing requests (1)
Created Duration User Patch Repo Result
2020/08/04 16:26 9m pabeni@redhat.com patch net-next-old report log

Sample crash report:
netlink: 'syz-executor157': attribute type 2 has an invalid length.
=============================
WARNING: suspicious RCU usage
5.8.0-rc7-syzkaller #0 Not tainted
-----------------------------
net/openvswitch/flow_table.c:521 suspicious rcu_dereference_check() usage!

other info that might help us debug this:


rcu_scheduler_active = 2, debug_locks = 1
1 lock held by syz-executor157/6833:
 #0: ffffffff8a832390 (cb_lock){++++}-{3:3}, at: genl_rcv+0x15/0x40 net/netlink/genetlink.c:741

stack backtrace:
CPU: 1 PID: 6833 Comm: syz-executor157 Not tainted 5.8.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 ovs_flow_tbl_destroy+0x1d6/0x210 net/openvswitch/flow_table.c:521
 ovs_dp_cmd_new+0x8ca/0xea0 net/openvswitch/datapath.c:1747
 genl_family_rcv_msg_doit net/netlink/genetlink.c:669 [inline]
 genl_family_rcv_msg net/netlink/genetlink.c:714 [inline]
 genl_rcv_msg+0x61d/0x980 net/netlink/genetlink.c:731
 netlink_rcv_skb+0x15a/0x430 net/netlink/af_netlink.c:2470
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:742
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:651 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:671
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2359
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2413
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2446
 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:384
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x4402d9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fff373c1e48 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004402d9
RDX: 0000000000000000 RSI: 00000000200000c0 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 0000000000000000 R09: 00000000004002c8
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000401ae0
R13: 0000000000401b70 R14: 0000000000000000 R15: 0000000000000000

=============================
WARNING: suspicious RCU usage
5.8.0-rc7-syzkaller #0 Not tainted
-----------------------------
net/openvswitch/flow_table.c:522 suspicious rcu_dereference_check() usage!

other info that might help us debug this:


rcu_scheduler_active = 2, debug_locks = 1
1 lock held by syz-executor157/6833:
 #0: ffffffff8a832390 (cb_lock){++++}-{3:3}, at: genl_rcv+0x15/0x40 net/netlink/genetlink.c:741

stack backtrace:
CPU: 1 PID: 6833 Comm: syz-executor157 Not tainted 5.8.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 ovs_flow_tbl_destroy+0x190/0x210 net/openvswitch/flow_table.c:522
 ovs_dp_cmd_new+0x8ca/0xea0 net/openvswitch/datapath.c:1747
 genl_family_rcv_msg_doit net/netlink/genetlink.c:669 [inline]
 genl_family_rcv_msg net/netlink/genetlink.c:714 [inline]
 genl_rcv_msg+0x61d/0x980 net/netlink/genetlink.c:731
 netlink_rcv_skb+0x15a/0x430 net/netlink/af_netlink.c:2470
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:742
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:651 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:671
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2359
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2413
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2446
 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:384
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x4402d9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fff373c1e48 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004402d9
RDX: 0000000000000

Crashes (658):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/08/05 11:49 bpf-next da7955405fb2 b7129355 .config console log report syz C ci-upstream-bpf-next-kasan-gce
2020/08/04 07:10 net-next-old 2f631133c40c 196277c4 .config console log report syz C ci-upstream-net-kasan-gce
2020/08/06 21:08 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 20:52 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 19:45 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 18:50 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 18:30 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 17:29 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 16:58 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 15:57 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 15:32 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 14:31 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 14:06 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 13:04 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 12:46 bpf-next da7955405fb2 1f122f88 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 11:04 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 10:08 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 09:57 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 08:53 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 08:42 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 07:37 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 07:07 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 06:06 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 05:42 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 04:35 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 04:08 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 03:01 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 02:27 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 01:24 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/06 00:13 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 23:48 bpf-next da7955405fb2 0487ea6f .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 22:44 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 22:31 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 21:30 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 20:45 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 20:27 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 19:25 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 18:45 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 18:39 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 17:37 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 16:51 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 15:49 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 15:41 bpf-next da7955405fb2 b7129355 .config console log report ci-upstream-bpf-next-kasan-gce
2020/08/05 06:53 net-next-old da7955405fb2 80a06902 .config console log report ci-upstream-net-kasan-gce
2020/08/04 06:08 net-next-old 2f631133c40c 196277c4 .config console log report ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.