syzbot
KCSAN: data-race in generic_fillattr / shmem_unlink (5)
Status:
moderation: reported on 2026/11/17 13:39
Subsystems:
fs
Labels:
race:benign
prio:low
[Documentation on labels]
Reported-by: syzbot+bc78d191849d03756b4f@syzkaller.appspotmail.com
First crash: 3h45m, last: 3h45m
✨ AI-generated root cause summary:
In tmpfs (mm/shmem.c), directory inode size is updated directly with plain, unmarked arithmetic (such as dir->i_size -= BOGO_DIRENT_SIZE in shmem_unlink) rather than via i_size_write(). Meanwhile, stat operations (generic_fillattr() via shmem_getattr()) read inode->i_size locklessly using i_size_read(), which expects writers to use i_size_write() to pair smp_store_release() with smp_load_acquire() on 64-bit systems and maintain i_size_seqcount on 32-bit systems. This unsynchronized plain store vs. acquire load triggers a KCSAN data race report between concurrent directory modification and stat syscalls.
▶
▼
✨ Full AI root cause analysis
Root Cause Analysis
Involved Functions, Structs, and Files
- Files:
- Functions:
- Structs & Fields:
struct inode::i_size (loff_t)
struct inode::i_size_seqcount (seqcount_t, on 32-bit SMP architectures)
Technical Mechanism & Failure Chain
-
Lockless Reader Path (generic_fillattr / i_size_read):
- When user space invokes
newfstatat(2) / statx(2), the VFS path executes vfs_getattr_nosec() $\to$ inode->i_op->getattr() (shmem_getattr()), which delegates to generic_fillattr().
generic_fillattr() does not hold directory mutexes (inode->i_rwsem) and fetches the inode size via stat->size = i_size_read(inode).
- On 64-bit architectures,
i_size_read() relies on smp_load_acquire(&inode->i_size) to pair with smp_store_release() in i_size_write(). On 32-bit SMP architectures, i_size_read() loops reading inode->i_size_seqcount to prevent reading torn 32-bit halves of the 64-bit loff_t.
-
Unmarked Concurrent Writer Path (shmem_unlink):
-
Concurrency Invariant Violation:
- The kernel concurrency protocol requires updates to
inode->i_size that can race with lockless readers using i_size_read() to be executed through i_size_write(inode, new_size).
- Because
shmem_unlink() performs a plain, unmarked store to dir->i_size without smp_store_release() / i_size_write(), KCSAN detects a data race between the marked load in i_size_read() and the unmarked read-modify-write in shmem_unlink().
Sample crash report:
* Struck through repros no longer work on HEAD.