syzbot

loop0: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc3-syzkaller-g573067a5a685 #0 Not tainted
------------------------------------------------------
syz-executor125/6450 is trying to acquire lock:
ffff0000cec908f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_allocate+0x8c/0x728 fs/hfsplus/bitmap.c:35

but task is already holding lock:
ffff0000cead4488 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:458

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}:
       __mutex_lock_common+0x218/0x28f4 kernel/locking/mutex.c:585
       __mutex_lock kernel/locking/mutex.c:735 [inline]
       mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:787
       hfsplus_get_block+0x2c4/0x1168 fs/hfsplus/extents.c:260
       block_read_full_folio+0x368/0x914 fs/buffer.c:2396
       hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28
       filemap_read_folio+0x108/0x318 mm/filemap.c:2366
       do_read_cache_folio+0x368/0x5c0 mm/filemap.c:3826
       do_read_cache_page mm/filemap.c:3892 [inline]
       read_cache_page+0x6c/0x15c mm/filemap.c:3901
       read_mapping_page include/linux/pagemap.h:1005 [inline]
       hfsplus_block_allocate+0xe4/0x728 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0x7b4/0x1544 fs/hfsplus/extents.c:469
       hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x4c4/0x1610 fs/buffer.c:2116
       block_write_begin fs/buffer.c:2226 [inline]
       cont_write_begin+0x634/0x984 fs/buffer.c:2577
       hfsplus_write_begin+0x7c/0xc4 fs/hfsplus/inode.c:46
       generic_perform_write+0x29c/0x868 mm/filemap.c:4055
       __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4156
       generic_file_write_iter+0xb8/0x2b4 mm/filemap.c:4182
       new_sync_write fs/read_write.c:586 [inline]
       vfs_write+0x920/0xcf4 fs/read_write.c:679
       ksys_write+0x15c/0x26c fs/read_write.c:731
       __do_sys_write fs/read_write.c:742 [inline]
       __se_sys_write fs/read_write.c:739 [inline]
       __arm64_sys_write+0x7c/0x90 fs/read_write.c:739
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #0 (&sbi->alloc_mutex){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain kernel/locking/lockdep.c:3904 [inline]
       __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226
       lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849
       __mutex_lock_common+0x218/0x28f4 kernel/locking/mutex.c:585
       __mutex_lock kernel/locking/mutex.c:735 [inline]
       mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:787
       hfsplus_block_allocate+0x8c/0x728 fs/hfsplus/bitmap.c:35
       hfsplus_file_extend+0x7b4/0x1544 fs/hfsplus/extents.c:469
       hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358
       hfsplus_create_cat+0x18c/0x132c fs/hfsplus/catalog.c:272
       hfsplus_fill_super+0xf9c/0x16f8 fs/hfsplus/super.c:561
       get_tree_bdev_flags+0x38c/0x494 fs/super.c:1636
       get_tree_bdev+0x2c/0x3c fs/super.c:1659
       hfsplus_get_tree+0x28/0x38 fs/hfsplus/super.c:640
       vfs_get_tree+0x90/0x28c fs/super.c:1814
       do_new_mount+0x278/0x900 fs/namespace.c:3507
       path_mount+0x590/0xe04 fs/namespace.c:3834
       do_mount fs/namespace.c:3847 [inline]
       __do_sys_mount fs/namespace.c:4057 [inline]
       __se_sys_mount fs/namespace.c:4034 [inline]
       __arm64_sys_mount+0x4d4/0x5ac fs/namespace.c:4034
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

4 locks held by syz-executor125/6450:
 #0: ffff0000d08ee0e0 (&type->s_umount_key#42/1){+.+.}-{4:4}, at: alloc_super+0x1b0/0x834 fs/super.c:344
 #1: ffff0000cec90998 (&sbi->vh_mutex){+.+.}-{4:4}, at: hfsplus_fill_super+0xf40/0x16f8 fs/hfsplus/super.c:554
 #2: ffff0000cfcba0b0 (&tree->tree_lock){+.+.}-{4:4}, at: hfsplus_find_init+0x144/0x1bc fs/hfsplus/bfind.c:28
 #3: ffff0000cead4488 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:458

stack backtrace:
CPU: 1 UID: 0 PID: 6450 Comm: syz-executor125 Not tainted 6.13.0-rc3-syzkaller-g573067a5a685 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call trace:
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C)
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120
 dump_stack+0x1c/0x28 lib/dump_stack.c:129
 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2074
 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain kernel/locking/lockdep.c:3904 [inline]
 __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226
 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849
 __mutex_lock_common+0x218/0x28f4 kernel/locking/mutex.c:585
 __mutex_lock kernel/locking/mutex.c:735 [inline]
 mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:787
 hfsplus_block_allocate+0x8c/0x728 fs/hfsplus/bitmap.c:35
 hfsplus_file_extend+0x7b4/0x1544 fs/hfsplus/extents.c:469
 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358
 hfsplus_create_cat+0x18c/0x132c fs/hfsplus/catalog.c:272
 hfsplus_fill_super+0xf9c/0x16f8 fs/hfsplus/super.c:561
 get_tree_bdev_flags+0x38c/0x494 fs/super.c:1636
 get_tree_bdev+0x2c/0x3c fs/super.c:1659
 hfsplus_get_tree+0x28/0x38 fs/hfsplus/super.c:640
 vfs_get_tree+0x90/0x28c fs/super.c:1814
 do_new_mount+0x278/0x900 fs/namespace.c:3507
 path_mount+0x590/0xe04 fs/namespace.c:3834
 do_mount fs/namespace.c:3847 [inline]
 __do_sys_mount fs/namespace.c:4057 [inline]
 __se_sys_mount fs/namespace.c:4034 [inline]
 __arm64_sys_mount+0x4d4/0x5ac fs/namespace.c:4034
 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600
hfsplus: xattr search failed