syzbot

JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,3) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.3.82/6542 is trying to acquire lock:
ffff888060876c50 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x201/0x290 fs/ocfs2/quota_global.c:314

but task is already holding lock:
ffff888060877000 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
ffff888060877000 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1da/0x290 fs/ocfs2/quota_global.c:313

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_lock_global_qf+0x1da/0x290 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2a0/0xb70 fs/ocfs2/quota_global.c:828
       dqget+0x7b6/0xf10 fs/quota/dquot.c:980
       __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0xa67/0x2290 fs/ocfs2/namei.c:314
       ocfs2_mkdir+0x181/0x490 fs/ocfs2/namei.c:660
       vfs_mkdir+0x40b/0x630 fs/namei.c:5233
       filename_mkdirat+0x289/0x520 fs/namei.c:5266
       __do_sys_mkdir fs/namei.c:5293 [inline]
       __se_sys_mkdir+0x34/0x150 fs/namei.c:5290
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&dquot->dq_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/rtmutex_api.c:533 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:552
       wait_on_dquot fs/quota/dquot.c:357 [inline]
       dqget+0x72f/0xf10 fs/quota/dquot.c:975
       __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0xa67/0x2290 fs/ocfs2/namei.c:314
       ocfs2_mkdir+0x181/0x490 fs/ocfs2/namei.c:660
       vfs_mkdir+0x40b/0x630 fs/namei.c:5233
       filename_mkdirat+0x289/0x520 fs/namei.c:5266
       __do_sys_mkdir fs/namei.c:5293 [inline]
       __se_sys_mkdir+0x34/0x150 fs/namei.c:5290
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:733 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:896 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1539/0x44c0 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:846
       ocfs2_dentry_iput+0x24d/0x390 fs/ocfs2/dcache.c:407
       __dentry_kill+0x1a2/0x5e0 fs/dcache.c:670
       finish_dput+0xc9/0x480 fs/dcache.c:879
       end_renaming fs/namei.c:4096 [inline]
       filename_renameat2+0x61e/0x9c0 fs/namei.c:6146
       __do_sys_renameat2 fs/namei.c:6173 [inline]
       __se_sys_renameat2+0x5a/0x2c0 fs/namei.c:6168
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_del_inode_from_orphan+0x12e/0x7a0 fs/ocfs2/namei.c:2731
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2305 [inline]
       ocfs2_dio_end_io+0x545/0x1210 fs/ocfs2/aops.c:2403
       dio_complete+0x25e/0x790 fs/direct-io.c:281
       __blockdev_direct_IO+0x2d0e/0x3330 fs/direct-io.c:1303
       ocfs2_direct_IO+0x253/0x2c0 fs/ocfs2/aops.c:2440
       generic_file_direct_write+0x1dc/0x3e0 mm/filemap.c:4253
       __generic_file_write_iter+0x120/0x240 mm/filemap.c:4422
       ocfs2_file_write_iter+0x1666/0x1ed0 fs/ocfs2/file.c:2476
       iter_file_splice_write+0x9a6/0x10f0 fs/splice.c:736
       do_splice_from fs/splice.c:936 [inline]
       direct_splice_actor+0x104/0x160 fs/splice.c:1159
       splice_direct_to_actor+0x545/0xc80 fs/splice.c:1103
       do_splice_direct_actor fs/splice.c:1202 [inline]
       do_splice_direct+0x19b/0x2a0 fs/splice.c:1228
       do_sendfile+0x547/0x7e0 fs/read_write.c:1372
       __do_sys_sendfile64 fs/read_write.c:1433 [inline]
       __se_sys_sendfile64+0x144/0x1a0 fs/read_write.c:1419
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       ocfs2_lock_global_qf+0x201/0x290 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2a0/0xb70 fs/ocfs2/quota_global.c:828
       dqget+0x7b6/0xf10 fs/quota/dquot.c:980
       __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
       ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
       ocfs2_mknod+0xa67/0x2290 fs/ocfs2/namei.c:314
       ocfs2_mkdir+0x181/0x490 fs/ocfs2/namei.c:660
       vfs_mkdir+0x40b/0x630 fs/namei.c:5233
       filename_mkdirat+0x289/0x520 fs/namei.c:5266
       __do_sys_mkdir fs/namei.c:5293 [inline]
       __se_sys_mkdir+0x34/0x150 fs/namei.c:5290
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]);
  lock(&ocfs2_quota_ip_alloc_sem_key);

 *** DEADLOCK ***

5 locks held by syz.3.82/6542:
 #0: ffff888025cf4480 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:493
 #1: ffff888060a23dc0 (&type->i_mutex_dir_key#15/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1073 [inline]
 #1: ffff888060a23dc0 (&type->i_mutex_dir_key#15/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2923 [inline]
 #1: ffff888060a23dc0 (&type->i_mutex_dir_key#15/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2934 [inline]
 #1: ffff888060a23dc0 (&type->i_mutex_dir_key#15/1){+.+.}-{4:4}, at: filename_create+0x200/0x370 fs/namei.c:4922
 #2: ffff8880625c7000 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #2: ffff8880625c7000 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16a/0x4940 fs/ocfs2/suballoc.c:857
 #3: ffff888060b68818 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x293/0xb70 fs/ocfs2/quota_global.c:823
 #4: ffff888060877000 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #4: ffff888060877000 (&ocfs2_sysfile_lock_key[USER_QUOTA_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1da/0x290 fs/ocfs2/quota_global.c:313

stack backtrace:
CPU: 0 UID: 0 PID: 6542 Comm: syz.3.82 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
 ocfs2_lock_global_qf+0x201/0x290 fs/ocfs2/quota_global.c:314
 ocfs2_acquire_dquot+0x2a0/0xb70 fs/ocfs2/quota_global.c:828
 dqget+0x7b6/0xf10 fs/quota/dquot.c:980
 __dquot_initialize+0x3ba/0xd30 fs/quota/dquot.c:1508
 ocfs2_get_init_inode+0x147/0x1c0 fs/ocfs2/namei.c:206
 ocfs2_mknod+0xa67/0x2290 fs/ocfs2/namei.c:314
 ocfs2_mkdir+0x181/0x490 fs/ocfs2/namei.c:660
 vfs_mkdir+0x40b/0x630 fs/namei.c:5233
 filename_mkdirat+0x289/0x520 fs/namei.c:5266
 __do_sys_mkdir fs/namei.c:5293 [inline]
 __se_sys_mkdir+0x34/0x150 fs/namei.c:5290
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f621dfec799
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f621c23e028 EFLAGS: 00000246 ORIG_RAX: 0000000000000053
RAX: ffffffffffffffda RBX: 00007f621e265fa0 RCX: 00007f621dfec799
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000200000000400
RBP: 00007f621e082c99 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f621e266038 R14: 00007f621e265fa0 R15: 00007ffe41e0a568
 </TASK>
(syz.3.82,6542,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x438, computed 0x1cec3d0f. Applying ECC.
(syz.3.82,6542,1):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x438, computed 0x1cec3d0f
(syz.3.82,6542,1):ocfs2_read_quota_phys_block:160 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_quota_read:201 ERROR: status = -5
Quota error (device loop3): find_tree_dqentry: Can't read quota tree block 4
Quota error (device loop3): qtree_read_dquot: Can't read quota structure for id 0
(syz.3.82,6542,1):ocfs2_acquire_dquot:890 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mknod:318 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mknod:506 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mkdir:662 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x438, computed 0x1cec3d0f. Applying ECC.
(syz.3.82,6542,1):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x438, computed 0x1cec3d0f
(syz.3.82,6542,1):ocfs2_read_quota_phys_block:160 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_quota_read:201 ERROR: status = -5
Quota error (device loop3): find_tree_dqentry: Can't read quota tree block 4
Quota error (device loop3): qtree_read_dquot: Can't read quota structure for id 0
(syz.3.82,6542,1):ocfs2_acquire_dquot:890 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mknod:318 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mknod:506 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mkdir:662 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x438, computed 0x1cec3d0f. Applying ECC.
(syz.3.82,6542,1):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x438, computed 0x1cec3d0f
(syz.3.82,6542,1):ocfs2_read_quota_phys_block:160 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_quota_read:201 ERROR: status = -5
Quota error (device loop3): find_tree_dqentry: Can't read quota tree block 4
Quota error (device loop3): qtree_read_dquot: Can't read quota structure for id 0
(syz.3.82,6542,1):ocfs2_acquire_dquot:890 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mknod:318 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mknod:506 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mkdir:662 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x438, computed 0x1cec3d0f. Applying ECC.
(syz.3.82,6542,1):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x438, computed 0x1cec3d0f
(syz.3.82,6542,1):ocfs2_read_quota_phys_block:160 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_quota_read:201 ERROR: status = -5
Quota error (device loop3): find_tree_dqentry: Can't read quota tree block 4
Quota error (device loop3): qtree_read_dquot: Can't read quota structure for id 0
(syz.3.82,6542,1):ocfs2_acquire_dquot:890 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mknod:318 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mknod:506 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_mkdir:662 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x438, computed 0x1cec3d0f. Applying ECC.
(syz.3.82,6542,1):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x438, computed 0x1cec3d0f
(syz.3.82,6542,1):ocfs2_read_quota_phys_block:160 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_quota_read:201 ERROR: status = -5
Quota error (device loop3): find_tree_dqentry: Can't read quota tree block 4
Quota error (device loop3): qtree_read_dquot: Can't read quota structure for id 0
(syz.3.82,6542,1):ocfs2_acquire_dquot:890 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_symlink:1895 ERROR: status = -5
(syz.3.82,6542,1):ocfs2_symlink:2081 ERROR: status = -5