UBSAN: array-index-out-of-bounds in dbAdjTree

Status: fixed on 2025/01/22 14:58
Bug presence: origin:lts-only
[Documentation on labels]
Reported-by: syzbot+b15dcf65907dd581fb1c@syzkaller.appspotmail.com
Fix commit: a3d408870bc1 jfs: add a check to prevent array-index-out-of-bounds in dbAdjTree
First crash: 630d, last: 591d
Fix bisection: fixed by (bisect log) :
commit a3d408870bc19b794646871bc4c3a5daa66f91c5
Author: Nihar Chaithanya <niharchaithanya@gmail.com>
Date: Tue Oct 8 20:21:38 2024 +0000

  jfs: add a check to prevent array-index-out-of-bounds in dbAdjTree

  
▶ ▼ Bug presence (2)
Date Name Commit Repro Result
2024/12/12 linux-5.15.y (ToT) 0a51d2d4527b C [report] UBSAN: array-index-out-of-bounds in dbAdjTree
2024/12/12 upstream (ToT) 231825b2e1ff C Didn't crash
▶ ▼ Similar bugs (5)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream UBSAN: array-index-out-of-bounds in dbAdjTree jfs 15 C error error 41 922d 1400d 25/29 fixed on 2024/01/30 15:47
upstream UBSAN: array-index-out-of-bounds in dbAdjTree (2) jfs 15 C inconclusive 77 614d 800d 28/29 fixed on 2024/12/16 09:50
linux-6.1 UBSAN: array-index-out-of-bounds in dbAdjTree origin:lts-only 15 C done 4 592d 595d 0/3 upstream: reported C repro on 2024/12/09 11:51
linux-4.14 KASAN: slab-out-of-bounds Read in dbAdjTree 17 C 3 1246d 1393d 0/1 upstream: reported C repro on 2022/10/03 00:17
linux-4.19 KASAN: use-after-free Read in dbAdjTree 19 C error 5 1248d 1365d 0/1 upstream: reported C repro on 2022/10/31 14:16

Sample crash report:
================================================================================
UBSAN: array-index-out-of-bounds in fs/jfs/jfs_dmap.c:2968:18
index -3 is out of range for type 's8[1365]' (aka 'signed char[1365]')
CPU: 0 PID: 9439 Comm: syz.9.1360 Not tainted 5.15.173-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 ubsan_epilogue lib/ubsan.c:151 [inline]
 __ubsan_handle_out_of_bounds+0x118/0x140 lib/ubsan.c:282
 dbAdjTree+0x377/0x520 fs/jfs/jfs_dmap.c:2968
 dbAllocBits+0x4e5/0x9a0 fs/jfs/jfs_dmap.c:2259
 dbAllocDmap+0x6d/0x150 fs/jfs/jfs_dmap.c:2100
 dbAlloc+0x505/0xc90 fs/jfs/jfs_dmap.c:816
 extBalloc fs/jfs/jfs_extent.c:523 [inline]
 extAlloc+0x4f4/0x1000 fs/jfs/jfs_extent.c:125
 jfs_get_block+0x417/0xe50 fs/jfs/inode.c:258
 nobh_write_begin+0x398/0xda0 fs/buffer.c:2650
 jfs_write_begin+0x3e/0x80 fs/jfs/inode.c:322
 generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785
 __generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912
 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944
 call_write_iter include/linux/fs.h:2174 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0xacd/0xe50 fs/read_write.c:594
 ksys_write+0x1a2/0x2c0 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f1213944d19
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f12117b5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f1213b34fa0 RCX: 00007f1213944d19
RDX: 00000000fffffcf8 RSI: 0000000020000000 RDI: 0000000000000004
RBP: 00007f12139c0a20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f1213b34fa0 R15: 00007ffeb37dd428
 </TASK>
================================================================================

Crashes (7):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/12/13 08:04 linux-5.15.y 0a51d2d4527b 3547e30f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan UBSAN: array-index-out-of-bounds in dbAdjTree
2024/12/13 08:04 linux-5.15.y 0a51d2d4527b 3547e30f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan UBSAN: array-index-out-of-bounds in dbAdjTree
2024/12/13 08:03 linux-5.15.y 0a51d2d4527b 3547e30f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan UBSAN: array-index-out-of-bounds in dbAdjTree
2024/12/12 15:32 linux-5.15.y 0a51d2d4527b 530e80f8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan UBSAN: array-index-out-of-bounds in dbAdjTree
2024/12/11 23:23 linux-5.15.y 0a51d2d4527b ff949d25 .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan UBSAN: array-index-out-of-bounds in dbAdjTree
2024/12/11 13:33 linux-5.15.y 0a51d2d4527b ff949d25 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan UBSAN: array-index-out-of-bounds in dbAdjTree
2024/11/04 07:07 linux-5.15.y 72244eab0dad f00eed24 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan UBSAN: array-index-out-of-bounds in dbAdjTree
* Struck through repros no longer work on HEAD.