UBSAN: shift-out-of-bounds in strset_parse_request

Status: fixed on 2021/03/10 01:48
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+96523fb438937cd01220@syzkaller.appspotmail.com
Fix commit: efb796f5571f ethtool: fix string set id check
First crash: 2076d, last: 2049d
Cause bisection: introduced by (bisect log) :
commit 71921690f9745fef60a2bad425f30adf8cdc9da0
Author: Michal Kubecek <mkubecek@suse.cz>
Date: Fri Dec 27 14:55:43 2019 +0000

  ethtool: provide string sets with STRSET_GET request

Crash: UBSAN: undefined-behaviour in strset_parse_request (log)
Repro: C syz .config
  
▶ ▼ Discussions (3)
Title Replies (including bot) Last reply
[PATCH 5.10 00/63] 5.10.5-rc1 review 75 (75) 2021/01/07 08:13
[PATCH net] ethtool: fix string set id check 2 (2) 2020/12/16 19:20
UBSAN: shift-out-of-bounds in strset_parse_request 0 (1) 2020/12/13 11:13

Sample crash report:
================================================================================
UBSAN: shift-out-of-bounds in net/ethtool/strset.c:191:28
shift exponent 3476603555 is too large for 32-bit type 'unsigned int'
CPU: 1 PID: 8488 Comm: syz-executor226 Not tainted 5.10.0-rc7-next-20201208-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:79 [inline]
 dump_stack+0x107/0x163 lib/dump_stack.c:120
 ubsan_epilogue+0xb/0x5a lib/ubsan.c:148
 __ubsan_handle_shift_out_of_bounds.cold+0xb1/0x181 lib/ubsan.c:395
 strset_parse_request.cold+0x3b/0x40 net/ethtool/strset.c:191
 ethnl_default_parse+0xda/0x130 net/ethtool/netlink.c:282
 ethnl_default_start+0x21c/0x570 net/ethtool/netlink.c:501
 genl_start+0x3cc/0x670 net/netlink/genetlink.c:604
 __netlink_dump_start+0x5a7/0x920 net/netlink/af_netlink.c:2363
 genl_family_rcv_msg_dumpit+0x1c9/0x310 net/netlink/genetlink.c:697
 genl_family_rcv_msg net/netlink/genetlink.c:780 [inline]
 genl_rcv_msg+0x43c/0x590 net/netlink/genetlink.c:800
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2494
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:811
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x907/0xe40 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2345
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2399
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2432
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x4409d9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 5b 11 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffc89faeb48 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004409d9
RDX: 0000000000000000 RSI: 0000000020000fc0 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 000000000000000c R09: 00000000004002c8
R10: 0000000000000001 R11: 0000000000000246 R12: 0000000000401fc0
R13: 0000000000402050 R14: 0000000000000000 R15: 0000000000000000
================================================================================

Crashes (16):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/12/09 11:26 linux-next a9e26cb5f261 40cc414d .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2021/01/05 21:13 net-next-old 3db1a3fa9880 a0234d98 .config console log report info ci-upstream-net-kasan-gce
2021/01/05 19:21 net-next-old 3db1a3fa9880 a0234d98 .config console log report info ci-upstream-net-kasan-gce
2021/01/05 09:36 net-next-old 3db1a3fa9880 2a28ff1f .config console log report info ci-upstream-net-kasan-gce
2021/01/05 03:48 net-next-old 3db1a3fa9880 2a28ff1f .config console log report info ci-upstream-net-kasan-gce
2021/01/02 18:36 net-next-old 3db1a3fa9880 79264ae3 .config console log report info ci-upstream-net-kasan-gce
2021/01/02 08:55 net-next-old 3db1a3fa9880 79264ae3 .config console log report info ci-upstream-net-kasan-gce
2021/01/02 08:23 net-next-old 3db1a3fa9880 79264ae3 .config console log report info ci-upstream-net-kasan-gce
2020/12/31 19:55 net-next-old 3db1a3fa9880 79264ae3 .config console log report info ci-upstream-net-kasan-gce
2020/12/31 12:51 net-next-old 3db1a3fa9880 5cc121d6 .config console log report info ci-upstream-net-kasan-gce
2020/12/31 05:42 net-next-old 3db1a3fa9880 5cc121d6 .config console log report info ci-upstream-net-kasan-gce
2020/12/30 11:17 net-next-old 3db1a3fa9880 0fa352f2 .config console log report info ci-upstream-net-kasan-gce
2020/12/29 21:52 net-next-old 3db1a3fa9880 80910769 .config console log report info ci-upstream-net-kasan-gce
2020/12/29 02:56 net-next-old 3db1a3fa9880 8259d56c .config console log report info ci-upstream-net-kasan-gce
2020/12/27 15:09 net-next-old 3db1a3fa9880 2242f77f .config console log report info ci-upstream-net-kasan-gce
2020/12/09 11:09 linux-next a9e26cb5f261 40cc414d .config console log report info ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.