======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.81/6122 is trying to acquire lock:
ffff88802ce04c58 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_writepages_down_read fs/ext4/ext4.h:1768 [inline]
ffff88802ce04c58 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_writepages+0x1a4/0x350 fs/ext4/inode.c:2808

but task is already holding lock:
ffff888073fb1ec8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:165 [inline]
ffff888073fb1ec8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:6030 [inline]
ffff888073fb1ec8 (&ei->xattr_sem){++++}-{3:3}, at: __ext4_mark_inode_dirty+0x3d3/0x6d0 fs/ext4/inode.c:6111

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ei->xattr_sem){++++}-{3:3}:
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       ext4_write_lock_xattr fs/ext4/xattr.h:158 [inline]
       ext4_destroy_inline_data+0x28/0xe0 fs/ext4/inline.c:1902
       ext4_do_writepages+0x4f2/0x3990 fs/ext4/inode.c:2606
       ext4_writepages+0x1dd/0x350 fs/ext4/inode.c:2809
       do_writepages+0x351/0x590 mm/page-writeback.c:2575
       filemap_fdatawrite_wbc+0x122/0x180 mm/filemap.c:390
       __filemap_fdatawrite_range mm/filemap.c:423 [inline]
       file_write_and_wait_range+0x197/0x280 mm/filemap.c:781
       generic_buffers_fsync_noflush+0x6f/0x160 fs/buffer.c:609
       ext4_fsync_nojournal fs/ext4/fsync.c:92 [inline]
       ext4_sync_file+0x460/0xd50 fs/ext4/fsync.c:163
       generic_write_sync include/linux/fs.h:2664 [inline]
       ext4_buffered_write_iter+0x2c0/0x350 fs/ext4/file.c:305
       ext4_file_write_iter+0x1e7/0x1980 fs/ext4/file.c:-1
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x747/0xc50 fs/read_write.c:860
       vfs_writev fs/read_write.c:933 [inline]
       do_pwritev+0x242/0x3a0 fs/read_write.c:1030
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
       ext4_writepages_down_read fs/ext4/ext4.h:1768 [inline]
       ext4_writepages+0x1a4/0x350 fs/ext4/inode.c:2808
       do_writepages+0x351/0x590 mm/page-writeback.c:2575
       __writeback_single_inode+0x14e/0xee0 fs/fs-writeback.c:1635
       writeback_single_inode+0x21f/0x760 fs/fs-writeback.c:1756
       write_inode_now+0x183/0x210 fs/fs-writeback.c:2808
       iput_final fs/inode.c:1807 [inline]
       iput+0x58f/0x900 fs/inode.c:1846
       ext4_xattr_block_set+0x248b/0x2fe0 fs/ext4/xattr.c:2201
       ext4_xattr_move_to_block fs/ext4/xattr.c:2666 [inline]
       ext4_xattr_make_inode_space fs/ext4/xattr.c:2741 [inline]
       ext4_expand_extra_isize_ea+0x128f/0x1e70 fs/ext4/xattr.c:2829
       __ext4_expand_extra_isize+0x306/0x400 fs/ext4/inode.c:5990
       ext4_try_to_expand_extra_isize fs/ext4/inode.c:6033 [inline]
       __ext4_mark_inode_dirty+0x458/0x6d0 fs/ext4/inode.c:6111
       ext4_evict_inode+0x7dd/0xe70 fs/ext4/inode.c:254
       evict+0x4b7/0x8a0 fs/inode.c:705
       ext4_orphan_cleanup+0xc33/0x1470 fs/ext4/orphan.c:472
       __ext4_fill_super fs/ext4/super.c:5621 [inline]
       ext4_fill_super+0x5fb5/0x6870 fs/ext4/super.c:5744
       get_tree_bdev+0x3e5/0x520 fs/super.c:1591
       vfs_get_tree+0x8c/0x280 fs/super.c:1764
       do_new_mount+0x24a/0xa40 fs/namespace.c:3386
       do_mount fs/namespace.c:3726 [inline]
       __do_sys_mount fs/namespace.c:3935 [inline]
       __se_sys_mount+0x2e7/0x3d0 fs/namespace.c:3912
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->xattr_sem);
                               lock(&sbi->s_writepages_rwsem);
                               lock(&ei->xattr_sem);
  rlock(&sbi->s_writepages_rwsem);

 *** DEADLOCK ***

3 locks held by syz.0.81/6122:
 #0: ffff88802ce020e0 (&type->s_umount_key#31){++++}-{3:3}, at: __super_lock fs/super.c:56 [inline]
 #0: ffff88802ce020e0 (&type->s_umount_key#31){++++}-{3:3}, at: __super_lock_excl fs/super.c:71 [inline]
 #0: ffff88802ce020e0 (&type->s_umount_key#31){++++}-{3:3}, at: get_tree_bdev+0x345/0x520 fs/super.c:1589
 #1: ffff88802ce02608 (sb_internal){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1633 [inline]
 #1: ffff88802ce02608 (sb_internal){.+.+}-{0:0}, at: sb_start_intwrite include/linux/fs.h:1755 [inline]
 #1: ffff88802ce02608 (sb_internal){.+.+}-{0:0}, at: ext4_evict_inode+0x2b4/0xe70 fs/ext4/inode.c:215
 #2: ffff888073fb1ec8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:165 [inline]
 #2: ffff888073fb1ec8 (&ei->xattr_sem){++++}-{3:3}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:6030 [inline]
 #2: ffff888073fb1ec8 (&ei->xattr_sem){++++}-{3:3}, at: __ext4_mark_inode_dirty+0x3d3/0x6d0 fs/ext4/inode.c:6111

stack backtrace:
CPU: 0 PID: 6122 Comm: syz.0.81 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x37ef/0x7d80 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
 ext4_writepages_down_read fs/ext4/ext4.h:1768 [inline]
 ext4_writepages+0x1a4/0x350 fs/ext4/inode.c:2808
 do_writepages+0x351/0x590 mm/page-writeback.c:2575
 __writeback_single_inode+0x14e/0xee0 fs/fs-writeback.c:1635
 writeback_single_inode+0x21f/0x760 fs/fs-writeback.c:1756
 write_inode_now+0x183/0x210 fs/fs-writeback.c:2808
 iput_final fs/inode.c:1807 [inline]
 iput+0x58f/0x900 fs/inode.c:1846
 ext4_xattr_block_set+0x248b/0x2fe0 fs/ext4/xattr.c:2201
 ext4_xattr_move_to_block fs/ext4/xattr.c:2666 [inline]
 ext4_xattr_make_inode_space fs/ext4/xattr.c:2741 [inline]
 ext4_expand_extra_isize_ea+0x128f/0x1e70 fs/ext4/xattr.c:2829
 __ext4_expand_extra_isize+0x306/0x400 fs/ext4/inode.c:5990
 ext4_try_to_expand_extra_isize fs/ext4/inode.c:6033 [inline]
 __ext4_mark_inode_dirty+0x458/0x6d0 fs/ext4/inode.c:6111
 ext4_evict_inode+0x7dd/0xe70 fs/ext4/inode.c:254
 evict+0x4b7/0x8a0 fs/inode.c:705
 ext4_orphan_cleanup+0xc33/0x1470 fs/ext4/orphan.c:472
 __ext4_fill_super fs/ext4/super.c:5621 [inline]
 ext4_fill_super+0x5fb5/0x6870 fs/ext4/super.c:5744
 get_tree_bdev+0x3e5/0x520 fs/super.c:1591
 vfs_get_tree+0x8c/0x280 fs/super.c:1764
 do_new_mount+0x24a/0xa40 fs/namespace.c:3386
 do_mount fs/namespace.c:3726 [inline]
 __do_sys_mount fs/namespace.c:3935 [inline]
 __se_sys_mount+0x2e7/0x3d0 fs/namespace.c:3912
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f3ab859f0ca
Code: 48 c7 c2 e8 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc40d1d8c8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffc40d1d950 RCX: 00007f3ab859f0ca
RDX: 0000200000000240 RSI: 0000200000000000 RDI: 00007ffc40d1d910
RBP: 0000200000000240 R08: 00007ffc40d1d950 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000200000000000
R13: 00007ffc40d1d910 R14: 000000000000047a R15: 000000000000002c
 </TASK>
EXT4-fs error (device loop0): ext4_xattr_inode_iget:441: inode #11: comm syz.0.81: iget: bad extra_isize 90 (inode size 256)
EXT4-fs (loop0): Remounting filesystem read-only
EXT4-fs warning (device loop0): ext4_expand_extra_isize_ea:2855: Unable to expand inode 15. Delete some EAs or run e2fsck.
EXT4-fs warning (device loop0): ext4_evict_inode:257: couldn't mark inode dirty (err -5)
EXT4-fs (loop0): 1 orphan inode deleted