KASAN: vmalloc-out-of-bounds Read in tipc_nl_node_dump_monitor_peer

Status: fixed on 2020/07/20 08:03
Subsystems: tipc
[Documentation on labels]
Reported-by: syzbot+80cad1e3cb4c41cde6ff@syzkaller.appspotmail.com
Fix commit: bf64ff4c2aac genetlink: get rid of family->attrbuf
First crash: 2228d, last: 2210d
Cause bisection: failed (error log, bisect log)
  
▶ ▼ Discussions (3)
Title Replies (including bot) Last reply
[PATCH 5.7 000/244] 5.7.10-rc1 review 256 (256) 2020/07/27 17:31
[Patch net] genetlink: get rid of family->attrbuf 2 (2) 2020/06/30 00:16
KASAN: vmalloc-out-of-bounds Read in tipc_nl_node_dump_monitor_peer 0 (1) 2020/06/23 16:56
▶ ▼ Last patch testing requests (2)
Created Duration User Patch Repo Result
2020/06/26 23:44 19m xiyou.wangcong@gmail.com https://github.com/congwang/linux.git net OK
2020/06/25 02:29 10m xiyou.wangcong@gmail.com https://github.com/congwang/linux.git net report log

Sample crash report:
netlink: 6 bytes leftover after parsing attributes in process `syz-executor368'.
==================================================================
BUG: KASAN: vmalloc-out-of-bounds in nla_len include/net/netlink.h:1135 [inline]
BUG: KASAN: vmalloc-out-of-bounds in nla_parse_nested_deprecated include/net/netlink.h:1218 [inline]
BUG: KASAN: vmalloc-out-of-bounds in tipc_nl_node_dump_monitor_peer+0x4da/0x590 net/tipc/node.c:2788
Read of size 2 at addr ffffc90001da5024 by task syz-executor368/6914

CPU: 0 PID: 6914 Comm: syz-executor368 Not tainted 5.8.0-rc1-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0x5/0x436 mm/kasan/report.c:383
 __kasan_report mm/kasan/report.c:513 [inline]
 kasan_report.cold+0x1f/0x37 mm/kasan/report.c:530
 nla_len include/net/netlink.h:1135 [inline]
 nla_parse_nested_deprecated include/net/netlink.h:1218 [inline]
 tipc_nl_node_dump_monitor_peer+0x4da/0x590 net/tipc/node.c:2788
 genl_lock_dumpit+0x7f/0xb0 net/netlink/genetlink.c:575
 netlink_dump+0x4cd/0xf60 net/netlink/af_netlink.c:2245
 __netlink_dump_start+0x643/0x900 net/netlink/af_netlink.c:2353
 genl_family_rcv_msg_dumpit+0x2ac/0x310 net/netlink/genetlink.c:638
 genl_family_rcv_msg net/netlink/genetlink.c:733 [inline]
 genl_rcv_msg+0x797/0x9e0 net/netlink/genetlink.c:753
 netlink_rcv_skb+0x15a/0x430 net/netlink/af_netlink.c:2469
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:764
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2352
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2406
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2439
 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:359
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x441919
Code: Bad RIP value.
RSP: 002b:00007ffe76aa2628 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000441919
RDX: 0000000000000000 RSI: 0000000020000000 RDI: 0000000000000003
RBP: 0000000000010058 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000004 R11: 0000000000000246 R12: 0000000000402730
R13: 00000000004027c0 R14: 0000000000000000 R15: 0000000000000000


Memory state around the buggy address:
 ffffc90001da4f00: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
 ffffc90001da4f80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
>ffffc90001da5000: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
                               ^
 ffffc90001da5080: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
 ffffc90001da5100: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9
==================================================================

Crashes (9):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/06/23 17:05 net-old b835a71ef64a 54566aff .config console log report syz C ci-upstream-net-this-kasan-gce
2020/06/23 12:21 bpf 4e15507fea70 54566aff .config console log report syz C ci-upstream-bpf-kasan-gce
2020/07/01 02:07 bpf 2bdeb3ed547d 917afeaa .config console log report ci-upstream-bpf-kasan-gce
2020/06/30 11:52 bpf 7a64135f3229 a2cdad9d .config console log report ci-upstream-bpf-kasan-gce
2020/06/30 08:30 bpf 7a64135f3229 a2cdad9d .config console log report ci-upstream-bpf-kasan-gce
2020/06/29 23:00 bpf 7a64135f3229 a2cdad9d .config console log report ci-upstream-bpf-kasan-gce
2020/06/23 12:06 bpf 4e15507fea70 54566aff .config console log report ci-upstream-bpf-kasan-gce
2020/07/11 18:10 bpf-next eef8a42d6ce0 18d18b59 .config console log report ci-upstream-bpf-next-kasan-gce
2020/07/11 13:42 bpf-next eef8a42d6ce0 18d18b59 .config console log report ci-upstream-bpf-next-kasan-gce
* Struck through repros no longer work on HEAD.