syzbot

ocfs2: Mounting device (7,4) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Tainted: G             L     
------------------------------------------------------
syz.4.2944/20177 is trying to acquire lock:
ffff888050e69538 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_calc_xattr_init+0x20a/0xd90 fs/ocfs2/xattr.c:631

but task is already holding lock:
ffff888050e6b480 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
ffff888050e6b480 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16f/0x4790 fs/ocfs2/suballoc.c:789

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1027 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:733 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:896 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1539/0x42e0 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:837
       ocfs2_dentry_iput+0x24d/0x390 fs/ocfs2/dcache.c:407
       __dentry_kill+0x1a2/0x5e0 fs/dcache.c:670
       finish_dput+0xc9/0x480 fs/dcache.c:879
       ovl_check_rename_whiteout fs/overlayfs/super.c:622 [inline]
       ovl_make_workdir fs/overlayfs/super.c:717 [inline]
       ovl_get_workdir fs/overlayfs/super.c:840 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
       ovl_fill_super+0x49b5/0x5e60 fs/overlayfs/super.c:1567
       vfs_get_super fs/super.c:1324 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1343
       vfs_get_tree+0x92/0x2a0 fs/super.c:1751
       fc_mount fs/namespace.c:1199 [inline]
       do_new_mount_fc fs/namespace.c:3636 [inline]
       do_new_mount+0x329/0xa50 fs/namespace.c:3712
       do_mount fs/namespace.c:4035 [inline]
       __do_sys_mount fs/namespace.c:4224 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4201
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1027 [inline]
       ocfs2_del_inode_from_orphan+0x12e/0x7a0 fs/ocfs2/namei.c:2731
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2306 [inline]
       ocfs2_dio_end_io+0x543/0x1210 fs/ocfs2/aops.c:2404
       dio_complete+0x25b/0x790 fs/direct-io.c:281
       __blockdev_direct_IO+0x2cb0/0x32f0 fs/direct-io.c:1303
       ocfs2_direct_IO+0x251/0x2c0 fs/ocfs2/aops.c:2441
       generic_file_direct_write+0x1db/0x3e0 mm/filemap.c:4248
       __generic_file_write_iter+0x11d/0x230 mm/filemap.c:4417
       ocfs2_file_write_iter+0x1663/0x1e20 fs/ocfs2/file.c:2475
       iter_file_splice_write+0x99b/0x1100 fs/splice.c:738
       do_splice_from fs/splice.c:938 [inline]
       direct_splice_actor+0x101/0x160 fs/splice.c:1161
       splice_direct_to_actor+0x53a/0xc70 fs/splice.c:1105
       do_splice_direct_actor fs/splice.c:1204 [inline]
       do_splice_direct+0x195/0x290 fs/splice.c:1230
       do_sendfile+0x535/0x7d0 fs/read_write.c:1370
       __do_sys_sendfile64 fs/read_write.c:1431 [inline]
       __se_sys_sendfile64+0x144/0x1a0 fs/read_write.c:1417
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&oi->ip_alloc_sem){++++}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       ocfs2_try_remove_refcount_tree+0xb6/0x340 fs/ocfs2/refcounttree.c:933
       ocfs2_xattr_set+0x61a/0x13e0 fs/ocfs2/xattr.c:3699
       __vfs_removexattr+0x431/0x470 fs/xattr.c:518
       __vfs_removexattr_locked+0x1e8/0x230 fs/xattr.c:553
       vfs_removexattr+0x80/0x1b0 fs/xattr.c:575
       ovl_do_removexattr fs/overlayfs/overlayfs.h:335 [inline]
       ovl_removexattr fs/overlayfs/overlayfs.h:343 [inline]
       ovl_make_workdir fs/overlayfs/super.c:760 [inline]
       ovl_get_workdir fs/overlayfs/super.c:840 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
       ovl_fill_super+0x4c39/0x5e60 fs/overlayfs/super.c:1567
       vfs_get_super fs/super.c:1324 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1343
       vfs_get_tree+0x92/0x2a0 fs/super.c:1751
       fc_mount fs/namespace.c:1199 [inline]
       do_new_mount_fc fs/namespace.c:3636 [inline]
       do_new_mount+0x329/0xa50 fs/namespace.c:3712
       do_mount fs/namespace.c:4035 [inline]
       __do_sys_mount fs/namespace.c:4224 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4201
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868
       down_read+0x47/0x2e0 kernel/locking/rwsem.c:1537
       ocfs2_calc_xattr_init+0x20a/0xd90 fs/ocfs2/xattr.c:631
       ocfs2_mknod+0xd07/0x2210 fs/ocfs2/namei.c:334
       ocfs2_mkdir+0x181/0x430 fs/ocfs2/namei.c:660
       vfs_mkdir+0x753/0x870 fs/namei.c:5139
       do_mkdirat+0x27d/0x4b0 fs/namei.c:5173
       __do_sys_mkdir fs/namei.c:5200 [inline]
       __se_sys_mkdir fs/namei.c:5198 [inline]
       __x64_sys_mkdir+0x6c/0x80 fs/namei.c:5198
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE] --> &ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

3 locks held by syz.4.2944/20177:
 #0: ffff888020a8a420 (sb_writers#33){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:499
 #1: ffff888050e69800 (&type->i_mutex_dir_key#25/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1072 [inline]
 #1: ffff888050e69800 (&type->i_mutex_dir_key#25/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2873 [inline]
 #1: ffff888050e69800 (&type->i_mutex_dir_key#25/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2884 [inline]
 #1: ffff888050e69800 (&type->i_mutex_dir_key#25/1){+.+.}-{4:4}, at: filename_create+0x200/0x370 fs/namei.c:4888
 #2: ffff888050e6b480 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #2: ffff888050e6b480 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16f/0x4790 fs/ocfs2/suballoc.c:789

stack backtrace:
CPU: 1 UID: 0 PID: 20177 Comm: syz.4.2944 Tainted: G             L      syzkaller #0 PREEMPT(full) 
Tainted: [L]=SOFTLOCKUP
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868
 down_read+0x47/0x2e0 kernel/locking/rwsem.c:1537
 ocfs2_calc_xattr_init+0x20a/0xd90 fs/ocfs2/xattr.c:631
 ocfs2_mknod+0xd07/0x2210 fs/ocfs2/namei.c:334
 ocfs2_mkdir+0x181/0x430 fs/ocfs2/namei.c:660
 vfs_mkdir+0x753/0x870 fs/namei.c:5139
 do_mkdirat+0x27d/0x4b0 fs/namei.c:5173
 __do_sys_mkdir fs/namei.c:5200 [inline]
 __se_sys_mkdir fs/namei.c:5198 [inline]
 __x64_sys_mkdir+0x6c/0x80 fs/namei.c:5198
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f890b39aeb9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f890c295028 EFLAGS: 00000246 ORIG_RAX: 0000000000000053
RAX: ffffffffffffffda RBX: 00007f890b615fa0 RCX: 00007f890b39aeb9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000200000000240
RBP: 00007f890b408c1f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f890b616038 R14: 00007f890b615fa0 R15: 00007ffce35dc5f8
 </TASK>