KASAN: use-after-free Read in hfsplus_release_folio

Status: fixed on 2023/06/08 14:41
Subsystems: hfs
[Documentation on labels]
Reported-by: syzbot+57e3e98f7e3b80f64d56@syzkaller.appspotmail.com
Fix commit: 07db5e247ab5 fs: hfsplus: fix UAF issue in hfsplus_put_super
First crash: 1322d, last: 1243d
Cause bisection: failed (error log, bisect log)
  
▶ ▼ Discussions (2)
Title Replies (including bot) Last reply
[PATCH] fs: hfsplus: Fix UAF issue in hfsplus_put_super 1 (1) 2023/02/26 12:49
[syzbot] KASAN: use-after-free Read in hfsplus_release_folio 0 (1) 2022/12/17 04:59
▶ ▼ Similar bugs (2)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 KASAN: use-after-free Read in hfsplus_release_folio 19 C done 2 1236d 1236d 3/3 fixed on 2023/04/11 15:30
upstream KASAN: slab-use-after-free Read in hfsplus_release_folio hfs 19 1 1043d 1039d 0/29 auto-obsoleted due to no activity on 2023/12/17 10:59
▶ ▼ Last patch testing requests (1)
Created Duration User Patch Repo Result
2023/02/23 05:28 19m mudongliangabcd@gmail.com patch upstream OK log

Sample crash report:
loop0: detected capacity change from 0 to 1024
==================================================================
BUG: KASAN: use-after-free in hfsplus_release_folio+0x554/0x5f0 fs/hfsplus/inode.c:92
Read of size 4 at addr ffff888029a36038 by task syz-executor327/5071

CPU: 1 PID: 5071 Comm: syz-executor327 Not tainted 6.1.0-syzkaller-13139-gf9ff5644bcc0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106
 print_address_description mm/kasan/report.c:306 [inline]
 print_report+0x15e/0x45d mm/kasan/report.c:417
 kasan_report+0xbf/0x1f0 mm/kasan/report.c:517
 hfsplus_release_folio+0x554/0x5f0 fs/hfsplus/inode.c:92
 filemap_release_folio+0x13f/0x1b0 mm/filemap.c:3967
 block_invalidate_folio+0x4dc/0x5e0 fs/buffer.c:1526
 folio_invalidate mm/truncate.c:159 [inline]
 truncate_cleanup_folio+0x31a/0x3f0 mm/truncate.c:179
 truncate_inode_pages_range+0x238/0xec0 mm/truncate.c:368
 hfsplus_evict_inode+0x1a/0xe0 fs/hfsplus/super.c:168
 evict+0x2ed/0x6b0 fs/inode.c:664
 iput_final fs/inode.c:1747 [inline]
 iput.part.0+0x59b/0x880 fs/inode.c:1773
 iput+0x5c/0x80 fs/inode.c:1763
 hfsplus_put_super+0x274/0x3f0 fs/hfsplus/super.c:302
 generic_shutdown_super+0x158/0x410 fs/super.c:492
 kill_block_super+0x9b/0xf0 fs/super.c:1386
 deactivate_locked_super+0x98/0x160 fs/super.c:332
 deactivate_super+0xb1/0xd0 fs/super.c:363
 cleanup_mnt+0x2ae/0x3d0 fs/namespace.c:1291
 task_work_run+0x16f/0x270 kernel/task_work.c:179
 exit_task_work include/linux/task_work.h:38 [inline]
 do_exit+0xaa8/0x2950 kernel/exit.c:867
 do_group_exit+0xd4/0x2a0 kernel/exit.c:1010
 __do_sys_exit_group kernel/exit.c:1021 [inline]
 __se_sys_exit_group kernel/exit.c:1019 [inline]
 __x64_sys_exit_group+0x3e/0x50 kernel/exit.c:1019
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fdd98031989
Code: Unable to access opcode bytes at 0x7fdd9803195f.
RSP: 002b:00007ffecf5eb6c8 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 00007fdd980a7330 RCX: 00007fdd98031989
RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000001
RBP: 0000000000000001 R08: ffffffffffffffc0 R09: 00000000000005f2
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fdd980a7330
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000001
 </TASK>

Allocated by task 5071:
 kasan_save_stack+0x22/0x40 mm/kasan/common.c:45
 kasan_set_track+0x25/0x30 mm/kasan/common.c:52
 ____kasan_kmalloc mm/kasan/common.c:371 [inline]
 ____kasan_kmalloc mm/kasan/common.c:330 [inline]
 __kasan_kmalloc+0xa5/0xb0 mm/kasan/common.c:380
 kmalloc include/linux/slab.h:580 [inline]
 kzalloc include/linux/slab.h:720 [inline]
 hfsplus_btree_open+0x52/0xcd0 fs/hfsplus/btree.c:142
 hfsplus_fill_super+0xae5/0x1a30 fs/hfsplus/super.c:473
 mount_bdev+0x351/0x410 fs/super.c:1359
 legacy_get_tree+0x109/0x220 fs/fs_context.c:610
 vfs_get_tree+0x8d/0x2f0 fs/super.c:1489
 do_new_mount fs/namespace.c:3145 [inline]
 path_mount+0x132a/0x1e20 fs/namespace.c:3475
 do_mount fs/namespace.c:3488 [inline]
 __do_sys_mount fs/namespace.c:3697 [inline]
 __se_sys_mount fs/namespace.c:3674 [inline]
 __x64_sys_mount+0x283/0x300 fs/namespace.c:3674
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

Freed by task 5071:
 kasan_save_stack+0x22/0x40 mm/kasan/common.c:45
 kasan_set_track+0x25/0x30 mm/kasan/common.c:52
 kasan_save_free_info+0x2e/0x40 mm/kasan/generic.c:518
 ____kasan_slab_free mm/kasan/common.c:236 [inline]
 ____kasan_slab_free+0x160/0x1c0 mm/kasan/common.c:200
 kasan_slab_free include/linux/kasan.h:177 [inline]
 slab_free_hook mm/slub.c:1781 [inline]
 slab_free_freelist_hook+0x8b/0x1c0 mm/slub.c:1807
 slab_free mm/slub.c:3787 [inline]
 __kmem_cache_free+0xaf/0x3b0 mm/slub.c:3800
 hfsplus_btree_close+0x1e5/0x380 fs/hfsplus/btree.c:280
 hfsplus_put_super+0x224/0x3f0 fs/hfsplus/super.c:300
 generic_shutdown_super+0x158/0x410 fs/super.c:492
 kill_block_super+0x9b/0xf0 fs/super.c:1386
 deactivate_locked_super+0x98/0x160 fs/super.c:332
 deactivate_super+0xb1/0xd0 fs/super.c:363
 cleanup_mnt+0x2ae/0x3d0 fs/namespace.c:1291
 task_work_run+0x16f/0x270 kernel/task_work.c:179
 exit_task_work include/linux/task_work.h:38 [inline]
 do_exit+0xaa8/0x2950 kernel/exit.c:867
 do_group_exit+0xd4/0x2a0 kernel/exit.c:1010
 __do_sys_exit_group kernel/exit.c:1021 [inline]
 __se_sys_exit_group kernel/exit.c:1019 [inline]
 __x64_sys_exit_group+0x3e/0x50 kernel/exit.c:1019
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

The buggy address belongs to the object at ffff888029a36000
 which belongs to the cache kmalloc-4k of size 4096
The buggy address is located 56 bytes inside of
 4096-byte region [ffff888029a36000, ffff888029a37000)

The buggy address belongs to the physical page:
page:ffffea0000a68c00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x29a30
head:ffffea0000a68c00 order:3 compound_mapcount:0 subpages_mapcount:0 compound_pincount:0
flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000010200 ffff888012042140 dead000000000122 0000000000000000
raw: 0000000000000000 0000000000040004 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 3, migratetype Unmovable, gfp_mask 0xd2040(__GFP_IO|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 5071, tgid 5071 (syz-executor327), ts 46338673547, free_ts 42741516779
 prep_new_page mm/page_alloc.c:2531 [inline]
 get_page_from_freelist+0x119c/0x2ce0 mm/page_alloc.c:4283
 __alloc_pages+0x1cb/0x5b0 mm/page_alloc.c:5549
 alloc_pages+0x1aa/0x270 mm/mempolicy.c:2285
 alloc_slab_page mm/slub.c:1851 [inline]
 allocate_slab+0x25f/0x350 mm/slub.c:1998
 new_slab mm/slub.c:2051 [inline]
 ___slab_alloc+0xa91/0x1400 mm/slub.c:3193
 __slab_alloc.constprop.0+0x56/0xa0 mm/slub.c:3292
 __slab_alloc_node mm/slub.c:3345 [inline]
 slab_alloc_node mm/slub.c:3442 [inline]
 __kmem_cache_alloc_node+0x1a4/0x430 mm/slub.c:3491
 __do_kmalloc_node mm/slab_common.c:967 [inline]
 __kmalloc+0x4a/0xd0 mm/slab_common.c:981
 kmalloc include/linux/slab.h:584 [inline]
 tomoyo_realpath_from_path+0xc3/0x600 security/tomoyo/realpath.c:251
 tomoyo_mount_acl+0x2d1/0x840 security/tomoyo/mount.c:141
 tomoyo_mount_permission+0x163/0x410 security/tomoyo/mount.c:237
 security_sb_mount+0x6a/0xc0 security/security.c:1007
 path_mount+0x133/0x1e20 fs/namespace.c:3417
 do_mount fs/namespace.c:3488 [inline]
 __do_sys_mount fs/namespace.c:3697 [inline]
 __se_sys_mount fs/namespace.c:3674 [inline]
 __x64_sys_mount+0x283/0x300 fs/namespace.c:3674
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
page last free stack trace:
 reset_page_owner include/linux/page_owner.h:24 [inline]
 free_pages_prepare mm/page_alloc.c:1446 [inline]
 free_pcp_prepare+0x65c/0xc00 mm/page_alloc.c:1496
 free_unref_page_prepare mm/page_alloc.c:3369 [inline]
 free_unref_page+0x1d/0x490 mm/page_alloc.c:3464
 __unfreeze_partials+0x17c/0x1a0 mm/slub.c:2637
 qlink_free mm/kasan/quarantine.c:168 [inline]
 qlist_free_all+0x6a/0x170 mm/kasan/quarantine.c:187
 kasan_quarantine_reduce+0x192/0x220 mm/kasan/quarantine.c:294
 __kasan_slab_alloc+0x66/0x90 mm/kasan/common.c:302
 kasan_slab_alloc include/linux/kasan.h:201 [inline]
 slab_post_alloc_hook mm/slab.h:761 [inline]
 slab_alloc_node mm/slub.c:3452 [inline]
 slab_alloc mm/slub.c:3460 [inline]
 __kmem_cache_alloc_lru mm/slub.c:3467 [inline]
 kmem_cache_alloc_lru+0x26d/0x760 mm/slub.c:3483
 alloc_inode_sb include/linux/fs.h:3116 [inline]
 alloc_inode+0x168/0x230 fs/inode.c:261
 new_inode_pseudo+0x17/0x80 fs/inode.c:1018
 get_pipe_inode fs/pipe.c:873 [inline]
 create_pipe_files+0x51/0x890 fs/pipe.c:913
 __do_pipe_flags fs/pipe.c:962 [inline]
 do_pipe2+0x96/0x1b0 fs/pipe.c:1010
 __do_sys_pipe fs/pipe.c:1033 [inline]
 __se_sys_pipe fs/pipe.c:1031 [inline]
 __x64_sys_pipe+0x33/0x40 fs/pipe.c:1031
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

Memory state around the buggy address:
 ffff888029a35f00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff888029a35f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff888029a36000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                        ^
 ffff888029a36080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff888029a36100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (23):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2022/12/18 20:39 upstream f9ff5644bcc0 05494336 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-root KASAN: use-after-free Read in hfsplus_release_folio
2022/12/13 05:21 upstream 830b3c68c1fb 67be1ae7 .config strace log report syz C [mounted in repro] ci2-upstream-fs KASAN: use-after-free Read in hfsplus_release_folio
2023/01/15 16:23 linux-next 0a093b2893c7 a63719e7 .config strace log report syz C [mounted in repro] ci-upstream-linux-next-kasan-gce-root KASAN: use-after-free Read in hfsplus_release_folio
2023/01/31 20:58 linux-next 80bd9028feca 9dfcf09c .config strace log report syz C [mounted in repro] ci-upstream-linux-next-kasan-gce-root KASAN: slab-use-after-free Read in hfsplus_release_folio
2023/02/16 23:54 upstream 3ac88fa4605e 851bc19a .config console log report info ci-qemu-upstream KASAN: use-after-free Read in hfsplus_release_folio
2023/02/12 10:49 upstream f339c2597ebb 93e26d60 .config console log report info ci2-upstream-fs KASAN: use-after-free Read in hfsplus_release_folio
2023/02/06 01:36 upstream 4ec5183ec486 be607b78 .config console log report info ci-qemu-upstream KASAN: use-after-free Read in hfsplus_release_folio
2023/02/01 14:37 upstream c0b67534c95c 9dfcf09c .config console log report info ci-upstream-kasan-gce-selinux-root KASAN: use-after-free Read in hfsplus_release_folio
2023/01/29 21:15 upstream ab072681eabe 7374c4e5 .config console log report info ci-qemu-upstream KASAN: use-after-free Read in hfsplus_release_folio
2023/01/28 03:01 upstream 83abd4d4c4be 9dfcf09c .config console log report info ci-upstream-kasan-gce-smack-root KASAN: use-after-free Read in hfsplus_release_folio
2023/01/24 20:44 upstream 7bf70dbb1882 9dfcf09c .config console log report info ci2-upstream-fs KASAN: use-after-free Read in hfsplus_release_folio
2023/01/23 15:45 upstream 2475bf0250de 9dfcf09c .config console log report info ci-upstream-kasan-gce-smack-root KASAN: use-after-free Read in hfsplus_release_folio
2023/01/07 17:34 upstream a689b938df39 1dac8c7a .config console log report info ci-upstream-kasan-gce-smack-root KASAN: use-after-free Read in hfsplus_release_folio
2022/12/13 09:12 upstream 3a28c2c89f4b 67be1ae7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root KASAN: use-after-free Read in hfsplus_release_folio
2022/12/13 07:25 upstream 3a28c2c89f4b 67be1ae7 .config console log report info ci-upstream-kasan-gce-selinux-root KASAN: use-after-free Read in hfsplus_release_folio
2022/12/13 05:00 upstream 830b3c68c1fb 67be1ae7 .config console log report info ci2-upstream-fs KASAN: use-after-free Read in hfsplus_release_folio
2022/12/13 04:52 upstream 3a28c2c89f4b 67be1ae7 .config console log report info ci-qemu-upstream KASAN: use-after-free Read in hfsplus_release_folio
2023/01/19 02:41 linux-next f3381a7baf5c 42660d9e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root KASAN: use-after-free Read in hfsplus_release_folio
2022/12/13 04:52 linux-next 591cd61541b9 67be1ae7 .config console log report info ci-upstream-linux-next-kasan-gce-root KASAN: use-after-free Read in hfsplus_release_folio
2023/02/25 07:26 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 2ebd1fbb946d ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 KASAN: use-after-free Read in hfsplus_release_folio
2023/03/02 04:38 upstream ee3f96b16468 f8902b57 .config console log report info ci-upstream-kasan-gce-smack-root KASAN: slab-use-after-free Read in hfsplus_release_folio
2023/02/24 17:57 upstream d2980d8d8265 ee50e71c .config console log report info ci-upstream-kasan-gce-smack-root KASAN: slab-use-after-free Read in hfsplus_release_folio
2023/02/25 07:38 linux-next 8232539f864c ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root KASAN: slab-use-after-free Read in hfsplus_release_folio
* Struck through repros no longer work on HEAD.