UBSAN: shift-out-of-bounds in choke_change

Status: closed as dup on 2020/12/29 20:08
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+4eda8c01ca2315d1722e@syzkaller.appspotmail.com
First crash: 2040d, last: 1977d
Cause bisection: the issue happens on the oldest tested release (bisect log)
Crash: WARNING in sysfs_warn_dup (log)
Repro: C syz .config
  
▶ ▼ Duplicate of
Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported
UBSAN: shift-out-of-bounds in sfq_init net -1 C unreliable 8 2029d 2043d
▶ ▼ Discussions (1)
Title Replies (including bot) Last reply
UBSAN: shift-out-of-bounds in choke_change 1 (2) 2020/12/29 20:07
▶ ▼ Similar bugs (1)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream UBSAN: shift-out-of-bounds in choke_change (2) net -1 C done 7 1935d 1951d 20/29 fixed on 2021/11/10 00:50

Sample crash report:
netdevsim netdevsim0 netdevsim1: set [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim0 netdevsim2: set [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim0 netdevsim3: set [1, 0] type 2 family 0 port 6081 - 0
================================================================================
UBSAN: shift-out-of-bounds in ./include/net/red.h:252:22
shift exponent 96 is too large for 32-bit type 'int'
CPU: 0 PID: 8513 Comm: syz-executor800 Not tainted 5.10.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:79 [inline]
 dump_stack+0x107/0x163 lib/dump_stack.c:120
 ubsan_epilogue+0xb/0x5a lib/ubsan.c:148
 __ubsan_handle_shift_out_of_bounds.cold+0xb1/0x181 lib/ubsan.c:395
 red_set_parms include/net/red.h:252 [inline]
 choke_change.cold+0xce/0x115 net/sched/sch_choke.c:413
 qdisc_create+0x4ba/0x13a0 net/sched/sch_api.c:1246
 tc_modify_qdisc+0x4c8/0x1a30 net/sched/sch_api.c:1662
 rtnetlink_rcv_msg+0x498/0xb80 net/core/rtnetlink.c:5564
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2494
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x907/0xe40 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2345
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2399
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2432
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x4437b9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 eb 0d fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fff205ca1d8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00000000004437b9
RDX: 0000000000000000 RSI: 00000000200007c0 RDI: 0000000000000004
RBP: 00007fff205ca1e0 R08: 0000000001bbbbbb R09: 0000000001bbbbbb
R10: 0000000001bbbbbb R11: 0000000000000246 R12: 00007fff205ca1f0
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
================================================================================

Crashes (15):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/12/25 19:16 upstream 71c5f03154ac b982b3ea .config console log report syz C ci-upstream-kasan-gce
2020/12/25 19:51 net-old 1f45dc220667 b982b3ea .config console log report syz C ci-upstream-net-this-kasan-gce
2020/12/25 19:31 net-old 1f45dc220667 b982b3ea .config console log report syz C ci-upstream-net-this-kasan-gce
2021/02/26 12:42 upstream 2c87f7a38f93 76f7fc95 .config console log report info ci-upstream-kasan-gce-selinux-root UBSAN: shift-out-of-bounds in choke_change
2021/02/12 05:34 upstream 291009f656e8 a5f86b15 .config console log report info ci-upstream-kasan-gce-smack-root UBSAN: shift-out-of-bounds in choke_change
2021/02/03 18:44 upstream 3aaf0a27ffc2 624dad51 .config console log report info ci-upstream-kasan-gce-root UBSAN: shift-out-of-bounds in choke_change
2021/02/03 10:15 upstream 3aaf0a27ffc2 624dad51 .config console log report info ci-upstream-kasan-gce UBSAN: shift-out-of-bounds in choke_change
2021/02/17 19:14 net-next-old d489ded1a369 052f8d9f .config console log report info ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in choke_change
2021/01/20 02:53 net-next-old 7eab14de73a8 63631df1 .config console log report info ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in choke_change
2021/01/14 15:25 upstream 65f0d2414b70 269d24e8 .config console log report info ci-upstream-kasan-gce
2021/01/14 09:37 upstream 65f0d2414b70 269d24e8 .config console log report info ci-upstream-kasan-gce
2020/12/27 09:17 upstream f838f8d2b694 821e0b09 .config console log report info ci-upstream-kasan-gce
2020/12/25 18:51 upstream 71c5f03154ac b982b3ea .config console log report info ci-upstream-kasan-gce
2020/12/25 19:10 net-old 1f45dc220667 b982b3ea .config console log report info ci-upstream-net-this-kasan-gce
2021/01/02 17:05 net-next-old 3db1a3fa9880 79264ae3 .config console log report info ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.