WARNING: ODEBUG bug in tcindex_destroy_work (3)

Status: fixed on 2020/05/10 10:41
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+46f513c3033d592409d2@syzkaller.appspotmail.com
Fix commit: 304e024216a8 net_sched: add a temporary refcnt for struct tcindex_data
First crash: 2343d, last: 2306d
Cause bisection: introduced by (bisect log) :
commit 836e9494f4485127a5b505ae57e4387bea8b53c4
Author: Adam Zerella <adam.zerella@gmail.com>
Date: Sun Aug 25 05:35:10 2019 +0000

  pcmcia/i82092: Refactored dprintk macro for dev_dbg().

Crash: WARNING: ODEBUG bug in tcindex_destroy_work (log)
Repro: syz .config
  
▶ ▼ Discussions (5)
Title Replies (including bot) Last reply
[PATCH 5.6 00/38] 5.6.4-rc1 review 44 (44) 2020/04/14 10:36
[PATCH 5.5 00/44] 5.5.17-rc1 review 48 (48) 2020/04/14 10:36
[PATCH 5.4 00/41] 5.4.32-rc1 review 45 (45) 2020/04/14 10:36
[Patch net] net_sched: add a temporary refcnt for struct tcindex_data 7 (7) 2020/04/01 18:07
WARNING: ODEBUG bug in tcindex_destroy_work (3) 13 (16) 2020/03/30 13:37
▶ ▼ Similar bugs (3)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream WARNING: ODEBUG bug in tcindex_destroy_work net -1 4 2466d 2495d 0/29 closed as invalid on 2019/12/08 05:54
upstream WARNING: ODEBUG bug in tcindex_destroy_work (2) net -1 5 2354d 2364d 15/29 fixed on 2020/02/18 14:31
linux-4.19 WARNING: ODEBUG bug in tcindex_destroy_work -1 C 190 1239d 2469d 0/1 upstream: reported C repro on 2019/10/21 05:48

Sample crash report:
------------[ cut here ]------------
ODEBUG: free active (active state 0) object type: work_struct hint: tcindex_destroy_rexts_work+0x0/0x20 net/sched/cls_tcindex.c:143
WARNING: CPU: 1 PID: 7 at lib/debugobjects.c:485 debug_print_object+0x160/0x250 lib/debugobjects.c:485
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 7 Comm: kworker/u4:0 Not tainted 5.6.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: tc_filter_workqueue tcindex_destroy_work
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x188/0x20d lib/dump_stack.c:118
 panic+0x2e3/0x75c kernel/panic.c:221
 __warn.cold+0x2f/0x35 kernel/panic.c:582
 report_bug+0x27b/0x2f0 lib/bug.c:195
 fixup_bug arch/x86/kernel/traps.c:174 [inline]
 fixup_bug arch/x86/kernel/traps.c:169 [inline]
 do_error_trap+0x12b/0x220 arch/x86/kernel/traps.c:267
 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:286
 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027
RIP: 0010:debug_print_object+0x160/0x250 lib/debugobjects.c:485
Code: dd c0 fa 51 88 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 bf 00 00 00 48 8b 14 dd c0 fa 51 88 48 c7 c7 20 f0 51 88 e8 a8 bd b1 fd <0f> 0b 83 05 8b cf d3 06 01 48 83 c4 20 5b 5d 41 5c 41 5d c3 48 89
RSP: 0018:ffffc90000cdfc40 EFLAGS: 00010082
RAX: 0000000000000000 RBX: 0000000000000003 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff815bfe61 RDI: fffff5200019bf7a
RBP: 0000000000000001 R08: ffff8880a95de1c0 R09: ffffed1015ce45c9
R10: ffffed1015ce45c8 R11: ffff8880ae722e43 R12: ffffffff8977aba0
R13: ffffffff814a9360 R14: ffff88807e278f98 R15: ffff88809835c6c8
 __debug_check_no_obj_freed lib/debugobjects.c:967 [inline]
 debug_check_no_obj_freed+0x2e1/0x445 lib/debugobjects.c:998
 kfree+0xf6/0x2b0 mm/slab.c:3756
 tcindex_destroy_work+0x2e/0x70 net/sched/cls_tcindex.c:231
 process_one_work+0x94b/0x1690 kernel/workqueue.c:2266
 worker_thread+0x96/0xe20 kernel/workqueue.c:2412
 kthread+0x357/0x430 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (13):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/03/16 23:46 net-next-old 74522e7baae2 749688d2 .config console log report syz ci-upstream-net-kasan-gce
2020/03/25 20:47 upstream e2cf67f6689a 41f049cc .config console log report ci-upstream-kasan-gce-root
2020/03/20 05:13 upstream cd607737f3b8 2c31c529 .config console log report ci-upstream-kasan-gce-selinux-root
2020/03/15 00:25 upstream 69a4d0baeeb1 749688d2 .config console log report ci-upstream-kasan-gce
2020/03/11 19:14 upstream f35111a94654 e7caca8e .config console log report ci-upstream-kasan-gce-selinux-root
2020/02/24 10:19 upstream d2eee25858f2 d801cb02 .config console log report ci-upstream-kasan-gce-smack-root
2020/03/26 21:37 upstream 9420e8ade435 6d25c5a0 .config console log report ci-upstream-kasan-gce-386
2020/03/29 22:11 net-next-old 1a147b74c2fd 05736b29 .config console log report ci-upstream-net-kasan-gce
2020/04/01 04:33 linux-next 770fbb32d34e a34e2c33 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/03/25 20:11 linux-next 770fbb32d34e 41f049cc .config console log report ci-upstream-linux-next-kasan-gce-root
2020/03/23 00:00 linux-next 770fbb32d34e 78267cec .config console log report ci-upstream-linux-next-kasan-gce-root
2020/03/20 05:25 linux-next 770fbb32d34e 2c31c529 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/03/12 22:09 linux-next 770fbb32d34e d850e9d0 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.