WARNING: kobject bug in gfs2_sys_fs_add

Status: fixed on 2018/05/08 18:30
Subsystems: gfs2
[Documentation on labels]
Reported-by: syzbot+209c0f67f99fec8eb14b@syzkaller.appspotmail.com
Fix commit: 3e14c6abbfb5 kobject: don't use WARN for registration failures
First crash: 3040d, last: 3013d
▶ ▼ Duplicate bugs (1)
Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
WARNING: kobject bug in sysfs_warn_dup isofs gfs2 -1 C 1 3035d 3035d 0/29 closed as dup on 2018/04/11 15:00
▶ ▼ Discussions (6)
Title Replies (including bot) Last reply
[PATCH 4.16 000/113] 4.16.7-stable review 120 (120) 2018/05/01 19:26
[PATCH 4.4 00/44] 4.4.131-stable review 53 (53) 2018/05/01 19:08
[PATCH 4.9 00/61] 4.9.98-stable review 66 (66) 2018/05/01 19:07
[PATCH 4.14 00/91] 4.14.39-stable review 97 (97) 2018/05/01 19:06
[PATCH 3.18 00/25] 3.18.108-stable review 32 (32) 2018/05/01 19:04
[PATCH] kobject: don't use WARN for registration failures 1 (1) 2018/04/11 15:22

Sample crash report:
R10: 0000000000800000 R11: 0000000000000217 R12: 6c6261746b636f6c
R13: 746f72706b636f6c R14: 0030656c69662f2e R15: 0000000000000004
------------[ cut here ]------------
gfs2: fsid=user.: Trying to join cluster "lock_nolock", "user."
kobject_add_internal failed for user. with -EEXIST, don't try to register things with the same name in the same directory.
WARNING: CPU: 0 PID: 4490 at lib/kobject.c:238 kobject_add_internal+0x8e0/0xba0 lib/kobject.c:236
gfs2: fsid=user.: Now mounting FS...
Kernel panic - not syncing: panic_on_warn set ...

CPU: 0 PID: 4490 Comm: syzkaller869138 Not tainted 4.16.0+ #3
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1b9/0x294 lib/dump_stack.c:113
sysfs: cannot create duplicate filename '/fs/gfs2/user.'
 panic+0x22f/0x4de kernel/panic.c:184
 __warn.cold.8+0x163/0x1b3 kernel/panic.c:536
 report_bug+0x252/0x2d0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:178 [inline]
 do_error_trap+0x1de/0x490 arch/x86/kernel/traps.c:296
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315
 invalid_op+0x1b/0x40 arch/x86/entry/entry_64.S:991
RIP: 0010:kobject_add_internal+0x8e0/0xba0 lib/kobject.c:236
RSP: 0018:ffff8801acec7480 EFLAGS: 00010286
RAX: 000000000000007a RBX: ffff8801ad04d1d0 RCX: 1ffff100359c19e3
RDX: 0000000000000000 RSI: ffffffff815fa5a1 RDI: 0000000000000293
RBP: ffff8801acec7578 R08: ffff8801ace0cef8 R09: 0000000000000006
R10: ffff8801ace0c6c0 R11: 0000000000000000 R12: 00000000ffffffef
R13: ffff8801d3a02948 R14: 1ffff100359d8e9a R15: ffff8801d3a02900
 kobject_add_varg lib/kobject.c:364 [inline]
 kobject_init_and_add+0xed/0x130 lib/kobject.c:435
 gfs2_sys_fs_add+0x1ff/0x500 fs/gfs2/sys.c:652
 fill_super+0x8c9/0x1a40 fs/gfs2/ops_fstype.c:1118
 gfs2_mount+0x5e6/0x712 fs/gfs2/ops_fstype.c:1321
 mount_fs+0xae/0x328 fs/super.c:1268
 vfs_kern_mount.part.34+0xd4/0x4d0 fs/namespace.c:1037
 vfs_kern_mount fs/namespace.c:1027 [inline]
 do_new_mount fs/namespace.c:2517 [inline]
 do_mount+0x564/0x3070 fs/namespace.c:2847
 ksys_mount+0x12d/0x140 fs/namespace.c:3063
 SYSC_mount fs/namespace.c:3077 [inline]
 SyS_mount+0x35/0x50 fs/namespace.c:3074
 do_syscall_64+0x29e/0x9d0 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x44327a
RSP: 002b:00007ffdfe982d48 EFLAGS: 00000217 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 000000000044327a
RDX: 00000000200000c0 RSI: 0000000020000100 RDI: 00007ffdfe982d60
RBP: 0000000020000198 R08: 0000000020001480 R09: 000000000000000a
R10: 0000000000800000 R11: 0000000000000217 R12: 6c6261746b636f6c
R13: 746f72706b636f6c R14: 0030656c69662f2e R15: 0000000000000004
CPU: 1 PID: 4488 Comm: syzkaller869138 Not tainted 4.16.0+ #3
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1b9/0x294 lib/dump_stack.c:113
 sysfs_warn_dup.cold.3+0x1c/0x2b fs/sysfs/dir.c:30
 sysfs_create_dir_ns+0x184/0x1d0 fs/sysfs/dir.c:58
 create_dir lib/kobject.c:69 [inline]
 kobject_add_internal+0x353/0xba0 lib/kobject.c:228
 kobject_add_varg lib/kobject.c:364 [inline]
 kobject_init_and_add+0xed/0x130 lib/kobject.c:435
 gfs2_sys_fs_add+0x1ff/0x500 fs/gfs2/sys.c:652
 fill_super+0x8c9/0x1a40 fs/gfs2/ops_fstype.c:1118
 gfs2_mount+0x5e6/0x712 fs/gfs2/ops_fstype.c:1321
 mount_fs+0xae/0x328 fs/super.c:1268
 vfs_kern_mount.part.34+0xd4/0x4d0 fs/namespace.c:1037
 vfs_kern_mount fs/namespace.c:1027 [inline]
 do_new_mount fs/namespace.c:2517 [inline]
 do_mount+0x564/0x3070 fs/namespace.c:2847
 ksys_mount+0x12d/0x140 fs/namespace.c:3063
 SYSC_mount fs/namespace.c:3077 [inline]
 SyS_mount+0x35/0x50 fs/namespace.c:3074
 do_syscall_64+0x29e/0x9d0 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x44327a
RSP: 002b:00007ffdfe982d48 EFLAGS: 00000217 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 000000000044327a
RDX: 00000000200000c0 RSI: 0000000020000100 RDI: 00007ffdfe982d60
RBP: 0000000020000198 R08: 0000000020001480 R09: 000000000000000a
R10: 0000000000800000 R11: 0000000000000217 R12: 6c6261746b636f6c
R13: 746f72706b636f6c R14: 0030656c69662f2e R15: 0000000000000004
Dumping ftrace buffer:
   (ftrace buffer empty)
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (49):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/04/15 07:41 upstream 18b7fd1c93e5 7a67784c .config console log report syz C ci-upstream-kasan-gce-root
2018/04/27 12:29 upstream 0644f186fc9d 73417389 .config console log report ci-upstream-kasan-gce-root
2018/04/27 02:39 upstream 0644f186fc9d 73417389 .config console log report ci-upstream-kasan-gce-root
2018/04/26 17:51 upstream 69bfd470f462 73417389 .config console log report ci-upstream-kasan-gce-root
2018/04/23 10:48 upstream 6d08b06e67cd 20941ab3 .config console log report ci-upstream-kasan-gce-root
2018/04/22 03:00 upstream 5e7c7806111a d23fcf6c .config console log report ci-upstream-kasan-gce-root
2018/04/20 21:46 upstream 43f70c960180 cc402841 .config console log report ci-upstream-kasan-gce-root
2018/04/18 20:10 upstream a27fc14219f2 829f0234 .config console log report ci-upstream-kasan-gce-root
2018/04/18 16:12 upstream a27fc14219f2 52643b44 .config console log report ci-upstream-kasan-gce-root
2018/04/18 14:05 upstream a27fc14219f2 52643b44 .config console log report ci-upstream-kasan-gce-root
2018/04/18 13:56 upstream a27fc14219f2 52643b44 .config console log report ci-upstream-kasan-gce-root
2018/04/18 12:47 upstream a27fc14219f2 52643b44 .config console log report ci-upstream-kasan-gce-root
2018/04/18 09:35 upstream a27fc14219f2 52643b44 .config console log report ci-upstream-kasan-gce-root
2018/04/18 09:10 upstream a27fc14219f2 52643b44 .config console log report ci-upstream-kasan-gce-root
2018/04/18 08:16 upstream a27fc14219f2 52643b44 .config console log report ci-upstream-kasan-gce-root
2018/04/17 03:14 upstream a27fc14219f2 b80fd3b5 .config console log report ci-upstream-kasan-gce-root
2018/04/17 00:59 upstream a27fc14219f2 b80fd3b5 .config console log report ci-upstream-kasan-gce-root
2018/04/16 18:49 upstream 60cc43fc8884 802ac912 .config console log report ci-upstream-kasan-gce-root
2018/04/16 15:50 upstream 60cc43fc8884 802ac912 .config console log report ci-upstream-kasan-gce-root
2018/04/16 15:45 upstream 60cc43fc8884 802ac912 .config console log report ci-upstream-kasan-gce-root
2018/04/16 15:02 upstream 60cc43fc8884 802ac912 .config console log report ci-upstream-kasan-gce-root
2018/04/16 11:42 upstream 60cc43fc8884 802ac912 .config console log report ci-upstream-kasan-gce-root
2018/04/16 11:10 upstream 60cc43fc8884 802ac912 .config console log report ci-upstream-kasan-gce-root
2018/04/15 07:26 upstream 18b7fd1c93e5 7a67784c .config console log report ci-upstream-kasan-gce-root
2018/04/14 08:50 upstream 1bad9ce155a7 7a67784c .config console log report ci-upstream-kasan-gce-root
2018/04/11 07:55 upstream c18bb396d3d2 8b8de427 .config console log report ci-upstream-kasan-gce-root
2018/04/10 01:48 upstream fd40ffc72e2f b9f65507 .config console log report ci-upstream-kasan-gce-root
2018/04/09 10:37 upstream 3fd14cdcc05a f13fb445 .config console log report ci-upstream-kasan-gce-root
2018/04/09 10:27 upstream 3fd14cdcc05a f13fb445 .config console log report ci-upstream-kasan-gce-root
2018/04/08 21:06 upstream 3fd14cdcc05a 77bd5117 .config console log report ci-upstream-kasan-gce-root
2018/04/07 13:54 upstream 3fd14cdcc05a 66f22a7f .config console log report ci-upstream-kasan-gce-root
2018/04/06 00:03 upstream 3c8ba0d61d04 a932eae6 .config console log report ci-upstream-kasan-gce-root
2018/04/04 22:31 upstream 3e968c9f1401 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/04 09:15 upstream 17dec0a94915 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/04 06:39 upstream f2d285669aae 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 23:35 upstream f2d285669aae 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 09:45 upstream 642e7fd23353 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/02 23:00 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/02 20:35 upstream 86bbbebac193 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/02 19:13 upstream 0adb32858b0b 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/02 16:35 upstream 0adb32858b0b dc889257 .config console log report ci-upstream-kasan-gce-root
2018/04/02 01:24 upstream 0adb32858b0b dc889257 .config console log report ci-upstream-kasan-gce-root
2018/04/01 23:40 upstream 0adb32858b0b dc889257 .config console log report ci-upstream-kasan-gce-root
2018/04/01 11:57 upstream 10b84daddbec 0a78e248 .config console log report ci-upstream-kasan-gce-root
2018/03/31 18:32 upstream b5dbc28762fd 0174c6c8 .config console log report ci-upstream-kasan-gce-root
2018/03/31 17:59 upstream b5dbc28762fd 0174c6c8 .config console log report ci-upstream-kasan-gce-root
2018/03/31 17:56 upstream b5dbc28762fd 0174c6c8 .config console log report ci-upstream-kasan-gce-root
2018/03/31 16:13 upstream b5dbc28762fd 8fbce0e4 .config console log report ci-upstream-kasan-gce-root
* Struck through repros no longer work on HEAD.