WARNING in __flush_work (2)

Status: fixed on 2019/03/28 12:00
Subsystems: dri
[Documentation on labels]
Reported-by: syzbot+03bd8ee354763fad396d@syzkaller.appspotmail.com
Fix commit: b30b61ff6b1d drm/vkms: Fix flush_work() without INIT_WORK().
First crash: 2725d, last: 2724d
▶ ▼ Discussions (1)
Title Replies (including bot) Last reply
WARNING in __flush_work (2) 1 (2) 2019/03/08 10:31
▶ ▼ Similar bugs (4)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 WARNING in __flush_work -1 syz, C done 135 2664d 2670d 1/1 fixed on 2019/11/30 01:15
upstream WARNING in __flush_work (4) media usb -1 syz, C 1 2573d 2572d 0/29 closed as invalid on 2019/08/08 13:27
upstream WARNING in __flush_work (3) usb -1 syz, C 1251 2577d 2687d 12/29 fixed on 2019/08/05 13:45
upstream WARNING in __flush_work block -1 syz, C 402 2756d 2763d 11/29 fixed on 2019/03/06 07:43

Sample crash report:
audit: type=1800 audit(1552011036.129:30): pid=7281 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="startpar" name="rmnologin" dev="sda1" ino=2423 res=0
WARNING: CPU: 1 PID: 7435 at kernel/workqueue.c:3020 __flush_work+0x74c/0x8a0 kernel/workqueue.c:3020
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 7435 Comm: syz-executor488 Not tainted 5.0.0+ #11
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 panic+0x2cb/0x65c kernel/panic.c:214
 __warn.cold+0x20/0x45 kernel/panic.c:571
 report_bug+0x263/0x2b0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:179 [inline]
 fixup_bug arch/x86/kernel/traps.c:174 [inline]
 do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:272
 do_invalid_op+0x37/0x50 arch/x86/kernel/traps.c:291
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:973
RIP: 0010:__flush_work+0x74c/0x8a0 kernel/workqueue.c:3020
Code: 74 58 e8 77 12 26 00 fb 66 0f 1f 44 00 00 45 31 e4 e9 86 fd ff ff e8 63 12 26 00 0f 0b 45 31 e4 e9 77 fd ff ff e8 54 12 26 00 <0f> 0b 45 31 e4 e9 68 fd ff ff e8 45 12 26 00 4c 89 ff 45 31 e4 e8
RSP: 0018:ffff88808caf7608 EFLAGS: 00010293
RAX: ffff888095f024c0 RBX: ffff88821954b900 RCX: ffffffff814a14cb
RDX: 0000000000000000 RSI: ffffffff814a1b7c RDI: 0000000000000001
RBP: ffff88808caf7778 R08: ffff888095f024c0 R09: ffffed101195eedd
R10: ffffed101195eedc R11: 0000000000000003 R12: dffffc0000000000
R13: ffff88808caf7750 R14: 0000000000000000 R15: 0000000000000001
 flush_work+0x18/0x20 kernel/workqueue.c:3050
 vkms_atomic_crtc_destroy_state drivers/gpu/drm/vkms/vkms_crtc.c:133 [inline]
 vkms_atomic_crtc_destroy_state+0x2d/0x40 drivers/gpu/drm/vkms/vkms_crtc.c:125
 drm_atomic_state_default_clear+0x37c/0xd60 drivers/gpu/drm/drm_atomic.c:171
 drm_atomic_state_clear+0x9d/0xc0 drivers/gpu/drm/drm_atomic.c:240
 __drm_atomic_state_free+0x3c/0xf0 drivers/gpu/drm/drm_atomic.c:256
 kref_put include/linux/kref.h:67 [inline]
 drm_atomic_state_put include/drm/drm_atomic.h:385 [inline]
 drm_atomic_helper_set_config+0xe5/0x160 drivers/gpu/drm/drm_atomic_helper.c:2956
 drm_mode_setcrtc+0x613/0x1490 drivers/gpu/drm/drm_crtc.c:748
 drm_ioctl_kernel+0x23b/0x2e0 drivers/gpu/drm/drm_ioctl.c:758
 drm_ioctl+0x545/0xa50 drivers/gpu/drm/drm_ioctl.c:858
 vfs_ioctl fs/ioctl.c:46 [inline]
 file_ioctl fs/ioctl.c:509 [inline]
 do_vfs_ioctl+0xd6e/0x1390 fs/ioctl.c:696
 ksys_ioctl+0xab/0xd0 fs/ioctl.c:713
 __do_sys_ioctl fs/ioctl.c:720 [inline]
 __se_sys_ioctl fs/ioctl.c:718 [inline]
 __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718
 do_syscall_64+0x103/0x610 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x443ed9
Code: 21 02 00 85 c0 b8 00 00 00 00 48 0f 44 c3 5b c3 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 1b d8 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffdedf89d38 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000443ed9
RDX: 0000000020000180 RSI: 00000000c06864a2 RDI: 0000000000000003
RBP: 00000000006cf018 R08: 0000000000000000 R09: 6c616b7a79732f2e
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000401b80
R13: 0000000000401c10 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (38):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/03/08 02:14 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce-root
2019/03/08 02:00 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce-root
2019/03/08 01:46 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce-root
2019/03/08 00:35 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce-selinux-root
2019/03/08 00:27 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce
2019/03/08 00:22 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce-selinux-root
2019/03/08 00:18 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/03/08 00:11 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce
2019/03/08 00:04 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/03/07 23:55 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce
2019/03/07 23:51 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce-smack-root
2019/03/07 23:41 upstream 1fc1cd8399ab 4b69c3cb .config console log report syz C ci-upstream-kasan-gce-selinux-root
2019/03/08 21:23 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-smack-root
2019/03/08 21:23 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-selinux-root
2019/03/08 21:22 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce
2019/03/08 21:20 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce
2019/03/08 11:53 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-root
2019/03/08 11:52 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-smack-root
2019/03/08 11:51 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-smack-root
2019/03/08 11:50 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-smack-root
2019/03/08 11:50 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce
2019/03/08 11:50 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-root
2019/03/08 11:49 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-root
2019/03/08 11:49 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-smack-root
2019/03/08 11:49 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-selinux-root
2019/03/08 11:49 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce
2019/03/08 11:49 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-selinux-root
2019/03/08 11:49 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-selinux-root
2019/03/08 11:48 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-root
2019/03/08 11:48 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-smack-root
2019/03/08 11:48 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce
2019/03/08 11:47 upstream 610cd4eadec4 12365b99 .config console log report ci-upstream-kasan-gce-root
2019/03/08 04:34 upstream 1fc1cd8399ab 4b69c3cb .config console log report ci-upstream-kasan-gce
2019/03/07 23:22 upstream 1fc1cd8399ab 4b69c3cb .config console log report ci-upstream-kasan-gce
2019/03/07 22:43 upstream 1fc1cd8399ab 4b69c3cb .config console log report ci-upstream-kasan-gce-smack-root
2019/03/07 22:33 upstream 1fc1cd8399ab 4b69c3cb .config console log report ci-upstream-kasan-gce
2019/03/07 22:29 upstream 1fc1cd8399ab 4b69c3cb .config console log report ci-upstream-kasan-gce-smack-root
2019/03/07 22:03 upstream 1fc1cd8399ab 4b69c3cb .config console log report ci-upstream-kasan-gce-selinux-root
* Struck through repros no longer work on HEAD.