WARNING: proc registration bug in clusterip_tg_check

Status: fixed on 2018/02/26 20:04
Subsystems: netfilter
[Documentation on labels]
Reported-by: syzbot+03218bcdba6aa76441a3@syzkaller.appspotmail.com
Fix commit: b3e456fce9f5 netfilter: ipt_CLUSTERIP: fix a race condition of proc file creation
First crash: 3093d, last: 3075d
▶ ▼ Duplicate bugs (1)
Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
WARNING in proc_register netfilter -1 C 775 3093d 3094d 0/29 closed as dup on 2018/02/06 14:28
▶ ▼ Discussions (5)
Title Replies (including bot) Last reply
[PATCH 4.15 000/146] 4.15.10-stable review 160 (160) 2018/03/15 10:19
[PATCH 4.14 000/140] 4.14.27-stable review 150 (150) 2018/03/14 18:26
[PATCH 00/19] Netfilter fixes for net 21 (21) 2018/02/21 19:56
[Patch net] ipt_CLUSTERIP: fix a race condition of proc file creation 6 (6) 2018/02/08 20:05
WARNING: proc registration bug in clusterip_tg_check 6 (9) 2018/02/07 15:57
▶ ▼ Similar bugs (4)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream WARNING: proc registration bug in clusterip_tg_check (2) netfilter -1 7 2063d 2257d 0/29 auto-closed as invalid on 2021/04/02 09:10
linux-4.19 WARNING: proc registration bug in clusterip_tg_check (2) -1 syz error 14 1720d 2022d 0/1 upstream: reported syz repro on 2021/01/12 15:17
upstream WARNING: proc registration bug in clusterip_tg_check (3) netfilter -1 C done inconclusive 9 1284d 1818d 22/29 fixed on 2023/06/08 14:41
linux-4.19 WARNING: proc registration bug in clusterip_tg_check -1 2 2272d 2314d 0/1 auto-closed as invalid on 2020/09/04 20:53

Sample crash report:
Cannot find add_set index 0 as target
Cannot find add_set index 0 as target
------------[ cut here ]------------
proc_dir_entry 'ipt_CLUSTERIP/172.20.5.170' already registered
WARNING: CPU: 0 PID: 5224 at fs/proc/generic.c:330 proc_register+0x2d6/0x3b0 fs/proc/generic.c:329
Kernel panic - not syncing: panic_on_warn set ...

CPU: 0 PID: 5224 Comm: syzkaller431707 Not tainted 4.15.0+ #308
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x194/0x257 lib/dump_stack.c:53
 panic+0x1e4/0x41c kernel/panic.c:183
 __warn+0x1dc/0x200 kernel/panic.c:547
 report_bug+0x211/0x2d0 lib/bug.c:184
 fixup_bug.part.11+0x37/0x80 arch/x86/kernel/traps.c:178
 fixup_bug arch/x86/kernel/traps.c:247 [inline]
 do_error_trap+0x2d7/0x3e0 arch/x86/kernel/traps.c:296
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315
 invalid_op+0x22/0x40 arch/x86/entry/entry_64.S:988
RIP: 0010:proc_register+0x2d6/0x3b0 fs/proc/generic.c:329
RSP: 0018:ffff8801ccdaf3d8 EFLAGS: 00010286
RAX: dffffc0000000008 RBX: ffff8801d222fd50 RCX: ffffffff815aaf3e
RDX: 0000000000000000 RSI: 1ffff100399b5e2b RDI: 1ffff100399b5e00
RBP: ffff8801ccdaf430 R08: 1ffff100399b5dc2 R09: 0000000000000000
R10: ffff8801ccdaf290 R11: 0000000000000000 R12: ffff8801b93d8a40
R13: dffffc0000000000 R14: ffff8801d2a844a0 R15: ffff8801b93d8afb
 proc_create_data+0xf8/0x180 fs/proc/generic.c:494
 clusterip_config_init net/ipv4/netfilter/ipt_CLUSTERIP.c:250 [inline]
 clusterip_tg_check+0xf9c/0x16d0 net/ipv4/netfilter/ipt_CLUSTERIP.c:488
 xt_check_target+0x22c/0x7d0 net/netfilter/x_tables.c:850
 check_target net/ipv4/netfilter/ip_tables.c:513 [inline]
 find_check_entry.isra.8+0x8c8/0xcb0 net/ipv4/netfilter/ip_tables.c:554
 translate_table+0xed1/0x1610 net/ipv4/netfilter/ip_tables.c:725
 do_replace net/ipv4/netfilter/ip_tables.c:1141 [inline]
 do_ipt_set_ctl+0x370/0x5f0 net/ipv4/netfilter/ip_tables.c:1675
 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
 nf_setsockopt+0x67/0xc0 net/netfilter/nf_sockopt.c:115
 ip_setsockopt+0x97/0xa0 net/ipv4/ip_sockglue.c:1259
 udp_setsockopt+0x45/0x80 net/ipv4/udp.c:2401
 sock_common_setsockopt+0x95/0xd0 net/core/sock.c:2975
 SYSC_setsockopt net/socket.c:1849 [inline]
 SyS_setsockopt+0x189/0x360 net/socket.c:1828
 do_syscall_64+0x282/0x940 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x26/0x9b
RIP: 0033:0x44b899
RSP: 002b:00007f0113582d48 EFLAGS: 00000206 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 00000000006ddc50 RCX: 000000000044b899
RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000005
RBP: 00000000006ddc54 R08: 0000000000000360 R09: 0000000000000000
R10: 0000000020664ca0 R11: 0000000000000206 R12: 0000000000000000
R13: 00007ffe87a15f8f R14: 00007f01135839c0 R15: 0000000000000005
Dumping ftrace buffer:
   (ftrace buffer empty)
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (779):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/02/11 14:18 upstream d48fcbd864a0 4e9b726d .config console log report syz C ci-upstream-kasan-gce
2018/02/11 12:39 upstream d48fcbd864a0 4e9b726d .config console log report syz C ci-upstream-kasan-gce
2018/02/09 20:33 upstream f9f1e414128e 2b6b214c .config console log report syz C ci-upstream-kasan-gce
2018/02/06 15:07 upstream e237f98a9c13 66c15deb .config console log report syz C ci-upstream-kasan-gce
2018/02/10 16:04 net-next-old 617aebe6a97e e67d44e0 .config console log report syz C ci-upstream-net-kasan-gce
2018/02/10 14:05 net-next-old 617aebe6a97e e67d44e0 .config console log report syz C ci-upstream-net-kasan-gce
2018/02/09 21:17 net-next-old 617aebe6a97e 2b6b214c .config console log report syz C ci-upstream-net-kasan-gce
2018/02/06 14:14 net-next-old 617aebe6a97e 645ce5da .config console log report syz C ci-upstream-net-kasan-gce
2018/02/23 22:31 upstream 0f9da844d877 33464158 .config console log report ci-upstream-kasan-gce
2018/02/23 21:50 upstream 0f9da844d877 33464158 .config console log report ci-upstream-kasan-gce
2018/02/23 21:22 upstream 0f9da844d877 33464158 .config console log report ci-upstream-kasan-gce
2018/02/23 14:19 upstream 0f9da844d877 33464158 .config console log report ci-upstream-kasan-gce
2018/02/23 13:09 upstream 0f9da844d877 33464158 .config console log report ci-upstream-kasan-gce
2018/02/23 12:12 upstream 0f9da844d877 33464158 .config console log report ci-upstream-kasan-gce
2018/02/20 05:43 upstream 91ab883eb213 c1f526e3 .config console log report ci-upstream-kasan-gce
2018/02/20 04:02 upstream 91ab883eb213 c1f526e3 .config console log report ci-upstream-kasan-gce
2018/02/19 20:21 upstream 91ab883eb213 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/19 18:36 upstream 91ab883eb213 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/19 18:29 upstream 91ab883eb213 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/19 14:25 upstream 91ab883eb213 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/19 13:03 upstream 91ab883eb213 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/19 02:25 upstream 0e06fb5b9ac8 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/18 20:07 upstream c786427f57b6 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/18 19:15 upstream c786427f57b6 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/18 17:23 upstream c786427f57b6 833f78c7 .config console log report ci-upstream-kasan-gce
2018/02/17 02:56 upstream 1a2a7d3ee659 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/17 02:29 upstream 1a2a7d3ee659 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/17 02:08 upstream 1a2a7d3ee659 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 23:26 upstream 1a2a7d3ee659 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 22:17 upstream 1a2a7d3ee659 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 21:32 upstream 1a2a7d3ee659 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 17:32 upstream 1a2a7d3ee659 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 14:08 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 12:31 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 12:00 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 11:42 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 11:15 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 10:40 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 10:32 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 06:26 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 06:09 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 02:31 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 02:00 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/16 01:32 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/15 23:44 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/15 23:04 upstream 1388c80438e6 c8b3f7c1 .config console log report ci-upstream-kasan-gce
2018/02/15 16:45 upstream e525de3ab046 77ed06bf .config console log report ci-upstream-kasan-gce
2018/02/15 11:38 upstream e525de3ab046 77ed06bf .config console log report ci-upstream-kasan-gce
2018/02/06 13:57 upstream e237f98a9c13 645ce5da .config console log report ci-upstream-kasan-gce
* Struck through repros no longer work on HEAD.