syzbot

(syz.0.17,4436,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/4436 is trying to acquire lock:
ffff88805a0706f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365

but task is already holding lock:
ffff88801f2acce8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe0/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13c8/0x1750 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2492
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2529
       ocfs2_enable_quotas+0x1c5/0x490 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x43b5/0x5090 fs/ocfs2/super.c:1139
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2a5/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_xattr_set+0xeb3/0x13e0 fs/ocfs2/xattr.c:3647
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x190/0x2b0 fs/ocfs2/acl.c:285
       set_posix_acl fs/posix_acl.c:1160 [inline]
       posix_acl_xattr_set+0x387/0x3f0 fs/posix_acl.c:1189
       __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:309
       do_setxattr fs/xattr.c:594 [inline]
       setxattr+0x346/0x360 fs/xattr.c:617
       path_setxattr+0x147/0x290 fs/xattr.c:636
       __do_sys_setxattr fs/xattr.c:652 [inline]
       __se_sys_setxattr fs/xattr.c:648 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:648
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_reserve_suballoc_bits+0x16d/0x4810 fs/ocfs2/suballoc.c:782
       ocfs2_reserve_new_metadata_blocks+0x412/0x9a0 fs/ocfs2/suballoc.c:978
       ocfs2_init_xattr_set_ctxt+0x314/0x7b0 fs/ocfs2/xattr.c:3281
       ocfs2_xattr_set+0xc3b/0x13e0 fs/ocfs2/xattr.c:3638
       ocfs2_set_acl+0x4e1/0x590 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x190/0x2b0 fs/ocfs2/acl.c:285
       set_posix_acl fs/posix_acl.c:1160 [inline]
       posix_acl_xattr_set+0x387/0x3f0 fs/posix_acl.c:1189
       __vfs_setxattr+0x3e0/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x129/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:309
       do_setxattr fs/xattr.c:594 [inline]
       setxattr+0x346/0x360 fs/xattr.c:617
       path_setxattr+0x147/0x290 fs/xattr.c:636
       __do_sys_setxattr fs/xattr.c:652 [inline]
       __se_sys_setxattr fs/xattr.c:648 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:648
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
       lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x15e8/0x25b0 fs/ocfs2/namei.c:410
       ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x1181/0x2ee0 fs/namei.c:3788
       do_filp_open+0x1f1/0x430 fs/namei.c:3818
       do_sys_openat2+0x150/0x4b0 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_openat fs/open.c:1352 [inline]
       __se_sys_openat fs/open.c:1347 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1347
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> sb_internal#2 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&journal->j_trans_barrier);
                               lock(sb_internal#2);
                               lock(&journal->j_trans_barrier);
  lock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz.0.17/4436:
 #0: ffff8880792e8460 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:402
 #1: ffff88805a0709c8 (&type->i_mutex_dir_key#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88805a0709c8 (&type->i_mutex_dir_key#8){+.+.}-{3:3}, at: open_last_lookups fs/namei.c:3555 [inline]
 #1: ffff88805a0709c8 (&type->i_mutex_dir_key#8){+.+.}-{3:3}, at: path_openat+0x7d2/0x2ee0 fs/namei.c:3788
 #2: ffff88805a042648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff88805a042648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16d/0x4810 fs/ocfs2/suballoc.c:782
 #3: ffff88805a041808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #3: ffff88805a041808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16d/0x4810 fs/ocfs2/suballoc.c:782
 #4: ffff88805a0442c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #4: ffff88805a0442c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x11e/0x2700 fs/ocfs2/localalloc.c:635
 #5: ffff8880792e8650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_mknod+0xf77/0x25b0 fs/ocfs2/namei.c:361
 #6: ffff88801f2acce8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374
 #7: ffff888079f92990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x200f/0x2230 fs/jbd2/transaction.c:463

stack backtrace:
CPU: 1 PID: 4436 Comm: syz.0.17 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x24e lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
 lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
 down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
 ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
 ocfs2_mknod+0x15e8/0x25b0 fs/ocfs2/namei.c:410
 ocfs2_create+0x1b6/0x4b0 fs/ocfs2/namei.c:674
 lookup_open fs/namei.c:3490 [inline]
 open_last_lookups fs/namei.c:3558 [inline]
 path_openat+0x1181/0x2ee0 fs/namei.c:3788
 do_filp_open+0x1f1/0x430 fs/namei.c:3818
 do_sys_openat2+0x150/0x4b0 fs/open.c:1320
 do_sys_open fs/open.c:1336 [inline]
 __do_sys_openat fs/open.c:1352 [inline]
 __se_sys_openat fs/open.c:1347 [inline]
 __x64_sys_openat+0x135/0x160 fs/open.c:1347
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7ff1da59ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffcb35c5998 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007ff1da815fa0 RCX: 00007ff1da59ce59
RDX: 000000000000275a RSI: 0000200000000540 RDI: ffffffffffffff9c
RBP: 00007ff1da632d6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ff1da815fac R14: 00007ff1da815fa0 R15: 00007ff1da815fa0
 </TASK>